From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Maxime Ripard <maxime@cerno.tech>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA
Date: Tue, 30 Jun 2020 11:49:06 +0100 [thread overview]
Message-ID: <e66478ff-1df0-8f3a-b164-76a430eca58b@arm.com> (raw)
In-Reply-To: <20200630100947.GL28824@8bytes.org>
On 2020-06-30 11:09, Joerg Roedel wrote:
> On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote:
>> On 2020-06-29 13:11, Geert Uytterhoeven wrote:
>>> If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config):
>>>
>>> drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap':
>>> dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot'
>>>
>>> IOMMU_DMA must not be selected, unless HAS_DMA=y.
>>
>> Wait, no, IOMMU_DMA should not be selected by drivers at all - it's for arch
>> code to choose.
>
> Okay, but that is a different fix, right? I queued this patch for v5.8
> for now.
If the driver didn't select IOMMU_DMA (completely unnecessarily, I might
add), there wouldn't be any problem to fix in the first place ;)
Robin.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Maxime Ripard <maxime@cerno.tech>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA
Date: Tue, 30 Jun 2020 11:49:06 +0100 [thread overview]
Message-ID: <e66478ff-1df0-8f3a-b164-76a430eca58b@arm.com> (raw)
In-Reply-To: <20200630100947.GL28824@8bytes.org>
On 2020-06-30 11:09, Joerg Roedel wrote:
> On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote:
>> On 2020-06-29 13:11, Geert Uytterhoeven wrote:
>>> If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config):
>>>
>>> drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap':
>>> dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot'
>>>
>>> IOMMU_DMA must not be selected, unless HAS_DMA=y.
>>
>> Wait, no, IOMMU_DMA should not be selected by drivers at all - it's for arch
>> code to choose.
>
> Okay, but that is a different fix, right? I queued this patch for v5.8
> for now.
If the driver didn't select IOMMU_DMA (completely unnecessarily, I might
add), there wouldn't be any problem to fix in the first place ;)
Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-30 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 12:11 [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA Geert Uytterhoeven
2020-06-29 12:11 ` Geert Uytterhoeven
2020-06-29 13:27 ` Maxime Ripard
2020-06-29 13:27 ` Maxime Ripard
2020-06-29 16:29 ` Robin Murphy
2020-06-29 16:29 ` Robin Murphy
2020-06-30 10:09 ` Joerg Roedel
2020-06-30 10:09 ` Joerg Roedel
2020-06-30 10:49 ` Robin Murphy [this message]
2020-06-30 10:49 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66478ff-1df0-8f3a-b164-76a430eca58b@arm.com \
--to=robin.murphy@arm.com \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.