Re: [PATCH 11/11] dt-bindings: iio: remove QCOM ADC files from iio folder

From: Jishnu Prakash <quic_jprakash@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<agross@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linus.walleij@linaro.org>,
	<Jonathan.Cameron@huawei.com>, <sboyd@kernel.org>,
	<dmitry.baryshkov@linaro.org>, <quic_subbaram@quicinc.com>,
	<quic_collinsd@quicinc.com>, <quic_kamalw@quicinc.com>,
	<quic_jestar@quicinc.com>, <marijn.suijten@somainline.org>,
	<andriy.shevchenko@linux.intel.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-iio@vger.kernel.org>
Cc: <linux-arm-msm-owner@vger.kernel.org>
Subject: Re: [PATCH 11/11] dt-bindings: iio: remove QCOM ADC files from iio folder
Date: Mon, 23 Oct 2023 11:49:44 +0530	[thread overview]
Message-ID: <e6c27567-070e-1765-3d5a-30a6e6fa119b@quicinc.com> (raw)
In-Reply-To: <8b2dd686-382a-f490-7b6e-9603d939bad7@linaro.org>

Hi Krzysztof,

On 7/9/2023 10:58 PM, Krzysztof Kozlowski wrote:
> On 08/07/2023 09:28, Jishnu Prakash wrote:
>> Now that the ADC dt-binding paths have been updated everywhere
>> to use the files copied to the 'iio/adc' folder, remove them
>> from the 'iio' folder.
>>
>> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
>> ---
> Nothing this was explained in previous patches... We should not have to
> read patchset from the end to understand what is happening here. Anyway,
> your commits lack rationale why this is done. Without it, this is pure
> churn which breaks users. ABI breaks need to be explained in the commit
> msg and come with some reason.

I'll try to do the changes in one or two patchsets, based on my replies 
for the previous few patchsets (8, 9, 10), hope this can work.

>
> ...
>
>> -/* 400k pull-up3 */
>> -#define ADC5_GEN3_AMUX1_THM_400K_PU		0x64
>> -#define ADC5_GEN3_AMUX2_THM_400K_PU		0x65
>> -#define ADC5_GEN3_AMUX3_THM_400K_PU		0x66
>> -#define ADC5_GEN3_AMUX4_THM_400K_PU		0x67
>> -#define ADC5_GEN3_AMUX5_THM_400K_PU		0x68
>> -#define ADC5_GEN3_AMUX6_THM_400K_PU		0x69
>> -#define ADC5_GEN3_AMUX1_GPIO_400K_PU		0x6a
>> -#define ADC5_GEN3_AMUX2_GPIO_400K_PU		0x6b
>> -#define ADC5_GEN3_AMUX3_GPIO_400K_PU		0x6c
>> -#define ADC5_GEN3_AMUX4_GPIO_400K_PU		0x6d
>> -
>> -/* 1/3 Divider */
>> -#define ADC5_GEN3_AMUX1_GPIO_DIV3		0x8a
>> -#define ADC5_GEN3_AMUX2_GPIO_DIV3		0x8b
>> -#define ADC5_GEN3_AMUX3_GPIO_DIV3		0x8c
> You just added these defines in previous patches. Don't add them to
> incorrect places just to fix it second later.

Right, I'll avoid this and add the ADC5 Gen3 macros in the 
dt-bindings/iio/adc/ folder in the next patchset, irrespective of what 
happens with updating the file paths, hope there won't be any issues.

Thanks,

Jishnu

>
> Best regards,
> Krzysztof
>