Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs

From: Jishnu Prakash <quic_jprakash@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<agross@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linus.walleij@linaro.org>,
	<Jonathan.Cameron@huawei.com>, <sboyd@kernel.org>,
	<dmitry.baryshkov@linaro.org>, <quic_subbaram@quicinc.com>,
	<quic_collinsd@quicinc.com>, <quic_kamalw@quicinc.com>,
	<marijn.suijten@somainline.org>,
	<andriy.shevchenko@linux.intel.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<cros-qcom-dts-watchers@chromium.org>,
	<linux-arm-msm@vger.kernel.org>
Cc: <linux-iio@vger.kernel.org>, <linux-arm-msm-owner@vger.kernel.org>
Subject: Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs
Date: Thu, 9 Nov 2023 13:52:25 +0530	[thread overview]
Message-ID: <7ccaf08e-0add-33e5-fbea-ce737e53fa28@quicinc.com> (raw)
In-Reply-To: <7af782f3-fe6c-415b-a993-55962845a102@linaro.org>

Hi Krzysztof,

On 10/23/2023 12:02 PM, Krzysztof Kozlowski wrote:
> On 23/10/2023 08:09, Jishnu Prakash wrote:
>> Hi Krzysztof,
>>
>> On 7/9/2023 10:48 PM, Krzysztof Kozlowski wrote:
>>> On 08/07/2023 09:28, Jishnu Prakash wrote:
>>>> The name "ADC7" needs to be replaced with the name "ADC5_GEN2"
>>>> everywhere to match the convention used for these ADC peripherals
>>>> on Qualcomm Technologies, Inc. PMICs. Update devicetree files for
>>> We do not rename compatibles to match convention. Please provide proper
>>> rationale.
>> I'll avoid renaming the compatible directly, will just mark it
>> deprecated - but is it fine to do the other changes, for updating the
>> macro names used in devicetree (replacing the ADC7 macros with the ADC5
>> Gen2 macros)?
> Please provide proper rationale why "ADC7 needs to be replaced". Your
> marketing is not a proper rationale.

The name "ADC7" was the one used internally at first, but it got changed 
later to "ADC5 Gen2" by our HW team, after we had added this support 
both downstream and upstream. Since we are now adding support for the 
next generation named "ADC5 Gen3", we thought it would be helpful to 
indicate in some way that this generation (ADC7) lies between the 
earlier ADC5 and the latest ADC5 Gen3.

Since you do not want us to modify the existing bindings, is it fine if 
I just add a new compatible for ADC5 Gen2 and comments to indicate the 
ADC7 compatible should be considered deprecated?

If you are not convinced, we can drop the Gen2 name related changes from 
the patch series.

>
>> I do see an example of a macro change in devicetree done in this patch:
>> https://lore.kernel.org/all/cover.1646388139.git.zong.li@sifive.com/.
>>
>> Patch 2 here replaced some macro definitions:
>> https://lore.kernel.org/all/f9284873c2993a9952d9fe4f8dd5e89f20daab75.1646388139.git.zong.li@sifive.com/.
>>
>> Patch 3 made the corresponding update in devicetree files:
>> https://lore.kernel.org/all/db92d209fa700f7da8bc8028083476fcc138d80e.1646388139.git.zong.li@sifive.com/.
> And what is rationale in that patchset?

Right, I see that the change was made to refactor the driver code and 
avoid unused variable errors, not just a name change.

Thanks,

Jishnu

>
>>
>>   From this mail, it looks like the maintainer was willing to pick them
>> at that time:
>> https://lore.kernel.org/all/20220315225652.CDAD1C340E8@smtp.kernel.org/,
>> would something similar be possible here?
> For stated before marketing reasons - no, would not be possible.
>
> Best regards,
> Krzysztof
>