From: "Kalakodima Venkata Rajesh (RBEI/ECF3)" <VenkataRajesh.Kalakodima@in.bosch.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org>, "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>, "kieran.bingham+renesas@ideasonboard.com" <kieran.bingham+renesas@ideasonboard.com>, "geert@linux-m68k.org" <geert@linux-m68k.org>, "horms@verge.net.au" <horms@verge.net.au>, "uli+renesas@fpond.eu" <uli+renesas@fpond.eu> Cc: "airlied@linux.ie" <airlied@linux.ie>, "daniel@ffwll.ch" <daniel@ffwll.ch>, "koji.matsuoka.xm@renesas.com" <koji.matsuoka.xm@renesas.com>, "muroya@ksk.co.jp" <muroya@ksk.co.jp>, "Harsha Manjula Mallikarjun (RBEI/ECF3)" <Harsha.ManjulaMallikarjun@in.bosch.com>, "ezequiel@collabora.com" <ezequiel@collabora.com>, "seanpaul@chromium.org" <seanpaul@chromium.org>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Date: Mon, 11 Nov 2019 11:21:28 +0000 [thread overview] Message-ID: <e731216a728c4035af88c92b70756197@in.bosch.com> (raw) In-Reply-To: <20191015104621.62514-1-jacopo+renesas@jmondi.org> Hi Jacopo, Please find comments below. Best regards, Rajesh Kv RBEI/ECF3 > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org <linux-kernel- > owner@vger.kernel.org> On Behalf Of Jacopo Mondi > Sent: Tuesday, October 15, 2019 4:16 PM > To: laurent.pinchart@ideasonboard.com; > kieran.bingham+renesas@ideasonboard.com; geert@linux-m68k.org; > horms@verge.net.au; uli+renesas@fpond.eu; Kalakodima Venkata Rajesh > (RBEI/ECF3) <VenkataRajesh.Kalakodima@in.bosch.com> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; airlied@linux.ie; > daniel@ffwll.ch; koji.matsuoka.xm@renesas.com; muroya@ksk.co.jp; Harsha > Manjula Mallikarjun (RBEI/ECF3) <Harsha.ManjulaMallikarjun@in.bosch.com>; > ezequiel@collabora.com; seanpaul@chromium.org; linux-renesas- > soc@vger.kernel.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) > > References: > A reference to the v1 cover letter, with some background on the CMM is > available here: > https://lkml.org/lkml/2019/6/6/583 > v2: > https://lore.kernel.org/linux-renesas-soc/20190706140746.29132-10- > jacopo+renesas@jmondi.org/ > v3: > https://lore.kernel.org/linux-renesas-soc/20190825135154.11488-1- > jacopo+renesas@jmondi.org/ > v4: > https://lore.kernel.org/linux-renesas-soc/20190906135436.10622-1- > jacopo+renesas@jmondi.org/ > > Again, quite a consistent changelog, mostly due to the developments happened > on Ezequiel's VOP unit following Sean's advices. > > I here implemented the same, and moved the CMM handling to the crtc being > and enable callbacks. As a result the overall implementation results quite a lot > simplified, mostly on the CMM driver side. > > I have dropped tags and acks on the CMM driver and CMM enablement patches > in DU crtc driver because of the number of changes. > > A more detailed change log: > > - Rebased on renesas-devel-2019-10-07-v5.4-rc4 > > * Bindings/DT > - Included Rob's comments on the yaml file license and the use of 'OneOf' > in the compatible property description > - Use the bracketed style suggested by Kieran for the 'renesas,cmm' property > introduced in patch 2 > - Re-order the properties in the SoC DTS files as suggested by Kieran > > * CMM/DU > - As anticipated, moved CMM management to the crtc from the atomic commit > tail > helper where it was implemented in v4 > This allow to correctly support resume/suspend and proper ordering of the > CMM > enable and setup operations (enable -before- setup) > - As a consequence the CMM driver is greatly simplified by removing the need > to cache the LUT table entries provided to cmm_setup() and later re-apply > them at enable time. > - Better support handling of disabled CMM config option by returning -ENODEV > at cmm_init() time as suggested by Kieran. > > * Testing > I have tested by injecting a color inversion LUT table and enabling/disabling it > every 50 displayed frames: > https://jmondi.org/cgit/kmsxx/log/?h=gamma_lut > > CMM functionalities are retained between suspend/resume cycles (tested with > suspend-to-idle) without requiring a re-programming of the LUT tables. > > Testing with real world use cases might be beneficial. Rajesh are you still > interested in giving this series a spin I have tested version v3 of CMM module with a demo application based on libdrm library. I could successfully test setting of Gamma LUT. Next step is to test on full featured graphics stack i.e. involving Weston and OpenGL. Weston can set Gamma. I have to stop this work for a while due to other high prio activities. I plan to resume soon. > > Laurent, Kieran, could we fast-track review of this and hopefully try to have it > merged for v5.5 ? > > Thanks Ezequiel for having suggested me this solution. > > Thanks > j > > Jacopo Mondi (8): > dt-bindings: display: renesas,cmm: Add R-Car CMM documentation > dt-bindings: display, renesas,du: Document cmms property > drm: rcar-du: Add support for CMM > drm: rcar-du: kms: Initialize CMM instances > drm: rcar-du: crtc: Control CMM operations > drm: rcar-du: crtc: Register GAMMA_LUT properties > arm64: dts: renesas: Add CMM units to Gen3 SoCs > drm: rcar-du: kms: Expand comment in vsps parsing routine > > .../bindings/display/renesas,cmm.yaml | 67 ++++++ > .../bindings/display/renesas,du.txt | 5 + > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 39 ++++ > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 31 ++- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 31 ++- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 21 ++ > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 21 ++ > drivers/gpu/drm/rcar-du/Kconfig | 7 + > drivers/gpu/drm/rcar-du/Makefile | 1 + > drivers/gpu/drm/rcar-du/rcar_cmm.c | 198 ++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_cmm.h | 60 ++++++ > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 89 ++++++++ > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_group.c | 5 + > drivers/gpu/drm/rcar-du/rcar_du_group.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 82 +++++++- > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 + > 18 files changed, 665 insertions(+), 3 deletions(-) create mode 100644 > Documentation/devicetree/bindings/display/renesas,cmm.yaml > create mode 100644 drivers/gpu/drm/rcar-du/rcar_cmm.c > create mode 100644 drivers/gpu/drm/rcar-du/rcar_cmm.h > > -- > 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: "Kalakodima Venkata Rajesh (RBEI/ECF3)" <VenkataRajesh.Kalakodima@in.bosch.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org>, "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>, "kieran.bingham+renesas@ideasonboard.com" <kieran.bingham+renesas@ideasonboard.com>, "geert@linux-m68k.org" <geert@linux-m68k.org>, "horms@verge.net.au" <horms@verge.net.au>, "uli+renesas@fpond.eu" <uli+renesas@fpond.eu> Cc: "muroya@ksk.co.jp" <muroya@ksk.co.jp>, "airlied@linux.ie" <airlied@linux.ie>, "koji.matsuoka.xm@renesas.com" <koji.matsuoka.xm@renesas.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, "seanpaul@chromium.org" <seanpaul@chromium.org>, "Harsha Manjula Mallikarjun \(RBEI/ECF3\)" <Harsha.ManjulaMallikarjun@in.bosch.com>, "ezequiel@collabora.com" <ezequiel@collabora.com> Subject: RE: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Date: Mon, 11 Nov 2019 11:21:28 +0000 [thread overview] Message-ID: <e731216a728c4035af88c92b70756197@in.bosch.com> (raw) Message-ID: <20191111112128.EnnLlFDQngS9FuRW2CLSwPiuI34kNr13UYTsqzqeev4@z> (raw) In-Reply-To: <20191015104621.62514-1-jacopo+renesas@jmondi.org> Hi Jacopo, Please find comments below. Best regards, Rajesh Kv RBEI/ECF3 > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org <linux-kernel- > owner@vger.kernel.org> On Behalf Of Jacopo Mondi > Sent: Tuesday, October 15, 2019 4:16 PM > To: laurent.pinchart@ideasonboard.com; > kieran.bingham+renesas@ideasonboard.com; geert@linux-m68k.org; > horms@verge.net.au; uli+renesas@fpond.eu; Kalakodima Venkata Rajesh > (RBEI/ECF3) <VenkataRajesh.Kalakodima@in.bosch.com> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; airlied@linux.ie; > daniel@ffwll.ch; koji.matsuoka.xm@renesas.com; muroya@ksk.co.jp; Harsha > Manjula Mallikarjun (RBEI/ECF3) <Harsha.ManjulaMallikarjun@in.bosch.com>; > ezequiel@collabora.com; seanpaul@chromium.org; linux-renesas- > soc@vger.kernel.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) > > References: > A reference to the v1 cover letter, with some background on the CMM is > available here: > https://lkml.org/lkml/2019/6/6/583 > v2: > https://lore.kernel.org/linux-renesas-soc/20190706140746.29132-10- > jacopo+renesas@jmondi.org/ > v3: > https://lore.kernel.org/linux-renesas-soc/20190825135154.11488-1- > jacopo+renesas@jmondi.org/ > v4: > https://lore.kernel.org/linux-renesas-soc/20190906135436.10622-1- > jacopo+renesas@jmondi.org/ > > Again, quite a consistent changelog, mostly due to the developments happened > on Ezequiel's VOP unit following Sean's advices. > > I here implemented the same, and moved the CMM handling to the crtc being > and enable callbacks. As a result the overall implementation results quite a lot > simplified, mostly on the CMM driver side. > > I have dropped tags and acks on the CMM driver and CMM enablement patches > in DU crtc driver because of the number of changes. > > A more detailed change log: > > - Rebased on renesas-devel-2019-10-07-v5.4-rc4 > > * Bindings/DT > - Included Rob's comments on the yaml file license and the use of 'OneOf' > in the compatible property description > - Use the bracketed style suggested by Kieran for the 'renesas,cmm' property > introduced in patch 2 > - Re-order the properties in the SoC DTS files as suggested by Kieran > > * CMM/DU > - As anticipated, moved CMM management to the crtc from the atomic commit > tail > helper where it was implemented in v4 > This allow to correctly support resume/suspend and proper ordering of the > CMM > enable and setup operations (enable -before- setup) > - As a consequence the CMM driver is greatly simplified by removing the need > to cache the LUT table entries provided to cmm_setup() and later re-apply > them at enable time. > - Better support handling of disabled CMM config option by returning -ENODEV > at cmm_init() time as suggested by Kieran. > > * Testing > I have tested by injecting a color inversion LUT table and enabling/disabling it > every 50 displayed frames: > https://jmondi.org/cgit/kmsxx/log/?h=gamma_lut > > CMM functionalities are retained between suspend/resume cycles (tested with > suspend-to-idle) without requiring a re-programming of the LUT tables. > > Testing with real world use cases might be beneficial. Rajesh are you still > interested in giving this series a spin I have tested version v3 of CMM module with a demo application based on libdrm library. I could successfully test setting of Gamma LUT. Next step is to test on full featured graphics stack i.e. involving Weston and OpenGL. Weston can set Gamma. I have to stop this work for a while due to other high prio activities. I plan to resume soon. > > Laurent, Kieran, could we fast-track review of this and hopefully try to have it > merged for v5.5 ? > > Thanks Ezequiel for having suggested me this solution. > > Thanks > j > > Jacopo Mondi (8): > dt-bindings: display: renesas,cmm: Add R-Car CMM documentation > dt-bindings: display, renesas,du: Document cmms property > drm: rcar-du: Add support for CMM > drm: rcar-du: kms: Initialize CMM instances > drm: rcar-du: crtc: Control CMM operations > drm: rcar-du: crtc: Register GAMMA_LUT properties > arm64: dts: renesas: Add CMM units to Gen3 SoCs > drm: rcar-du: kms: Expand comment in vsps parsing routine > > .../bindings/display/renesas,cmm.yaml | 67 ++++++ > .../bindings/display/renesas,du.txt | 5 + > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 39 ++++ > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 31 ++- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 31 ++- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 21 ++ > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 21 ++ > drivers/gpu/drm/rcar-du/Kconfig | 7 + > drivers/gpu/drm/rcar-du/Makefile | 1 + > drivers/gpu/drm/rcar-du/rcar_cmm.c | 198 ++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_cmm.h | 60 ++++++ > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 89 ++++++++ > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_group.c | 5 + > drivers/gpu/drm/rcar-du/rcar_du_group.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 82 +++++++- > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 + > 18 files changed, 665 insertions(+), 3 deletions(-) create mode 100644 > Documentation/devicetree/bindings/display/renesas,cmm.yaml > create mode 100644 drivers/gpu/drm/rcar-du/rcar_cmm.c > create mode 100644 drivers/gpu/drm/rcar-du/rcar_cmm.h > > -- > 2.23.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-11 11:27 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 10:46 [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Jacopo Mondi 2019-10-15 10:46 ` [PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi 2019-10-15 11:38 ` Kieran Bingham 2019-10-15 14:03 ` Geert Uytterhoeven 2019-10-15 14:03 ` Geert Uytterhoeven 2019-10-15 10:46 ` [PATCH v5 2/8] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi 2019-10-15 10:46 ` [PATCH v5 3/8] drm: rcar-du: Add support for CMM Jacopo Mondi 2019-10-15 11:53 ` Kieran Bingham 2019-10-15 11:53 ` Kieran Bingham 2019-10-15 13:17 ` Kieran Bingham 2019-10-15 13:33 ` Jacopo Mondi 2019-10-15 13:33 ` Jacopo Mondi 2019-10-15 14:26 ` Kieran Bingham 2019-10-15 14:26 ` Kieran Bingham 2019-10-15 17:25 ` Laurent Pinchart 2019-10-15 10:46 ` [PATCH v5 4/8] drm: rcar-du: kms: Initialize CMM instances Jacopo Mondi 2019-10-15 10:46 ` [PATCH v5 5/8] drm: rcar-du: crtc: Control CMM operations Jacopo Mondi 2019-10-15 13:15 ` Kieran Bingham 2019-10-15 13:15 ` Kieran Bingham 2019-10-15 13:37 ` Jacopo Mondi 2019-10-15 17:54 ` Laurent Pinchart 2019-10-15 17:54 ` Laurent Pinchart 2019-10-15 19:17 ` Jacopo Mondi 2019-10-15 19:17 ` Jacopo Mondi 2019-10-15 19:53 ` Laurent Pinchart 2019-10-15 10:46 ` [PATCH v5 6/8] drm: rcar-du: crtc: Register GAMMA_LUT properties Jacopo Mondi 2019-10-15 10:46 ` [PATCH v5 7/8] arm64: dts: renesas: Add CMM units to Gen3 SoCs Jacopo Mondi 2019-10-15 12:52 ` Kieran Bingham 2019-10-15 18:06 ` Laurent Pinchart 2019-10-15 10:46 ` [PATCH v5 8/8] drm: rcar-du: kms: Expand comment in vsps parsing routine Jacopo Mondi 2019-10-15 13:04 ` Kieran Bingham 2019-10-15 16:54 ` [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Laurent Pinchart 2019-11-11 11:21 ` Kalakodima Venkata Rajesh (RBEI/ECF3) [this message] 2019-11-11 11:21 ` Kalakodima Venkata Rajesh (RBEI/ECF3) 2019-11-11 11:21 ` Kalakodima Venkata Rajesh (RBEI/ECF3) 2019-11-11 13:06 ` Jacopo Mondi 2019-11-11 13:06 ` Jacopo Mondi 2019-11-11 13:06 ` Jacopo Mondi 2020-05-27 7:15 ` Eugeniu Rosca 2020-05-27 7:15 ` Eugeniu Rosca 2020-05-27 7:34 ` Geert Uytterhoeven 2020-05-27 7:34 ` Geert Uytterhoeven 2020-05-27 7:40 ` Gotthard Voellmeke 2020-05-27 7:40 ` Gotthard Voellmeke 2020-05-27 7:44 ` Eugeniu Rosca 2020-05-27 7:44 ` Eugeniu Rosca 2020-06-05 13:29 ` Jacopo Mondi 2020-06-05 13:29 ` Jacopo Mondi 2020-06-05 13:41 ` Eugeniu Rosca 2020-06-05 13:41 ` Eugeniu Rosca 2020-06-05 13:53 ` Jacopo Mondi 2020-06-05 13:53 ` Jacopo Mondi 2020-06-07 2:41 ` Laurent Pinchart 2020-06-07 2:41 ` Laurent Pinchart 2020-06-08 9:44 ` Eugeniu Rosca 2020-06-08 9:44 ` Eugeniu Rosca 2020-06-12 15:12 ` Jacopo Mondi 2020-06-12 15:12 ` Jacopo Mondi 2020-06-15 14:17 ` Eugeniu Rosca 2020-06-15 14:17 ` Eugeniu Rosca 2020-07-17 15:06 ` Jacopo Mondi 2020-07-17 15:06 ` Jacopo Mondi 2020-06-09 14:29 ` Eugeniu Rosca 2020-06-09 14:29 ` Eugeniu Rosca 2020-06-12 15:00 ` Jacopo Mondi 2020-06-12 15:00 ` Jacopo Mondi 2020-06-12 15:10 ` Laurent Pinchart 2020-06-12 15:10 ` Laurent Pinchart 2020-06-12 15:36 ` Eugeniu Rosca 2020-06-12 15:36 ` Eugeniu Rosca 2020-06-12 15:50 ` Laurent Pinchart 2020-06-12 15:50 ` Laurent Pinchart 2020-08-18 9:50 ` Geert Uytterhoeven 2020-08-18 9:50 ` Geert Uytterhoeven 2020-06-05 19:05 ` Laurent Pinchart 2020-06-05 19:05 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e731216a728c4035af88c92b70756197@in.bosch.com \ --to=venkatarajesh.kalakodima@in.bosch.com \ --cc=Harsha.ManjulaMallikarjun@in.bosch.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=ezequiel@collabora.com \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=koji.matsuoka.xm@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=muroya@ksk.co.jp \ --cc=seanpaul@chromium.org \ --cc=uli+renesas@fpond.eu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.