All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@pengutronix.de, Sergey Kozlov <serjk@netup.ru>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: [PATCH v2 07/33] media: netup_unidvb: Follow renaming of SPI "master" to "controller"
Date: Mon, 22 Jan 2024 19:07:02 +0100	[thread overview]
Message-ID: <e745359645a4af795f229d84e39949fe75bd2ec8.1705944943.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1705944943.git.u.kleine-koenig@pengutronix.de>

In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"")
some functions and struct members were renamed. To not break all drivers
compatibility macros were provided.

To be able to remove these compatibility macros push the renaming into
this driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 .../media/pci/netup_unidvb/netup_unidvb_spi.c | 48 +++++++++----------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c b/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
index 526042d8afae..e90aa1c1584c 100644
--- a/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
+++ b/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
@@ -35,7 +35,7 @@ struct netup_spi_regs {
 
 struct netup_spi {
 	struct device			*dev;
-	struct spi_master		*master;
+	struct spi_controller		*ctlr;
 	struct netup_spi_regs __iomem	*regs;
 	u8 __iomem			*mmio;
 	spinlock_t			lock;
@@ -78,7 +78,7 @@ irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
 	reg = readw(&spi->regs->control_stat);
 	if (!(reg & NETUP_SPI_CTRL_IRQ)) {
 		spin_unlock_irqrestore(&spi->lock, flags);
-		dev_dbg(&spi->master->dev,
+		dev_dbg(&spi->ctlr->dev,
 			"%s(): not mine interrupt\n", __func__);
 		return IRQ_NONE;
 	}
@@ -88,15 +88,15 @@ irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
 	spi->state = SPI_STATE_DONE;
 	wake_up(&spi->waitq);
 	spin_unlock_irqrestore(&spi->lock, flags);
-	dev_dbg(&spi->master->dev,
+	dev_dbg(&spi->ctlr->dev,
 		"%s(): SPI interrupt handled\n", __func__);
 	return IRQ_HANDLED;
 }
 
-static int netup_spi_transfer(struct spi_master *master,
+static int netup_spi_transfer(struct spi_controller *ctlr,
 			      struct spi_message *msg)
 {
-	struct netup_spi *spi = spi_master_get_devdata(master);
+	struct netup_spi *spi = spi_controller_get_devdata(ctlr);
 	struct spi_transfer *t;
 	int result = 0;
 	u32 tr_size;
@@ -131,7 +131,7 @@ static int netup_spi_transfer(struct spi_master *master,
 				NETUP_SPI_CTRL_START |
 				(frag_last ? NETUP_SPI_CTRL_LAST_CS : 0),
 				&spi->regs->control_stat);
-			dev_dbg(&spi->master->dev,
+			dev_dbg(&spi->ctlr->dev,
 				"%s(): control_stat 0x%04x\n",
 				__func__, readw(&spi->regs->control_stat));
 			wait_event_timeout(spi->waitq,
@@ -144,11 +144,11 @@ static int netup_spi_transfer(struct spi_master *master,
 				}
 			} else {
 				if (spi->state == SPI_STATE_START) {
-					dev_dbg(&spi->master->dev,
+					dev_dbg(&spi->ctlr->dev,
 						"%s(): transfer timeout\n",
 						__func__);
 				} else {
-					dev_dbg(&spi->master->dev,
+					dev_dbg(&spi->ctlr->dev,
 						"%s(): invalid state %d\n",
 						__func__, spi->state);
 				}
@@ -161,7 +161,7 @@ static int netup_spi_transfer(struct spi_master *master,
 	}
 done:
 	msg->status = result;
-	spi_finalize_current_message(master);
+	spi_finalize_current_message(ctlr);
 	return result;
 }
 
@@ -172,30 +172,30 @@ static int netup_spi_setup(struct spi_device *spi)
 
 int netup_spi_init(struct netup_unidvb_dev *ndev)
 {
-	struct spi_master *master;
+	struct spi_controller *ctlr;
 	struct netup_spi *nspi;
 
-	master = devm_spi_alloc_master(&ndev->pci_dev->dev,
-		sizeof(struct netup_spi));
-	if (!master) {
+	ctlr = devm_spi_alloc_master(&ndev->pci_dev->dev,
+					 sizeof(struct netup_spi));
+	if (!ctlr) {
 		dev_err(&ndev->pci_dev->dev,
 			"%s(): unable to alloc SPI master\n", __func__);
 		return -EINVAL;
 	}
-	nspi = spi_master_get_devdata(master);
-	master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST;
-	master->bus_num = -1;
-	master->num_chipselect = 1;
-	master->transfer_one_message = netup_spi_transfer;
-	master->setup = netup_spi_setup;
+	nspi = spi_controller_get_devdata(ctlr);
+	ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST;
+	ctlr->bus_num = -1;
+	ctlr->num_chipselect = 1;
+	ctlr->transfer_one_message = netup_spi_transfer;
+	ctlr->setup = netup_spi_setup;
 	spin_lock_init(&nspi->lock);
 	init_waitqueue_head(&nspi->waitq);
-	nspi->master = master;
+	nspi->ctlr = ctlr;
 	nspi->regs = (struct netup_spi_regs __iomem *)(ndev->bmmio0 + 0x4000);
 	writew(2, &nspi->regs->clock_divider);
 	writew(NETUP_UNIDVB_IRQ_SPI, ndev->bmmio0 + REG_IMASK_SET);
 	ndev->spi = nspi;
-	if (spi_register_master(master)) {
+	if (spi_register_controller(ctlr)) {
 		ndev->spi = NULL;
 		dev_err(&ndev->pci_dev->dev,
 			"%s(): unable to register SPI bus\n", __func__);
@@ -207,8 +207,8 @@ int netup_spi_init(struct netup_unidvb_dev *ndev)
 		ndev->pci_bus,
 		ndev->pci_slot,
 		ndev->pci_func);
-	if (!spi_new_device(master, &netup_spi_board)) {
-		spi_unregister_master(master);
+	if (!spi_new_device(ctlr, &netup_spi_board)) {
+		spi_unregister_controller(ctlr);
 		ndev->spi = NULL;
 		dev_err(&ndev->pci_dev->dev,
 			"%s(): unable to create SPI device\n", __func__);
@@ -227,7 +227,7 @@ void netup_spi_release(struct netup_unidvb_dev *ndev)
 	if (!spi)
 		return;
 
-	spi_unregister_master(spi->master);
+	spi_unregister_controller(spi->ctlr);
 	spin_lock_irqsave(&spi->lock, flags);
 	reg = readw(&spi->regs->control_stat);
 	writew(reg | NETUP_SPI_CTRL_IRQ, &spi->regs->control_stat);
-- 
2.43.0


  parent reply	other threads:[~2024-01-22 18:08 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 18:06 [PATCH v2 00/33] spi: get rid of some legacy macros Uwe Kleine-König
2024-01-22 18:06 ` Uwe Kleine-König
2024-01-22 18:06 ` Uwe Kleine-König
2024-01-22 18:06 ` [PATCH v2 01/33] fpga: ice40-spi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-22 18:06 ` [PATCH v2 02/33] ieee802154: ca8210: " Uwe Kleine-König
2024-01-22 18:16   ` Miquel Raynal
2024-01-22 18:06 ` [PATCH v2 03/33] iio: adc: ad_sigma_delta: " Uwe Kleine-König
2024-01-22 18:06 ` [PATCH v2 04/33] Input: pxspad - follow " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 05/33] Input: synaptics-rmi4 " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 06/33] media: mgb4: Follow " Uwe Kleine-König
2024-01-22 18:07 ` Uwe Kleine-König [this message]
2024-02-07  4:43   ` [PATCH v2 07/33] media: netup_unidvb: " Mauro Carvalho Chehab
2024-01-22 18:07 ` [PATCH v2 08/33] media: usb/msi2500: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 09/33] media: v4l2-subdev: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 10/33] misc: gehc-achc: " Uwe Kleine-König
2024-01-24 17:31   ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 11/33] mmc: mmc_spi: " Uwe Kleine-König
2024-01-23 13:09   ` Ulf Hansson
2024-01-23 13:16     ` Mark Brown
2024-01-22 18:07 ` [PATCH v2 12/33] mtd: dataflash: " Uwe Kleine-König
2024-01-22 18:07   ` Uwe Kleine-König
2024-01-22 18:13   ` Miquel Raynal
2024-01-22 18:13     ` Miquel Raynal
2024-01-22 18:07 ` [PATCH v2 13/33] mtd: rawnand: fsl_elbc: Let .probe retry if local bus is missing Uwe Kleine-König
2024-01-22 18:07   ` Uwe Kleine-König
2024-01-22 18:19   ` Miquel Raynal
2024-01-22 18:19     ` Miquel Raynal
2024-01-22 21:29     ` Uwe Kleine-König
2024-01-22 21:29       ` Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 14/33] net: ks8851: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 15/33] net: vertexcom: mse102x: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 16/33] platform/chrome: cros_ec_spi: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 17/33] spi: bitbang: " Uwe Kleine-König
2024-01-22 18:07   ` Uwe Kleine-König
2024-01-30 10:46   ` kernel test robot
2024-01-30 10:46     ` kernel test robot
2024-02-02 13:08     ` Uwe Kleine-König
2024-02-02 13:08       ` Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 18/33] spi: cadence-quadspi: Don't emit error message on allocation error Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 19/33] spi: cadence-quadspi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 20/33] spi: cavium: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 21/33] spi: geni-qcom: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 22/33] spi: loopback-test: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 23/33] spi: slave-mt27xx: " Uwe Kleine-König
2024-01-22 18:07   ` Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 24/33] spi: spidev: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 25/33] staging: fbtft: " Uwe Kleine-König
2024-01-22 18:07   ` Uwe Kleine-König
2024-01-24 17:31   ` Greg Kroah-Hartman
2024-01-24 17:31     ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 26/33] staging: greybus: spi: " Uwe Kleine-König
2024-01-24 17:31   ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 27/33] tpm_tis_spi: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 28/33] usb: gadget: max3420_udc: " Uwe Kleine-König
2024-01-24 17:31   ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 29/33] video: fbdev: mmp: " Uwe Kleine-König
2024-01-22 18:07   ` Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 30/33] wifi: libertas: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 31/33] spi: fsl-lib: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 32/33] spi: Drop compat layer from renaming " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 33/33] Documentation: spi: Update documentation for " Uwe Kleine-König
2024-01-22 18:18 ` [PATCH v2 00/33] spi: get rid of some legacy macros Mark Brown
2024-01-22 18:18   ` Mark Brown
2024-01-22 18:18   ` Mark Brown
2024-01-22 19:23   ` Jonathan Cameron
2024-01-22 19:23     ` Jonathan Cameron
2024-01-22 19:23     ` Jonathan Cameron
2024-01-24 20:02     ` Jonathan Cameron
2024-01-24 20:02       ` Jonathan Cameron
2024-01-24 20:02       ` Jonathan Cameron
2024-01-24 17:13 ` Greg Kroah-Hartman
2024-01-24 17:13   ` Greg Kroah-Hartman
2024-01-24 17:13   ` Greg Kroah-Hartman
2024-01-24 17:22   ` Mark Brown
2024-01-24 17:22     ` Mark Brown
2024-01-24 17:22     ` Mark Brown
2024-01-24 17:30     ` Greg Kroah-Hartman
2024-01-24 17:30       ` Greg Kroah-Hartman
2024-01-24 17:30       ` Greg Kroah-Hartman
2024-02-01 21:47     ` Jarkko Sakkinen
2024-02-01 21:47       ` Jarkko Sakkinen
2024-02-12 15:33 ` (subset) " Mark Brown
2024-02-12 15:33   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e745359645a4af795f229d84e39949fe75bd2ec8.1705944943.git.u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=broonie@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=serjk@netup.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.