Re: [PATCH v2 13/33] mtd: rawnand: fsl_elbc: Let .probe retry if local bus is missing - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Vignesh Raghavendra" <vigneshr@ti.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Richard Weinberger" <richard@nod.at>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	"Mark Brown" <broonie@kernel.org>,
	linux-mtd@lists.infradead.org, kernel@pengutronix.de,
	"Pali Rohár" <pali@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>
Subject: Re: [PATCH v2 13/33] mtd: rawnand: fsl_elbc: Let .probe retry if local bus is missing
Date: Mon, 22 Jan 2024 22:29:07 +0100	[thread overview]
Message-ID: <33kxj5ij25bzkyhuww5kane2sb2f3euyq3uoudlgegfks3xs4f@ru24kc6z55je> (raw)
In-Reply-To: <20240122191931.17807644@xps-13>

[-- Attachment #1.1: Type: text/plain, Size: 1376 bytes --]

Hi Miquèl,

On Mon, Jan 22, 2024 at 07:19:44PM +0100, Miquel Raynal wrote:
> u.kleine-koenig@pengutronix.de wrote on Mon, 22 Jan 2024 19:07:08 +0100:
> 
> > If during probe fsl_lbc_ctrl_dev is NULL that might just be because the
> > fsl_lbc driver didn't bind yet. So return -EPROBE_DEFER in this case to
> > make the driver core retry probing later.
> 
> Despite the probable usefulness of this change, I don't see any
> relationship with the current series. So unless there is a good reason
> I might take this one through the nand tree.

This patch indeed doesn't belong into this series. It just happend to be
in my tree and shuffled into the middle when I sorted the patches by
subsystem. Note I already sent it separately at

	https://lore.kernel.org/linux-mtd/20240115141245.3415035-2-u.kleine-koenig@pengutronix.de

> Also, what about a Fixes/Cc: stable tag here?

The problem exists since

	3ab8f2a2e701 ("P4080/eLBC: Make Freescale elbc interrupt common to elbc devices")

which was included in v2.6.37-rc1. At that time there was no
EPROBE_DEFER yet. I think I wouldn't add a Fixes: line for that, but
feel free to add one if you think there should be one.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/