All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, stable@vger.kernel.org,
	Kevin Boulain <kevinboulain@gmail.com>,
	David de Sousa <davidesousa@gmail.com>
Subject: Re: [PATCH RESEND] drm/i915: Fix display problems after resume
Date: Wed, 5 Oct 2022 14:32:52 +0100	[thread overview]
Message-ID: <e9722ab4-31fe-3f2e-a1e6-5df5d1bef623@intel.com> (raw)
In-Reply-To: <20221005121159.340245-1-thomas.hellstrom@linux.intel.com>

Hi Thomas,

On 05/10/2022 13:11, Thomas Hellström wrote:
> Commit 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt
> binding / unbinding") introduced a regression that due to the vma resource
> tracking of the binding state, dpt ptes were not correctly repopulated.
> Fix this by clearing the vma resource state before repopulating.
> The state will subsequently be restored by the bind_vma operation.
> 
> Fixes: 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt binding / unbinding")
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20220912121957.31310-1-thomas.hellstrom@linux.intel.com
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.18+
> Reported-and-tested-by: Kevin Boulain <kevinboulain@gmail.com>
> Tested-by: David de Sousa <davidesousa@gmail.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Kevin Boulain <kevinboulain@gmail.com>,
	David de Sousa <davidesousa@gmail.com>,
	stable@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND] drm/i915: Fix display problems after resume
Date: Wed, 5 Oct 2022 14:32:52 +0100	[thread overview]
Message-ID: <e9722ab4-31fe-3f2e-a1e6-5df5d1bef623@intel.com> (raw)
In-Reply-To: <20221005121159.340245-1-thomas.hellstrom@linux.intel.com>

Hi Thomas,

On 05/10/2022 13:11, Thomas Hellström wrote:
> Commit 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt
> binding / unbinding") introduced a regression that due to the vma resource
> tracking of the binding state, dpt ptes were not correctly repopulated.
> Fix this by clearing the vma resource state before repopulating.
> The state will subsequently be restored by the bind_vma operation.
> 
> Fixes: 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt binding / unbinding")
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20220912121957.31310-1-thomas.hellstrom@linux.intel.com
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.18+
> Reported-and-tested-by: Kevin Boulain <kevinboulain@gmail.com>
> Tested-by: David de Sousa <davidesousa@gmail.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Kevin Boulain <kevinboulain@gmail.com>,
	David de Sousa <davidesousa@gmail.com>,
	stable@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix display problems after resume
Date: Wed, 5 Oct 2022 14:32:52 +0100	[thread overview]
Message-ID: <e9722ab4-31fe-3f2e-a1e6-5df5d1bef623@intel.com> (raw)
In-Reply-To: <20221005121159.340245-1-thomas.hellstrom@linux.intel.com>

Hi Thomas,

On 05/10/2022 13:11, Thomas Hellström wrote:
> Commit 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt
> binding / unbinding") introduced a regression that due to the vma resource
> tracking of the binding state, dpt ptes were not correctly repopulated.
> Fix this by clearing the vma resource state before repopulating.
> The state will subsequently be restored by the bind_vma operation.
> 
> Fixes: 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt binding / unbinding")
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20220912121957.31310-1-thomas.hellstrom@linux.intel.com
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.18+
> Reported-and-tested-by: Kevin Boulain <kevinboulain@gmail.com>
> Tested-by: David de Sousa <davidesousa@gmail.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>


  parent reply	other threads:[~2022-10-05 13:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 12:11 [PATCH RESEND] drm/i915: Fix display problems after resume Thomas Hellström
2022-10-05 12:11 ` [Intel-gfx] " Thomas Hellström
2022-10-05 12:11 ` Thomas Hellström
2022-10-05 13:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix display problems after resume (rev2) Patchwork
2022-10-05 13:32 ` Matthew Auld [this message]
2022-10-05 13:32   ` [Intel-gfx] [PATCH RESEND] drm/i915: Fix display problems after resume Matthew Auld
2022-10-05 13:32   ` Matthew Auld
2022-10-05 14:31   ` [Intel-gfx] " Thomas Hellström
2022-10-06  0:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix display problems after resume (rev2) Patchwork
2022-10-10  7:44 ` [Intel-gfx] [PATCH RESEND] drm/i915: Fix display problems after resume Andrzej Hajda
2022-10-10  7:44   ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9722ab4-31fe-3f2e-a1e6-5df5d1bef623@intel.com \
    --to=matthew.auld@intel.com \
    --cc=davidesousa@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kevinboulain@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.