From: Thomas Zimmermann <tzimmermann@suse.de> To: Daniel Vetter <daniel@ffwll.ch> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Intel Graphics Development" <intel-gfx@lists.freedesktop.org>, "DRI Development" <dri-devel@lists.freedesktop.org>, "Daniel Vetter" <daniel.vetter@intel.com>, "Christian König" <christian.koenig@amd.com> Subject: Re: [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86 Date: Thu, 5 Aug 2021 20:40:07 +0200 [thread overview] Message-ID: <ea741e89-6ed0-fe7d-6462-7ca01b14c4b9@suse.de> (raw) In-Reply-To: <YPpxh0QhILXESykX@phenom.ffwll.local> [-- Attachment #1.1: Type: text/plain, Size: 1818 bytes --] Hi Am 23.07.21 um 09:36 schrieb Daniel Vetter: > > The real fix is to get at the architecture-specific wc allocator, which is > currently not something that's exposed, but hidden within the dma api. I > think having this stick out like this is better than hiding it behind fake > generic code (like we do with drm_clflush, which defacto also only really > works on x86). > > Also note that ttm has the exact same ifdef in its page allocator, but it > does fall back to using dma_alloc_coherent on other platforms. If this fixes a real problem and there's no full solution yet, let's take what we have. So if you can extract the essence of this comment into a TODO comment that tells how to fix the issue, fell free to add my Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards Thomas > -Daniel > >> Best regard >> Thomas >> >>> + >>> shmem->pages = pages; >>> return 0; >>> @@ -203,6 +212,11 @@ static void drm_gem_shmem_put_pages_locked(struct drm_gem_shmem_object *shmem) >>> if (--shmem->pages_use_count > 0) >>> return; >>> +#ifdef CONFIG_X86 >>> + if (shmem->map_wc) >>> + set_pages_array_wb(shmem->pages, obj->size >> PAGE_SHIFT); >>> +#endif >>> + >>> drm_gem_put_pages(obj, shmem->pages, >>> shmem->pages_mark_dirty_on_put, >>> shmem->pages_mark_accessed_on_put); >>> >> >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Maxfeldstr. 5, 90409 Nürnberg, Germany >> (HRB 36809, AG Nürnberg) >> Geschäftsführer: Felix Imendörffer >> > > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: Daniel Vetter <daniel@ffwll.ch> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Intel Graphics Development" <intel-gfx@lists.freedesktop.org>, "DRI Development" <dri-devel@lists.freedesktop.org>, "Daniel Vetter" <daniel.vetter@intel.com>, "Christian König" <christian.koenig@amd.com> Subject: Re: [Intel-gfx] [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86 Date: Thu, 5 Aug 2021 20:40:07 +0200 [thread overview] Message-ID: <ea741e89-6ed0-fe7d-6462-7ca01b14c4b9@suse.de> (raw) In-Reply-To: <YPpxh0QhILXESykX@phenom.ffwll.local> [-- Attachment #1.1: Type: text/plain, Size: 1818 bytes --] Hi Am 23.07.21 um 09:36 schrieb Daniel Vetter: > > The real fix is to get at the architecture-specific wc allocator, which is > currently not something that's exposed, but hidden within the dma api. I > think having this stick out like this is better than hiding it behind fake > generic code (like we do with drm_clflush, which defacto also only really > works on x86). > > Also note that ttm has the exact same ifdef in its page allocator, but it > does fall back to using dma_alloc_coherent on other platforms. If this fixes a real problem and there's no full solution yet, let's take what we have. So if you can extract the essence of this comment into a TODO comment that tells how to fix the issue, fell free to add my Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards Thomas > -Daniel > >> Best regard >> Thomas >> >>> + >>> shmem->pages = pages; >>> return 0; >>> @@ -203,6 +212,11 @@ static void drm_gem_shmem_put_pages_locked(struct drm_gem_shmem_object *shmem) >>> if (--shmem->pages_use_count > 0) >>> return; >>> +#ifdef CONFIG_X86 >>> + if (shmem->map_wc) >>> + set_pages_array_wb(shmem->pages, obj->size >> PAGE_SHIFT); >>> +#endif >>> + >>> drm_gem_put_pages(obj, shmem->pages, >>> shmem->pages_mark_dirty_on_put, >>> shmem->pages_mark_accessed_on_put); >>> >> >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Maxfeldstr. 5, 90409 Nürnberg, Germany >> (HRB 36809, AG Nürnberg) >> Geschäftsführer: Felix Imendörffer >> > > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-08-05 18:40 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-13 20:51 [PATCH v4 0/4] shmem helpers for vgem Daniel Vetter 2021-07-13 20:51 ` [Intel-gfx] " Daniel Vetter 2021-07-13 20:51 ` [PATCH v4 1/4] dma-buf: Require VM_PFNMAP vma for mmap Daniel Vetter 2021-07-13 20:51 ` [Intel-gfx] " Daniel Vetter 2021-07-13 20:51 ` Daniel Vetter 2021-07-23 18:45 ` Thomas Zimmermann 2021-07-23 18:45 ` [Intel-gfx] " Thomas Zimmermann 2021-07-23 18:45 ` Thomas Zimmermann 2021-07-13 20:51 ` [PATCH v4 2/4] drm/shmem-helper: Switch to vmf_insert_pfn Daniel Vetter 2021-07-13 20:51 ` [Intel-gfx] " Daniel Vetter 2021-07-22 18:22 ` Thomas Zimmermann 2021-07-22 18:22 ` [Intel-gfx] " Thomas Zimmermann 2021-07-23 7:32 ` Daniel Vetter 2021-07-23 7:32 ` [Intel-gfx] " Daniel Vetter 2021-08-12 13:05 ` Daniel Vetter 2021-08-12 13:05 ` [Intel-gfx] " Daniel Vetter 2021-07-13 20:51 ` [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86 Daniel Vetter 2021-07-13 20:51 ` [Intel-gfx] " Daniel Vetter 2021-07-14 11:54 ` Christian König 2021-07-14 11:54 ` [Intel-gfx] " Christian König 2021-07-14 12:48 ` Daniel Vetter 2021-07-14 12:48 ` [Intel-gfx] " Daniel Vetter 2021-07-14 12:58 ` Christian König 2021-07-14 12:58 ` [Intel-gfx] " Christian König 2021-07-14 16:16 ` Daniel Vetter 2021-07-14 16:16 ` [Intel-gfx] " Daniel Vetter 2021-07-22 18:40 ` Thomas Zimmermann 2021-07-22 18:40 ` [Intel-gfx] " Thomas Zimmermann 2021-07-23 7:36 ` Daniel Vetter 2021-07-23 7:36 ` [Intel-gfx] " Daniel Vetter 2021-07-23 8:02 ` Christian König 2021-07-23 8:02 ` [Intel-gfx] " Christian König 2021-07-23 8:34 ` Daniel Vetter 2021-07-23 8:34 ` [Intel-gfx] " Daniel Vetter 2021-08-05 18:40 ` Thomas Zimmermann [this message] 2021-08-05 18:40 ` Thomas Zimmermann 2021-07-13 20:51 ` [PATCH v4 4/4] drm/vgem: use shmem helpers Daniel Vetter 2021-07-13 20:51 ` [Intel-gfx] " Daniel Vetter 2021-07-14 12:45 ` [PATCH] " Daniel Vetter 2021-07-14 12:45 ` [Intel-gfx] " Daniel Vetter 2021-07-22 18:50 ` [PATCH v4 4/4] " Thomas Zimmermann 2021-07-22 18:50 ` [Intel-gfx] " Thomas Zimmermann 2021-07-23 7:38 ` Daniel Vetter 2021-07-23 7:38 ` [Intel-gfx] " Daniel Vetter 2021-07-13 23:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for shmem helpers for vgem (rev6) Patchwork 2021-07-14 0:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2021-07-16 13:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for shmem helpers for vgem (rev8) Patchwork 2021-07-16 13:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-16 16:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ea741e89-6ed0-fe7d-6462-7ca01b14c4b9@suse.de \ --to=tzimmermann@suse.de \ --cc=airlied@linux.ie \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.