From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zhouyang Jia <jiazhouyang09@gmail.com>,
Kees Cook <keescook@chromium.org>
Cc: industrypack-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()
Date: Thu, 07 May 2020 16:34:06 +0200 [thread overview]
Message-ID: <eaaa54dbe413bf3f13f08c267e6c31c497afb509.camel@igalia.com> (raw)
In-Reply-To: <20200507094237.13599-1-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
Hello Wei,
Thanks for the patch!
Patch is,
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Greg, Would you mind picking this patch series through your char-misc
tree?
Thanks!
Sam
On Thu, 2020-05-07 at 09:42 +0000, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the ioremap() error
> handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/ipack/carriers/tpci200.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ipack/carriers/tpci200.c
> b/drivers/ipack/carriers/tpci200.c
> index 8a9c169..b5eec18 100644
> --- a/drivers/ipack/carriers/tpci200.c
> +++ b/drivers/ipack/carriers/tpci200.c
> @@ -309,6 +309,7 @@ static int tpci200_register(struct tpci200_board
> *tpci200)
> "(bn 0x%X, sn 0x%X) failed to map driver user
> space!",
> tpci200->info->pdev->bus->number,
> tpci200->info->pdev->devfn);
> + res = -ENOMEM;
> goto out_release_mem8_space;
> }
>
>
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zhouyang Jia <jiazhouyang09@gmail.com>,
Kees Cook <keescook@chromium.org>
Cc: industrypack-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()
Date: Thu, 07 May 2020 14:34:06 +0000 [thread overview]
Message-ID: <eaaa54dbe413bf3f13f08c267e6c31c497afb509.camel@igalia.com> (raw)
In-Reply-To: <20200507094237.13599-1-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
Hello Wei,
Thanks for the patch!
Patch is,
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Greg, Would you mind picking this patch series through your char-misc
tree?
Thanks!
Sam
On Thu, 2020-05-07 at 09:42 +0000, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the ioremap() error
> handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/ipack/carriers/tpci200.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ipack/carriers/tpci200.c
> b/drivers/ipack/carriers/tpci200.c
> index 8a9c169..b5eec18 100644
> --- a/drivers/ipack/carriers/tpci200.c
> +++ b/drivers/ipack/carriers/tpci200.c
> @@ -309,6 +309,7 @@ static int tpci200_register(struct tpci200_board
> *tpci200)
> "(bn 0x%X, sn 0x%X) failed to map driver user
> space!",
> tpci200->info->pdev->bus->number,
> tpci200->info->pdev->devfn);
> + res = -ENOMEM;
> goto out_release_mem8_space;
> }
>
>
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-07 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 9:42 [PATCH -next] ipack: tpci200: fix error return code in tpci200_register() Wei Yongjun
2020-05-07 9:42 ` Wei Yongjun
2020-05-07 14:34 ` Samuel Iglesias Gonsálvez [this message]
2020-05-07 14:34 ` Samuel Iglesias Gonsálvez
2020-05-15 14:23 ` Greg Kroah-Hartman
2020-05-15 14:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaaa54dbe413bf3f13f08c267e6c31c497afb509.camel@igalia.com \
--to=siglesias@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=jiazhouyang09@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.