From: Tyler Hicks <code@tyhicks.com>
To: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Robertson <daniel.robertson@starlab.io>
Subject: Re: [PATCH] ecryptfs: Fix inodes not being evicted until unmount
Date: Sat, 30 Jan 2021 11:06:40 -0600 [thread overview]
Message-ID: <20210130170640.GA58096@elm> (raw)
In-Reply-To: <20201218190730.141761-1-jeffrey.mitchell@starlab.io>
On 2020-12-18 13:07:30, Jeffrey Mitchell wrote:
> On asynchronous base filesystems like NFS, eCryptFS leaves inodes for
> deleted files in the cache until unmounting. Change call in
> ecryptfs_do_unlink() from set_nlink() to drop_nlink() in order to reliably
> evict inodes from the cache even on top of NFS.
>
> Signed-off-by: Dan Robertson <daniel.robertson@starlab.io>
> Signed-off-by: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
Hey Jeffrey and Dan - thanks for the patch! Unfortunately, I think this
would allow the eCryptfs inode's nlink count to get out of sync with the
lower inode's nlink count in the case of direct manipulation to the
lower filesystem.
Is the condition that you're trying to fix a result of going through the
this code path?
ecryptfs_unlink() -> ecryptfs_do_unlink() -> vfs_unlink() -> nfs_unlink() -> nfs_sillyrename() -> nfs_async_unlink()
Tyler
> ---
> fs/ecryptfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index e23752d..f7594b6 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -147,7 +147,7 @@ static int ecryptfs_do_unlink(struct inode *dir, struct dentry *dentry,
> goto out_unlock;
> }
> fsstack_copy_attr_times(dir, lower_dir_inode);
> - set_nlink(inode, ecryptfs_inode_to_lower(inode)->i_nlink);
> + drop_nlink(inode);
> inode->i_ctime = dir->i_ctime;
> out_unlock:
> dput(lower_dentry);
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-01-30 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 19:07 [PATCH] ecryptfs: Fix inodes not being evicted until unmount Jeffrey Mitchell
2020-12-18 19:10 ` Jeffrey Mitchell
2021-01-30 17:06 ` Tyler Hicks [this message]
2021-02-02 15:22 ` Jeffrey Mitchell
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 14:31 Jeffrey Mitchell
2020-05-08 14:32 ` Jeffrey Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130170640.GA58096@elm \
--to=code@tyhicks.com \
--cc=daniel.robertson@starlab.io \
--cc=ecryptfs@vger.kernel.org \
--cc=jeffrey.mitchell@starlab.io \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).