From: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
To: Tyler Hicks <code@tyhicks.com>
Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Robertson <daniel.robertson@starlab.io>
Subject: Re: [PATCH] ecryptfs: Fix inodes not being evicted until unmount
Date: Tue, 2 Feb 2021 09:22:55 -0600 [thread overview]
Message-ID: <20210202152255.GA3383@jeffrey-work-20.04> (raw)
In-Reply-To: <20210130170640.GA58096@elm>
On Sat, Jan 30, 2021 at 11:06:40AM -0600, Tyler Hicks wrote:
> Hey Jeffrey and Dan - thanks for the patch! Unfortunately, I think this
> would allow the eCryptfs inode's nlink count to get out of sync with the
> lower inode's nlink count in the case of direct manipulation to the
> lower filesystem.
Hmm. What if I instead synchronize it before calling vfs_unlink(), then
call drop_nlink() if vfs_unlink() succeeds?
> Is the condition that you're trying to fix a result of going through the
> this code path?
>
> ecryptfs_unlink() -> ecryptfs_do_unlink() -> vfs_unlink() -> nfs_unlink() -> nfs_sillyrename() -> nfs_async_unlink()
Yes, that is the code path that causes it.
V/R,
Jeffrey Mitchell
next prev parent reply other threads:[~2021-02-02 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 19:07 [PATCH] ecryptfs: Fix inodes not being evicted until unmount Jeffrey Mitchell
2020-12-18 19:10 ` Jeffrey Mitchell
2021-01-30 17:06 ` Tyler Hicks
2021-02-02 15:22 ` Jeffrey Mitchell [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 14:31 Jeffrey Mitchell
2020-05-08 14:32 ` Jeffrey Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202152255.GA3383@jeffrey-work-20.04 \
--to=jeffrey.mitchell@starlab.io \
--cc=code@tyhicks.com \
--cc=daniel.robertson@starlab.io \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).