Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver

From: Devi Priya <quic_devipriy@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <agross@kernel.org>, <konrad.dybcio@linaro.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<linus.walleij@linaro.org>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <p.zabel@pengutronix.de>,
	<shawnguo@kernel.org>, <arnd@arndb.de>,
	<marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
	<nfraprado@collabora.com>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
	<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
	<quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
	<quic_poovendh@quicinc.com>
Subject: Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver
Date: Mon, 13 Feb 2023 19:48:54 +0530	[thread overview]
Message-ID: <ed3637e4-7a5a-55be-be49-cdb0ec978752@quicinc.com> (raw)
In-Reply-To: <20230208231412.yqp3rvokvmbb7ixi@ripper>

Thanks Bjorn for taking time to review the patch

On 2/9/2023 4:44 AM, Bjorn Andersson wrote:
> On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote:
>> +static const struct msm_pingroup ipq9574_groups[] = {
>> +	PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _),
>> +	PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _),
>> +	PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
>> +	PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
>> +	PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _),
>> +	PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _,
>> +		 _),
> 
> Please avoid line wrapping these, it just makes it hard to read.
Yes, we have addressed this comment part of V7 series
https://lore.kernel.org/linux-arm-kernel/20230206103337.21000-5-quic_devipriy@quicinc.com/
> 
> [..]
>> +};
>> +
>> +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */
> 
> This seems like a property of the board, please use gpio-reserved-ranges
> in the DT node instead.
As the GPIO is forbidden on SoC IPQ9574,
we have moved it to the pinctrl driver based on the suggestions received
in V1 series
https://lore.kernel.org/linux-arm-kernel/675ed9f7-da31-6206-5089-1db22025ef4b@linaro.org/
> 
> Thanks,
> Bjorn
Best Regards,
Devi Priya