From: Can Guo <cang@codeaurora.org> To: Stanley Chu <stanley.chu@mediatek.com> Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com, chaotian.jing@mediatek.com, cc.chou@mediatek.com, jiajie.hao@mediatek.com, alice.chao@mediatek.com Subject: Re: [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling Date: Fri, 18 Dec 2020 14:30:08 +0800 [thread overview] Message-ID: <ee0f3ffc6d86098fc5704c1726fc69f3@codeaurora.org> (raw) In-Reply-To: <1608272678.10163.40.camel@mtkswgap22> On 2020-12-18 14:24, Stanley Chu wrote: > Hi Can, > > On Fri, 2020-12-18 at 14:20 +0800, Can Guo wrote: >> On 2020-12-16 21:16, Stanley Chu wrote: >> > Hi, >> > This series cleans up and refactors clk-scaling feature, and shall not >> > change any functionality. >> > >> > This series is based on Can's series "Three changes related with UFS >> > clock scaling" in 5.10/scsi-fixes branch in Martin's tree. >> > >> >> Hi Stanley, >> >> Thanks for noticing my changes, will you review them? >> I see customers manipulte UFS scaling related sysfs >> nodes more often than before, so we may want to fix it asap. > > I have gave my review tag in all patches in this series : ) > > Thanks, > Stanley Chu > Hi Stanley, oops, just saw it - I opened the wrong series. I will push a new version which incorporates your comments soon. Since the new changes would only be some words in ufshcd.h, so you won't need to rebase. Thanks, Can Guo. >> >> Regards, >> >> Can Guo. >> >> > However this series may not be required to be merged to 5.10. The >> > choice of base branch is simply making these patches easy to be >> > reviewed because this series is based on clk-scaling fixes by Can. If >> > this series is decided not being merged to 5.10, then I would rebase >> > it to 5.11/scsi-queue. >> > >> > Changes since v1: >> > - Refactor ufshcd_clk_scaling_suspend() in patch [3/4] >> > - Change function name from ufshcd_clk_scaling_pm() to >> > ufshcd_clk_scaling_suspend() in patch [3/4] >> > - Refine patch titles >> > >> > Stanley Chu (4): >> > scsi: ufs: Refactor cancelling clkscaling works >> > scsi: ufs: Remove redundant null checking of devfreq instance >> > scsi: ufs: Cleanup and refactor clk-scaling feature >> > scsi: ufs: Fix build warning by incorrect function description >> > >> > drivers/scsi/ufs/ufshcd.c | 90 +++++++++++++++++++-------------------- >> > 1 file changed, 43 insertions(+), 47 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Can Guo <cang@codeaurora.org> To: Stanley Chu <stanley.chu@mediatek.com> Cc: jiajie.hao@mediatek.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, andy.teng@mediatek.com, jejb@linux.ibm.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, cc.chou@mediatek.com, avri.altman@wdc.com, alice.chao@mediatek.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, asutoshd@codeaurora.org, chaotian.jing@mediatek.com, bvanassche@acm.org, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Subject: Re: [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling Date: Fri, 18 Dec 2020 14:30:08 +0800 [thread overview] Message-ID: <ee0f3ffc6d86098fc5704c1726fc69f3@codeaurora.org> (raw) In-Reply-To: <1608272678.10163.40.camel@mtkswgap22> On 2020-12-18 14:24, Stanley Chu wrote: > Hi Can, > > On Fri, 2020-12-18 at 14:20 +0800, Can Guo wrote: >> On 2020-12-16 21:16, Stanley Chu wrote: >> > Hi, >> > This series cleans up and refactors clk-scaling feature, and shall not >> > change any functionality. >> > >> > This series is based on Can's series "Three changes related with UFS >> > clock scaling" in 5.10/scsi-fixes branch in Martin's tree. >> > >> >> Hi Stanley, >> >> Thanks for noticing my changes, will you review them? >> I see customers manipulte UFS scaling related sysfs >> nodes more often than before, so we may want to fix it asap. > > I have gave my review tag in all patches in this series : ) > > Thanks, > Stanley Chu > Hi Stanley, oops, just saw it - I opened the wrong series. I will push a new version which incorporates your comments soon. Since the new changes would only be some words in ufshcd.h, so you won't need to rebase. Thanks, Can Guo. >> >> Regards, >> >> Can Guo. >> >> > However this series may not be required to be merged to 5.10. The >> > choice of base branch is simply making these patches easy to be >> > reviewed because this series is based on clk-scaling fixes by Can. If >> > this series is decided not being merged to 5.10, then I would rebase >> > it to 5.11/scsi-queue. >> > >> > Changes since v1: >> > - Refactor ufshcd_clk_scaling_suspend() in patch [3/4] >> > - Change function name from ufshcd_clk_scaling_pm() to >> > ufshcd_clk_scaling_suspend() in patch [3/4] >> > - Refine patch titles >> > >> > Stanley Chu (4): >> > scsi: ufs: Refactor cancelling clkscaling works >> > scsi: ufs: Remove redundant null checking of devfreq instance >> > scsi: ufs: Cleanup and refactor clk-scaling feature >> > scsi: ufs: Fix build warning by incorrect function description >> > >> > drivers/scsi/ufs/ufshcd.c | 90 +++++++++++++++++++-------------------- >> > 1 file changed, 43 insertions(+), 47 deletions(-) _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-12-18 6:31 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-16 13:16 [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-16 13:16 ` [PATCH v2 1/4] scsi: ufs: Refactor cancelling clkscaling works Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-18 6:08 ` Can Guo 2020-12-18 6:08 ` Can Guo 2020-12-16 13:16 ` [PATCH v2 2/4] scsi: ufs: Remove redundant null checking of devfreq instance Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-18 5:58 ` Can Guo 2020-12-18 5:58 ` Can Guo 2020-12-18 6:09 ` Can Guo 2020-12-18 6:09 ` Can Guo 2020-12-16 13:16 ` [PATCH v2 3/4] scsi: ufs: Cleanup and refactor clk-scaling feature Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-18 6:16 ` Can Guo 2020-12-18 6:16 ` Can Guo 2020-12-16 13:16 ` [PATCH v2 4/4] scsi: ufs: Fix build warning by incorrect function description Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-16 13:16 ` Stanley Chu 2020-12-18 6:16 ` Can Guo 2020-12-18 6:16 ` Can Guo 2020-12-18 6:20 ` [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling Can Guo 2020-12-18 6:20 ` Can Guo 2020-12-18 6:24 ` Stanley Chu 2020-12-18 6:24 ` Stanley Chu 2020-12-18 6:24 ` Stanley Chu 2020-12-18 6:30 ` Can Guo [this message] 2020-12-18 6:30 ` Can Guo 2021-01-06 2:47 ` Martin K. Petersen 2021-01-06 2:47 ` Martin K. Petersen 2021-01-06 2:47 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ee0f3ffc6d86098fc5704c1726fc69f3@codeaurora.org \ --to=cang@codeaurora.org \ --cc=alice.chao@mediatek.com \ --cc=alim.akhtar@samsung.com \ --cc=andy.teng@mediatek.com \ --cc=asutoshd@codeaurora.org \ --cc=avri.altman@wdc.com \ --cc=beanhuo@micron.com \ --cc=bvanassche@acm.org \ --cc=cc.chou@mediatek.com \ --cc=chaotian.jing@mediatek.com \ --cc=chun-hung.wu@mediatek.com \ --cc=jejb@linux.ibm.com \ --cc=jiajie.hao@mediatek.com \ --cc=kuohong.wang@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=matthias.bgg@gmail.com \ --cc=peter.wang@mediatek.com \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.