From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv3 08/14] dt-bindings: mfd: add rk806 binding
Date: Sat, 10 Sep 2022 10:03:15 +0200 [thread overview]
Message-ID: <ee4cdfb1-8edd-a0de-5068-85de88e16c3d@linaro.org> (raw)
In-Reply-To: <20220909175522.179175-9-sebastian.reichel@collabora.com>
On 09/09/2022 19:55, Sebastian Reichel wrote:
> Add DT binding document for Rockchip's RK806 PMIC.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> + vcc11-supply:
> + description:
> + The input supply for pldo-reg1, pldo-reg2 and pldo-reg3.
> +
> + vcc12-supply:
> + description:
> + The input supply for pldo-reg4 and pldo-reg5.
> +
> + vcc13-supply:
> + description:
> + The input supply for nldo-reg1, nldo-reg2 and nldo-reg3.
> +
> + vcc14-supply:
> + description:
> + The input supply for nldo-reg4 and nldo-reg5.
> +
> + vcca-supply:
> + description:
> + The input supply for pldo-reg6.
> +
> + regulators:
> + type: object
> + patternProperties:
> + "^(dcdc-reg([1-9]|10)|pldo-reg[1-6]|nldo-reg[1-5])$":
> + type: object
> + $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
Sorry, for not spotting it earlier but the indentation here looks wrong.
On "patternProperties" indentation you need additionalProperties: false,
because only the patterns are allowed.
On "$ref: ....." level of indentation, you need unevaluatedProperties:
false, because you allow only properties previously evaluated (evaluated
by regulator.yaml).
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv3 08/14] dt-bindings: mfd: add rk806 binding
Date: Sat, 10 Sep 2022 10:03:15 +0200 [thread overview]
Message-ID: <ee4cdfb1-8edd-a0de-5068-85de88e16c3d@linaro.org> (raw)
In-Reply-To: <20220909175522.179175-9-sebastian.reichel@collabora.com>
On 09/09/2022 19:55, Sebastian Reichel wrote:
> Add DT binding document for Rockchip's RK806 PMIC.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> + vcc11-supply:
> + description:
> + The input supply for pldo-reg1, pldo-reg2 and pldo-reg3.
> +
> + vcc12-supply:
> + description:
> + The input supply for pldo-reg4 and pldo-reg5.
> +
> + vcc13-supply:
> + description:
> + The input supply for nldo-reg1, nldo-reg2 and nldo-reg3.
> +
> + vcc14-supply:
> + description:
> + The input supply for nldo-reg4 and nldo-reg5.
> +
> + vcca-supply:
> + description:
> + The input supply for pldo-reg6.
> +
> + regulators:
> + type: object
> + patternProperties:
> + "^(dcdc-reg([1-9]|10)|pldo-reg[1-6]|nldo-reg[1-5])$":
> + type: object
> + $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
Sorry, for not spotting it earlier but the indentation here looks wrong.
On "patternProperties" indentation you need additionalProperties: false,
because only the patterns are allowed.
On "$ref: ....." level of indentation, you need unevaluatedProperties:
false, because you allow only properties previously evaluated (evaluated
by regulator.yaml).
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-09-10 8:03 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 17:55 [PATCHv3 00/14] Introduce RK806 Support Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 01/14] mfd: rk808: convert to device managed resources Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-28 13:38 ` Lee Jones
2022-09-28 13:38 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 02/14] mfd: rk808: use dev_err_probe Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-28 13:51 ` Lee Jones
2022-09-28 13:51 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 03/14] clk: RK808: reduce 'struct rk808' usage Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 04/14] regulator: rk808: " Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 05/14] rtc: " Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 06/14] mfd: rk808: replace 'struct i2c_client' with 'struct device' Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-28 14:00 ` Lee Jones
2022-09-28 14:00 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 07/14] mfd: rk808: split into core and i2c Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-28 14:13 ` Lee Jones
2022-09-28 14:13 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 08/14] dt-bindings: mfd: add rk806 binding Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-10 8:03 ` Krzysztof Kozlowski [this message]
2022-09-10 8:03 ` Krzysztof Kozlowski
2022-09-09 17:55 ` [PATCHv3 09/14] mfd: rk8xx: add rk806 support Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-28 14:35 ` Lee Jones
2022-09-28 14:35 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 10/14] pinctrl: rk805: add rk806 pinctrl support Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 11/14] regulator: rk808: Use dev_err_probe Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 12/14] regulator: expose regmap_find_closest_bigger Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-10 17:17 ` Matti Vaittinen
2022-09-10 17:17 ` Matti Vaittinen
2022-09-19 14:15 ` Sebastian Reichel
2022-09-19 14:15 ` Sebastian Reichel
2022-09-28 17:37 ` Mark Brown
2022-09-28 17:37 ` Mark Brown
2022-09-09 17:55 ` [PATCHv3 13/14] regulator: rk808: add rk806 support Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-09-10 17:03 ` Matti Vaittinen
2022-09-10 17:03 ` Matti Vaittinen
2022-09-09 17:55 ` [PATCHv3 14/14] ASoC: rk817: Remove 'select REGMAP_I2C' Sebastian Reichel
2022-09-09 17:55 ` Sebastian Reichel
2022-11-28 19:05 ` (subset) [PATCHv3 00/14] Introduce RK806 Support Mark Brown
2022-11-28 19:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4cdfb1-8edd-a0de-5068-85de88e16c3d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.