From: Dmitry Osipenko <digetx@gmail.com>
To: Mikko Perttunen <cyndis@kapsi.fi>,
Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset
Date: Mon, 21 Feb 2022 23:10:37 +0300 [thread overview]
Message-ID: <ee648994-b296-2ac4-a676-ddcac463a428@gmail.com> (raw)
In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi>
21.02.2022 14:44, Mikko Perttunen пишет:
> On 2/19/22 20:54, Dmitry Osipenko wrote:
>> 19.02.2022 21:49, Dmitry Osipenko пишет:
>>> 18.02.2022 14:39, Mikko Perttunen пишет:
>>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client)
>>>> +{
>>>> + struct vic *vic = to_vic(client);
>>>> + int err;
>>>> +
>>>> + err = vic_load_firmware(vic);
>>>
>>> You can't invoke vic_load_firmware() while RPM is suspended. Either
>>> replace this with RPM get/put or do something else.
>
> Why not, I'm not seeing any HW accesses in vic_load_firmware? Although
> it looks like it might race with the vic_load_firmware call in
> vic_runtime_resume which probably needs to be fixed.
It was not clear from the function's name that h/w is untouched, I read
"load" as "upload" and then looked at vic_runtime_resume(). I'd rename
vic_load_firmware() to vic_prepare_firmware_image().
And yes, technically lock is needed.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Mikko Perttunen <cyndis@kapsi.fi>,
Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset
Date: Mon, 21 Feb 2022 23:10:37 +0300 [thread overview]
Message-ID: <ee648994-b296-2ac4-a676-ddcac463a428@gmail.com> (raw)
In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi>
21.02.2022 14:44, Mikko Perttunen пишет:
> On 2/19/22 20:54, Dmitry Osipenko wrote:
>> 19.02.2022 21:49, Dmitry Osipenko пишет:
>>> 18.02.2022 14:39, Mikko Perttunen пишет:
>>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client)
>>>> +{
>>>> + struct vic *vic = to_vic(client);
>>>> + int err;
>>>> +
>>>> + err = vic_load_firmware(vic);
>>>
>>> You can't invoke vic_load_firmware() while RPM is suspended. Either
>>> replace this with RPM get/put or do something else.
>
> Why not, I'm not seeing any HW accesses in vic_load_firmware? Although
> it looks like it might race with the vic_load_firmware call in
> vic_runtime_resume which probably needs to be fixed.
It was not clear from the function's name that h/w is untouched, I read
"load" as "upload" and then looked at vic_runtime_resume(). I'd rename
vic_load_firmware() to vic_prepare_firmware_image().
And yes, technically lock is needed.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Mikko Perttunen <cyndis@kapsi.fi>,
Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset
Date: Mon, 21 Feb 2022 23:10:37 +0300 [thread overview]
Message-ID: <ee648994-b296-2ac4-a676-ddcac463a428@gmail.com> (raw)
In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi>
21.02.2022 14:44, Mikko Perttunen пишет:
> On 2/19/22 20:54, Dmitry Osipenko wrote:
>> 19.02.2022 21:49, Dmitry Osipenko пишет:
>>> 18.02.2022 14:39, Mikko Perttunen пишет:
>>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client)
>>>> +{
>>>> + struct vic *vic = to_vic(client);
>>>> + int err;
>>>> +
>>>> + err = vic_load_firmware(vic);
>>>
>>> You can't invoke vic_load_firmware() while RPM is suspended. Either
>>> replace this with RPM get/put or do something else.
>
> Why not, I'm not seeing any HW accesses in vic_load_firmware? Although
> it looks like it might race with the vic_load_firmware call in
> vic_runtime_resume which probably needs to be fixed.
It was not clear from the function's name that h/w is untouched, I read
"load" as "upload" and then looked at vic_runtime_resume(). I'd rename
vic_load_firmware() to vic_prepare_firmware_image().
And yes, technically lock is needed.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Mikko Perttunen <cyndis@kapsi.fi>,
Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org,
will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset
Date: Mon, 21 Feb 2022 23:10:37 +0300 [thread overview]
Message-ID: <ee648994-b296-2ac4-a676-ddcac463a428@gmail.com> (raw)
In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi>
21.02.2022 14:44, Mikko Perttunen пишет:
> On 2/19/22 20:54, Dmitry Osipenko wrote:
>> 19.02.2022 21:49, Dmitry Osipenko пишет:
>>> 18.02.2022 14:39, Mikko Perttunen пишет:
>>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client)
>>>> +{
>>>> + struct vic *vic = to_vic(client);
>>>> + int err;
>>>> +
>>>> + err = vic_load_firmware(vic);
>>>
>>> You can't invoke vic_load_firmware() while RPM is suspended. Either
>>> replace this with RPM get/put or do something else.
>
> Why not, I'm not seeing any HW accesses in vic_load_firmware? Although
> it looks like it might race with the vic_load_firmware call in
> vic_runtime_resume which probably needs to be fixed.
It was not clear from the function's name that h/w is untouched, I read
"load" as "upload" and then looked at vic_runtime_resume(). I'd rename
vic_load_firmware() to vic_prepare_firmware_image().
And yes, technically lock is needed.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-21 20:10 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 11:39 [PATCH v3 0/9] Host1x context isolation support Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 1/9] dt-bindings: host1x: Add memory-contexts property Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-21 15:23 ` Robin Murphy
2022-02-21 15:23 ` Robin Murphy
2022-02-21 15:23 ` Robin Murphy
2022-02-21 15:28 ` Mikko Perttunen
2022-02-21 15:28 ` Mikko Perttunen
2022-02-21 15:28 ` Mikko Perttunen
2022-02-21 16:58 ` Robin Murphy
2022-02-21 16:58 ` Robin Murphy
2022-02-21 16:58 ` Robin Murphy
2022-02-21 17:12 ` Mikko Perttunen
2022-02-21 17:12 ` Mikko Perttunen
2022-02-21 17:12 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 2/9] gpu: host1x: Add context bus Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-19 17:54 ` Dmitry Osipenko
2022-02-19 17:54 ` Dmitry Osipenko
2022-02-19 17:54 ` Dmitry Osipenko
2022-02-19 17:54 ` Dmitry Osipenko
2022-02-19 18:15 ` Dmitry Osipenko
2022-02-19 18:15 ` Dmitry Osipenko
2022-02-19 18:15 ` Dmitry Osipenko
2022-02-19 18:15 ` Dmitry Osipenko
2022-02-22 16:21 ` Christoph Hellwig
2022-02-22 16:21 ` Christoph Hellwig
2022-02-22 16:21 ` Christoph Hellwig
2022-02-22 21:30 ` Robin Murphy
2022-02-22 21:30 ` Robin Murphy
2022-02-22 21:30 ` Robin Murphy
2022-02-22 21:30 ` Robin Murphy
2022-02-23 6:36 ` Christoph Hellwig
2022-02-23 6:36 ` Christoph Hellwig
2022-02-23 6:36 ` Christoph Hellwig
2022-02-18 11:39 ` [PATCH v3 3/9] gpu: host1x: Add context device management code Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-19 17:48 ` Dmitry Osipenko
2022-02-19 17:48 ` Dmitry Osipenko
2022-02-19 17:48 ` Dmitry Osipenko
2022-02-19 17:48 ` Dmitry Osipenko
2022-02-21 11:35 ` Mikko Perttunen
2022-02-21 11:35 ` Mikko Perttunen
2022-02-21 11:35 ` Mikko Perttunen
2022-02-21 11:35 ` Mikko Perttunen
2022-02-19 17:52 ` Dmitry Osipenko
2022-02-19 17:52 ` Dmitry Osipenko
2022-02-19 17:52 ` Dmitry Osipenko
2022-02-19 17:52 ` Dmitry Osipenko
2022-02-21 11:37 ` Mikko Perttunen
2022-02-21 11:37 ` Mikko Perttunen
2022-02-21 11:37 ` Mikko Perttunen
2022-02-21 11:37 ` Mikko Perttunen
2022-02-22 16:24 ` Christoph Hellwig
2022-02-22 16:24 ` Christoph Hellwig
2022-02-22 16:24 ` Christoph Hellwig
2022-02-23 9:44 ` Mikko Perttunen
2022-02-23 9:44 ` Mikko Perttunen
2022-02-23 9:44 ` Mikko Perttunen
2022-02-23 9:44 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 4/9] gpu: host1x: Program context stream ID on submission Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 5/9] iommu/arm-smmu: Attach to host1x context device bus Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 6/9] arm64: tegra: Add Host1x context stream IDs on Tegra186+ Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 7/9] drm/tegra: falcon: Set DMACTX field on DMA transactions Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-19 18:49 ` Dmitry Osipenko
2022-02-19 18:49 ` Dmitry Osipenko
2022-02-19 18:49 ` Dmitry Osipenko
2022-02-19 18:49 ` Dmitry Osipenko
2022-02-19 18:54 ` Dmitry Osipenko
2022-02-19 18:54 ` Dmitry Osipenko
2022-02-19 18:54 ` Dmitry Osipenko
2022-02-19 18:54 ` Dmitry Osipenko
2022-02-21 11:44 ` Mikko Perttunen
2022-02-21 11:44 ` Mikko Perttunen
2022-02-21 11:44 ` Mikko Perttunen
2022-02-21 11:44 ` Mikko Perttunen
2022-02-21 20:10 ` Dmitry Osipenko [this message]
2022-02-21 20:10 ` Dmitry Osipenko
2022-02-21 20:10 ` Dmitry Osipenko
2022-02-21 20:10 ` Dmitry Osipenko
2022-02-22 8:27 ` Mikko Perttunen
2022-02-22 8:27 ` Mikko Perttunen
2022-02-22 8:27 ` Mikko Perttunen
2022-02-22 8:27 ` Mikko Perttunen
2022-02-22 10:46 ` Dmitry Osipenko
2022-02-22 10:46 ` Dmitry Osipenko
2022-02-22 10:46 ` Dmitry Osipenko
2022-02-22 10:46 ` Dmitry Osipenko
2022-02-22 10:54 ` Mikko Perttunen
2022-02-22 10:54 ` Mikko Perttunen
2022-02-22 10:54 ` Mikko Perttunen
2022-02-22 10:54 ` Mikko Perttunen
2022-02-22 11:02 ` Dmitry Osipenko
2022-02-22 11:02 ` Dmitry Osipenko
2022-02-22 11:02 ` Dmitry Osipenko
2022-02-22 11:02 ` Dmitry Osipenko
2022-02-21 17:27 ` Robin Murphy
2022-02-21 17:27 ` Robin Murphy
2022-02-21 17:27 ` Robin Murphy
2022-02-21 17:36 ` Mikko Perttunen
2022-02-21 17:36 ` Mikko Perttunen
2022-02-21 17:36 ` Mikko Perttunen
2022-02-18 11:39 ` [PATCH v3 9/9] drm/tegra: Support context isolation Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen
2022-02-18 11:39 ` Mikko Perttunen via iommu
2022-02-18 11:39 ` Mikko Perttunen
2022-02-19 18:35 ` Dmitry Osipenko
2022-02-19 18:35 ` Dmitry Osipenko
2022-02-19 18:35 ` Dmitry Osipenko
2022-02-19 18:35 ` Dmitry Osipenko
2022-02-21 12:06 ` Mikko Perttunen
2022-02-21 12:06 ` Mikko Perttunen
2022-02-21 12:06 ` Mikko Perttunen
2022-02-21 12:06 ` Mikko Perttunen
2022-02-21 20:02 ` Dmitry Osipenko
2022-02-21 20:02 ` Dmitry Osipenko
2022-02-21 20:02 ` Dmitry Osipenko
2022-02-21 20:02 ` Dmitry Osipenko
2022-02-22 8:37 ` Mikko Perttunen
2022-02-22 8:37 ` Mikko Perttunen
2022-02-22 8:37 ` Mikko Perttunen
2022-02-22 8:37 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee648994-b296-2ac4-a676-ddcac463a428@gmail.com \
--to=digetx@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.