All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Thomas Gleixner <tglx@linutronix.de>, Keerthy <j-keerthy@ti.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()
Date: Sat, 20 Mar 2021 23:13:08 +0100	[thread overview]
Message-ID: <ee7cb91f-5fc1-d852-f109-db3c189e45a1@linaro.org> (raw)
In-Reply-To: <YEZCFgFEKTaxJTpG@atomide.com>

On 08/03/2021 16:26, Tony Lindgren wrote:
> Hi,
> 
> * Tony Lindgren <tony@atomide.com> [210305 07:58]:
>> * Grygorii Strashko <grygorii.strashko@ti.com> [210304 20:56]:
>>>
>>>
>>> On 04/03/2021 09:21, Tony Lindgren wrote:
>>>> We have of_translate_address() already do of_node_put() as needed.
>>>> I probably looked at __of_translate_address() earlier by accident
>>>> that of_translate_address() uses.
>>>
>>> I do not see of_node_put() in of_translate_address() and
>>>  __of_translate_address() is doing of_node_get(dev);
>>> ?
>>
>> Oh right.. this is confusing.. Yeah we can ignore this patch.
>> We should have the use count set for only the system timer(s)
>> we claim.
> 
> Daniel, would you like me to repost this series with this patch dropped?

No, it is ok. I will take care of not picking it.

Thanks
  -- Daniel



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Thomas Gleixner <tglx@linutronix.de>, Keerthy <j-keerthy@ti.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()
Date: Sat, 20 Mar 2021 23:13:08 +0100	[thread overview]
Message-ID: <ee7cb91f-5fc1-d852-f109-db3c189e45a1@linaro.org> (raw)
In-Reply-To: <YEZCFgFEKTaxJTpG@atomide.com>

On 08/03/2021 16:26, Tony Lindgren wrote:
> Hi,
> 
> * Tony Lindgren <tony@atomide.com> [210305 07:58]:
>> * Grygorii Strashko <grygorii.strashko@ti.com> [210304 20:56]:
>>>
>>>
>>> On 04/03/2021 09:21, Tony Lindgren wrote:
>>>> We have of_translate_address() already do of_node_put() as needed.
>>>> I probably looked at __of_translate_address() earlier by accident
>>>> that of_translate_address() uses.
>>>
>>> I do not see of_node_put() in of_translate_address() and
>>>  __of_translate_address() is doing of_node_get(dev);
>>> ?
>>
>> Oh right.. this is confusing.. Yeah we can ignore this patch.
>> We should have the use count set for only the system timer(s)
>> we claim.
> 
> Daniel, would you like me to repost this series with this patch dropped?

No, it is ok. I will take care of not picking it.

Thanks
  -- Daniel



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-20 22:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  7:21 [PATCH 0/3] Fixes for timer-ti-dm systimer posted mode Tony Lindgren
2021-03-04  7:21 ` Tony Lindgren
2021-03-04  7:21 ` [PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order Tony Lindgren
2021-03-04  7:21   ` Tony Lindgren
2021-03-04 20:57   ` Grygorii Strashko
2021-03-04 20:57     ` Grygorii Strashko
2021-03-05  7:53     ` Tony Lindgren
2021-03-05  7:53       ` Tony Lindgren
2021-03-05 10:09       ` Grygorii Strashko
2021-03-05 10:09         ` Grygorii Strashko
2021-04-09 10:27   ` [tip: timers/core] " tip-bot2 for Tony Lindgren
2021-03-04  7:21 ` [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put() Tony Lindgren
2021-03-04  7:21   ` Tony Lindgren
2021-03-04 20:55   ` Grygorii Strashko
2021-03-04 20:55     ` Grygorii Strashko
2021-03-05  7:49     ` Tony Lindgren
2021-03-05  7:49       ` Tony Lindgren
2021-03-08 15:26       ` Tony Lindgren
2021-03-08 15:26         ` Tony Lindgren
2021-03-20 22:13         ` Daniel Lezcano [this message]
2021-03-20 22:13           ` Daniel Lezcano
2021-03-04  7:21 ` [PATCH 3/3] clocksource/drivers/timer-ti-dm: Add missing set_state_oneshot_stopped Tony Lindgren
2021-03-04  7:21   ` Tony Lindgren
2021-04-09 10:27   ` [tip: timers/core] " tip-bot2 for Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee7cb91f-5fc1-d852-f109-db3c189e45a1@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.