From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Sultan Alsawaf <sultan@kerneltoast.com>
Cc: aaron.ma@canonical.com, admin@kryma.net,
andriy.shevchenko@linux.intel.com, benjamin.tissoires@redhat.com,
hdegoede@redhat.com, hn.chen@weidahitech.com, jikos@kernel.org,
kai.heng.feng@canonical.com, linux-i2c@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com, vicamo.yang@canonical.com,
wsa@kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power
Date: Wed, 1 Jul 2020 11:04:01 +0300 [thread overview]
Message-ID: <ef949533-c614-7afb-f206-5c54d827deac@linux.intel.com> (raw)
In-Reply-To: <20200629174328.GB1646@sultan-box.localdomain>
On 6/29/20 8:43 PM, Sultan Alsawaf wrote:
> Hmm, for some reason in 5.8 I get the same problem, but 5.7 is fine. Could you
> try this on 5.7 and see if it works?
>
> In the meantime I'll bisect 5.8 to see why it's causing problems for me...
>
I see the same issue on top of v5.7:
[ 9.330514] i2c_hid i2c-ELAN221D:00: Fetching the HID descriptor
[ 9.334761] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: cmd=01 00
[ 9.335716] i2c_hid i2c-ELAN221D:00: HID Descriptor: 1e 00 00 01 31
02 02 00 03 00 43 00 04 00 ff 00 05 00 06 00 f3 04 1d 22 10 56 00 00 00 00
[ 9.353408] i2c_hid i2c-ELAN221D:00: entering i2c_hid_parse
[ 9.353416] i2c_hid i2c-ELAN221D:00: i2c_hid_hwreset
[ 9.353502] i2c_hid i2c-ELAN221D:00: i2c_hid_set_power
[ 9.353520] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: cmd=05 00 00 08
[ 9.362304] i2c_hid i2c-ELAN221D:00: resetting...
[ 9.370585] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: cmd=05 00 00 01
[ 9.389175] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: waiting...
[ 10.416458] i2c_designware i2c_designware.3: controller timed out
[ 10.476853] i2c_designware i2c_designware.3: timeout in disabling adapter
[ 11.983806] [<00000000fac753ed>] i2c_dw_isr [i2c_designware_core]
[ 14.544499] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: finished.
[ 14.552123] i2c_hid i2c-ELAN221D:00: failed to reset device.
[ 14.559263] i2c_hid i2c-ELAN221D:00: i2c_hid_set_power
[ 14.565822] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: cmd=05 00 01 08
[ 14.600256] i2c_designware i2c_designware.3: timeout waiting for bus
ready
[ 14.608800] i2c_hid i2c-ELAN221D:00: failed to change power setting.
[ 15.632103] i2c_hid i2c-ELAN221D:00: i2c_hid_hwreset
[ 15.638460] i2c_hid i2c-ELAN221D:00: i2c_hid_set_power
[ 15.646422] i2c_hid i2c-ELAN221D:00: __i2c_hid_command: cmd=05 00 00 08
...
--
Jarkko
next prev parent reply other threads:[~2020-07-01 8:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 21:02 [PATCH 0/2] i2c-hid: Save power by reducing i2c xfers with block reads Sultan Alsawaf
2020-06-14 21:02 ` [PATCH 1/2] i2c: designware: Only check the first byte for SMBus block read length Sultan Alsawaf
2020-06-15 9:40 ` Andy Shevchenko
2020-06-15 16:03 ` Sultan Alsawaf
2020-06-15 16:07 ` Andy Shevchenko
2020-06-15 17:15 ` Sultan Alsawaf
2020-06-16 13:22 ` Jarkko Nikula
2020-06-16 15:43 ` [PATCH v2] " Sultan Alsawaf
2020-06-17 11:08 ` Jarkko Nikula
2020-06-14 21:02 ` [PATCH 2/2] HID: i2c-hid: Use block reads when possible to save power Sultan Alsawaf
2020-06-16 13:43 ` Jarkko Nikula
2020-06-16 15:49 ` [PATCH v2] " Sultan Alsawaf
2020-06-16 16:41 ` Andy Shevchenko
2020-06-16 17:18 ` Andi Shyti
2020-06-16 17:32 ` Sultan Alsawaf
2020-06-16 18:02 ` Andi Shyti
2020-06-16 18:17 ` Sultan Alsawaf
2020-06-17 11:17 ` Jarkko Nikula
2020-06-29 17:43 ` Sultan Alsawaf
2020-07-01 8:04 ` Jarkko Nikula [this message]
2020-07-01 15:00 ` Sultan Alsawaf
2020-07-03 11:18 ` Jarkko Nikula
2020-09-14 0:15 ` [PATCH v3] i2c: Squash of SMBus block read patchset " Sultan Alsawaf
[not found] ` <bcf9cd02-13d1-8f87-8ef9-2f05f0b54808@linux.intel.com>
2020-09-15 17:48 ` Sultan Alsawaf
2020-09-16 14:09 ` Jarkko Nikula
2020-09-15 20:44 ` Jiri Kosina
2020-06-22 0:58 ` [HID] 0b987151f0: kmsg.i2c_designware_i2c_designware.#: controller_timed_out kernel test robot
2020-06-22 0:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef949533-c614-7afb-f206-5c54d827deac@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=aaron.ma@canonical.com \
--cc=admin@kryma.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hn.chen@weidahitech.com \
--cc=jikos@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sultan@kerneltoast.com \
--cc=vicamo.yang@canonical.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.