[PATCH] acd: remove 'No target or source conflict' print

[PATCH] acd: remove 'No target or source conflict' print

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

This is quite common and expected with ACD, and printing it serves
no useful purpose. The kind of debugging that is important is when
a conflict is detected.
---
 ell/acd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/ell/acd.c b/ell/acd.c
index 4216898..3c8e7fe 100644
--- a/ell/acd.c
+++ b/ell/acd.c
@@ -281,11 +281,8 @@ static bool acd_read_handler(struct l_io *io, void *user_data)
 	target_conflict = probe &&
 		!memcmp(arp.arp_tpa, &acd->ip, sizeof(uint32_t));
 
-	if (!source_conflict && !target_conflict) {
-		ACD_DEBUG("No target or source conflict detected for "NIPQUAD_FMT,
-				NIPQUAD(acd->ip));
+	if (!source_conflict && !target_conflict)
 		return true;
-	}
 
 	switch (acd->state) {
 	case ACD_STATE_PROBE:
-- 
2.31.1

Re: [PATCH] acd: remove 'No target or source conflict' print

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi James,

On 1/31/22 11:49, James Prestwood wrote:
> This is quite common and expected with ACD, and printing it serves
> no useful purpose. The kind of debugging that is important is when
> a conflict is detected.
> ---
>   ell/acd.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 

Applied, thanks.

Regards,
-Denis