Re: [PATCH] dhcp: CLIENT_ENTER_STATE should log as INFO

Re: [PATCH] dhcp: CLIENT_ENTER_STATE should log as INFO

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi Michael,

On 5/18/22 11:58, Michael Johnson wrote:
> This was missed in the d5377c6. Now the state will only log when INFO or
> above is enabled.
> ---
>   ell/dhcp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 

Applied with a slight rewording of the commit description.

Regards,
-Denis

[PATCH] dhcp: CLIENT_ENTER_STATE should log as INFO

[Michael Johnson]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

This was missed in the d5377c6. Now the state will only log when INFO or
above is enabled.
---
 ell/dhcp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ell/dhcp.c b/ell/dhcp.c
index 8ff5594..4e66faa 100644
--- a/ell/dhcp.c
+++ b/ell/dhcp.c
@@ -56,9 +56,7 @@
 #define CLIENT_WARN(fmt, args...)					\
 	CLIENT_LOG(L_LOG_WARNING, fmt, ## args)
 #define CLIENT_ENTER_STATE(s)						\
-	l_util_debug(client->debug_handler, client->debug_data,		\
-			"%s:%i Entering state: " #s,			\
-			__func__, __LINE__);				\
+	CLIENT_INFO("Entering state: " #s);				\
 	client->state = (s)
 
 #define BITS_PER_LONG (sizeof(unsigned long) * 8)
-- 
2.25.1