From: Kever Yang <kever.yang@rock-chips.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 5/9] fastboot: rockchip: Select FASTBOOT_FLASH[_MMC_DEV]
Date: Wed, 23 Oct 2019 15:46:54 +0800 [thread overview]
Message-ID: <f093a722-b297-3917-2826-3ddb243e57f4@rock-chips.com> (raw)
In-Reply-To: <20191022175458.22604-6-jagan@amarulasolutions.com>
Jagan,
On 2019/10/23 上午1:54, Jagan Teki wrote:
> Select CONFIG_FASTBOOT_FLASH, CONFIG_FASTBOOT_FLASH_MMC_DEV
> for rockchip SoC plaforms in fastboot Kconfig file instead
> of defined it in board defconfig.
>
> This eventually drop the explicit configs defined in
> supporting board defconfig files.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> configs/evb-rk3036_defconfig | 2 --
> configs/evb-rk3128_defconfig | 2 --
> configs/evb-rk3229_defconfig | 2 --
> configs/evb-rk3288_defconfig | 2 --
> configs/evb-rk3328_defconfig | 2 --
> configs/firefly-rk3288_defconfig | 2 --
> configs/kylin-rk3036_defconfig | 2 --
> configs/miqi-rk3288_defconfig | 2 --
> configs/phycore-rk3288_defconfig | 2 --
> configs/popmetal-rk3288_defconfig | 2 --
> configs/rock64-rk3328_defconfig | 2 --
> configs/tinker-rk3288_defconfig | 2 --
> drivers/fastboot/Kconfig | 4 +++-
> 13 files changed, 3 insertions(+), 25 deletions(-)
>
> diff --git a/configs/evb-rk3036_defconfig b/configs/evb-rk3036_defconfig
> index c02ef6af4e..ca2ba9d0d8 100644
> --- a/configs/evb-rk3036_defconfig
> +++ b/configs/evb-rk3036_defconfig
> @@ -36,8 +36,6 @@ CONFIG_REGMAP=y
> CONFIG_SYSCON=y
> # CONFIG_SPL_BLK is not set
> CONFIG_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3128_defconfig b/configs/evb-rk3128_defconfig
> index a3189638a1..9d81d96e68 100644
> --- a/configs/evb-rk3128_defconfig
> +++ b/configs/evb-rk3128_defconfig
> @@ -22,8 +22,6 @@ CONFIG_SYSCON=y
> CONFIG_CLK=y
> CONFIG_FASTBOOT_BUF_ADDR=0x60800800
> CONFIG_FASTBOOT_BUF_SIZE=0x04000000
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3229_defconfig b/configs/evb-rk3229_defconfig
> index e7b813d627..a365931e47 100644
> --- a/configs/evb-rk3229_defconfig
> +++ b/configs/evb-rk3229_defconfig
> @@ -44,8 +44,6 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_TPL_CLK=y
> CONFIG_FASTBOOT_BUF_SIZE=0x04000000
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig
> index a6c57dfaa6..a88f391b96 100644
> --- a/configs/evb-rk3288_defconfig
> +++ b/configs/evb-rk3288_defconfig
> @@ -44,8 +44,6 @@ CONFIG_SYSCON=y
> CONFIG_SPL_SYSCON=y
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
> index c9d056b4b9..d133477e62 100644
> --- a/configs/evb-rk3328_defconfig
> +++ b/configs/evb-rk3328_defconfig
> @@ -48,8 +48,6 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_TPL_CLK=y
> CONFIG_FASTBOOT_BUF_ADDR=0x800800
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=1
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
> index 2de166ae90..4bd81048e9 100644
> --- a/configs/firefly-rk3288_defconfig
> +++ b/configs/firefly-rk3288_defconfig
> @@ -46,8 +46,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/kylin-rk3036_defconfig b/configs/kylin-rk3036_defconfig
> index ff20dea0fc..79188c16b7 100644
> --- a/configs/kylin-rk3036_defconfig
> +++ b/configs/kylin-rk3036_defconfig
> @@ -38,8 +38,6 @@ CONFIG_REGMAP=y
> CONFIG_SYSCON=y
> # CONFIG_SPL_BLK is not set
> CONFIG_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
> index fbafbb857a..1b55008a96 100644
> --- a/configs/miqi-rk3288_defconfig
> +++ b/configs/miqi-rk3288_defconfig
> @@ -46,8 +46,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/phycore-rk3288_defconfig b/configs/phycore-rk3288_defconfig
> index 70e3bdc621..f44974b191 100644
> --- a/configs/phycore-rk3288_defconfig
> +++ b/configs/phycore-rk3288_defconfig
> @@ -48,8 +48,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig
> index 611aff5e1d..af70684045 100644
> --- a/configs/popmetal-rk3288_defconfig
> +++ b/configs/popmetal-rk3288_defconfig
> @@ -46,8 +46,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig
> index 5e64003dd3..fc9079eb4e 100644
> --- a/configs/rock64-rk3328_defconfig
> +++ b/configs/rock64-rk3328_defconfig
> @@ -51,8 +51,6 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_TPL_CLK=y
> CONFIG_FASTBOOT_BUF_ADDR=0x800800
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=1
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
> index 467065e3ad..a624270aff 100644
> --- a/configs/tinker-rk3288_defconfig
> +++ b/configs/tinker-rk3288_defconfig
> @@ -48,8 +48,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
> index d63ecdd27e..34864ca613 100644
> --- a/drivers/fastboot/Kconfig
> +++ b/drivers/fastboot/Kconfig
> @@ -64,7 +64,7 @@ config FASTBOOT_USB_DEV
>
> config FASTBOOT_FLASH
> bool "Enable FASTBOOT FLASH command"
> - default y if ARCH_SUNXI
> + default y if ARCH_SUNXI || ARCH_ROCKCHIP
> depends on MMC || (NAND && CMD_MTDPARTS)
> select IMAGE_SPARSE
> help
> @@ -89,6 +89,8 @@ endchoice
> config FASTBOOT_FLASH_MMC_DEV
> int "Define FASTBOOT MMC FLASH default device"
> depends on FASTBOOT_FLASH_MMC
> + default 1 if ROCKCHIP_RK3328
We can use '0' for rk3328 and remove this line.
When we using fastboot, we suppose to access to eMMC, but not SDCard,
and the eMMC number is always '0' on Rockchip platform.
Thanks,
- Kever
> + default 0 if ARCH_ROCKCHIP
> default 0 if ARCH_SUNXI && MMC_SUNXI_SLOT_EXTRA = -1
> default 1 if ARCH_SUNXI && MMC_SUNXI_SLOT_EXTRA != -1
> help
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] fastboot: rockchip: Select FASTBOOT_FLASH[_MMC_DEV]
Date: Wed, 23 Oct 2019 15:46:54 +0800 [thread overview]
Message-ID: <f093a722-b297-3917-2826-3ddb243e57f4@rock-chips.com> (raw)
In-Reply-To: <20191022175458.22604-6-jagan@amarulasolutions.com>
Jagan,
On 2019/10/23 上午1:54, Jagan Teki wrote:
> Select CONFIG_FASTBOOT_FLASH, CONFIG_FASTBOOT_FLASH_MMC_DEV
> for rockchip SoC plaforms in fastboot Kconfig file instead
> of defined it in board defconfig.
>
> This eventually drop the explicit configs defined in
> supporting board defconfig files.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> configs/evb-rk3036_defconfig | 2 --
> configs/evb-rk3128_defconfig | 2 --
> configs/evb-rk3229_defconfig | 2 --
> configs/evb-rk3288_defconfig | 2 --
> configs/evb-rk3328_defconfig | 2 --
> configs/firefly-rk3288_defconfig | 2 --
> configs/kylin-rk3036_defconfig | 2 --
> configs/miqi-rk3288_defconfig | 2 --
> configs/phycore-rk3288_defconfig | 2 --
> configs/popmetal-rk3288_defconfig | 2 --
> configs/rock64-rk3328_defconfig | 2 --
> configs/tinker-rk3288_defconfig | 2 --
> drivers/fastboot/Kconfig | 4 +++-
> 13 files changed, 3 insertions(+), 25 deletions(-)
>
> diff --git a/configs/evb-rk3036_defconfig b/configs/evb-rk3036_defconfig
> index c02ef6af4e..ca2ba9d0d8 100644
> --- a/configs/evb-rk3036_defconfig
> +++ b/configs/evb-rk3036_defconfig
> @@ -36,8 +36,6 @@ CONFIG_REGMAP=y
> CONFIG_SYSCON=y
> # CONFIG_SPL_BLK is not set
> CONFIG_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3128_defconfig b/configs/evb-rk3128_defconfig
> index a3189638a1..9d81d96e68 100644
> --- a/configs/evb-rk3128_defconfig
> +++ b/configs/evb-rk3128_defconfig
> @@ -22,8 +22,6 @@ CONFIG_SYSCON=y
> CONFIG_CLK=y
> CONFIG_FASTBOOT_BUF_ADDR=0x60800800
> CONFIG_FASTBOOT_BUF_SIZE=0x04000000
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3229_defconfig b/configs/evb-rk3229_defconfig
> index e7b813d627..a365931e47 100644
> --- a/configs/evb-rk3229_defconfig
> +++ b/configs/evb-rk3229_defconfig
> @@ -44,8 +44,6 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_TPL_CLK=y
> CONFIG_FASTBOOT_BUF_SIZE=0x04000000
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig
> index a6c57dfaa6..a88f391b96 100644
> --- a/configs/evb-rk3288_defconfig
> +++ b/configs/evb-rk3288_defconfig
> @@ -44,8 +44,6 @@ CONFIG_SYSCON=y
> CONFIG_SPL_SYSCON=y
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
> index c9d056b4b9..d133477e62 100644
> --- a/configs/evb-rk3328_defconfig
> +++ b/configs/evb-rk3328_defconfig
> @@ -48,8 +48,6 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_TPL_CLK=y
> CONFIG_FASTBOOT_BUF_ADDR=0x800800
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=1
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
> index 2de166ae90..4bd81048e9 100644
> --- a/configs/firefly-rk3288_defconfig
> +++ b/configs/firefly-rk3288_defconfig
> @@ -46,8 +46,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/kylin-rk3036_defconfig b/configs/kylin-rk3036_defconfig
> index ff20dea0fc..79188c16b7 100644
> --- a/configs/kylin-rk3036_defconfig
> +++ b/configs/kylin-rk3036_defconfig
> @@ -38,8 +38,6 @@ CONFIG_REGMAP=y
> CONFIG_SYSCON=y
> # CONFIG_SPL_BLK is not set
> CONFIG_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
> index fbafbb857a..1b55008a96 100644
> --- a/configs/miqi-rk3288_defconfig
> +++ b/configs/miqi-rk3288_defconfig
> @@ -46,8 +46,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/phycore-rk3288_defconfig b/configs/phycore-rk3288_defconfig
> index 70e3bdc621..f44974b191 100644
> --- a/configs/phycore-rk3288_defconfig
> +++ b/configs/phycore-rk3288_defconfig
> @@ -48,8 +48,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig
> index 611aff5e1d..af70684045 100644
> --- a/configs/popmetal-rk3288_defconfig
> +++ b/configs/popmetal-rk3288_defconfig
> @@ -46,8 +46,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig
> index 5e64003dd3..fc9079eb4e 100644
> --- a/configs/rock64-rk3328_defconfig
> +++ b/configs/rock64-rk3328_defconfig
> @@ -51,8 +51,6 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_TPL_CLK=y
> CONFIG_FASTBOOT_BUF_ADDR=0x800800
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=1
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
> index 467065e3ad..a624270aff 100644
> --- a/configs/tinker-rk3288_defconfig
> +++ b/configs/tinker-rk3288_defconfig
> @@ -48,8 +48,6 @@ CONFIG_SPL_SYSCON=y
> # CONFIG_SPL_SIMPLE_BUS is not set
> CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_FLASH=y
> -CONFIG_FASTBOOT_FLASH_MMC_DEV=0
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
> index d63ecdd27e..34864ca613 100644
> --- a/drivers/fastboot/Kconfig
> +++ b/drivers/fastboot/Kconfig
> @@ -64,7 +64,7 @@ config FASTBOOT_USB_DEV
>
> config FASTBOOT_FLASH
> bool "Enable FASTBOOT FLASH command"
> - default y if ARCH_SUNXI
> + default y if ARCH_SUNXI || ARCH_ROCKCHIP
> depends on MMC || (NAND && CMD_MTDPARTS)
> select IMAGE_SPARSE
> help
> @@ -89,6 +89,8 @@ endchoice
> config FASTBOOT_FLASH_MMC_DEV
> int "Define FASTBOOT MMC FLASH default device"
> depends on FASTBOOT_FLASH_MMC
> + default 1 if ROCKCHIP_RK3328
We can use '0' for rk3328 and remove this line.
When we using fastboot, we suppose to access to eMMC, but not SDCard,
and the eMMC number is always '0' on Rockchip platform.
Thanks,
- Kever
> + default 0 if ARCH_ROCKCHIP
> default 0 if ARCH_SUNXI && MMC_SUNXI_SLOT_EXTRA = -1
> default 1 if ARCH_SUNXI && MMC_SUNXI_SLOT_EXTRA != -1
> help
next prev parent reply other threads:[~2019-10-23 7:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 17:54 [PATCH 0/9] rockchip: rk3399: Add fastboot support Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
[not found] ` <20191022175458.22604-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-10-22 17:54 ` [PATCH 1/9] gadget: Select USB_GADGET_MANUFACTURER for rockchip Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 2/9] gadget: Select USB_GADGET_VENDOR_NUM " Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 3/9] gadget: rockchip: USB_GADGET_PRODUCT_NUM Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 4/9] gadget: rockchip: Add rk3128 USB_GADGET_PRODUCT_NUM Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 5/9] fastboot: rockchip: Select FASTBOOT_FLASH[_MMC_DEV] Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-23 7:46 ` Kever Yang [this message]
2019-10-23 7:46 ` Kever Yang
2019-10-23 7:50 ` Jagan Teki
2019-10-23 7:50 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 6/9] usb: dwc3: Add phy interface for dwc3_uboot Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 7/9] gadget: rockchip: Add rk3399 USB_GADGET_PRODUCT_NUM Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-29 9:40 ` djw
2019-10-29 9:40 ` [U-Boot] " djw at t-chip.com.cn
[not found] ` <87y2x3ga9q.fsf-sOhrXWSnOqapXNIQCVAXCG0Lkn3mC4nZ0tOlhedn3YvkypF1WZHjJXhe7Zk3YmMvjmZSf7Nhrd8@public.gmane.org>
2019-11-18 13:44 ` Jagan Teki
2019-11-18 13:44 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [PATCH 8/9] rockchip: Setup dwc3_device (for non-dm gadgets) Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-22 17:54 ` [DO NOT MERGE] [PATCH 9/9] rockchip: rk3399: Enable fastboot Jagan Teki
2019-10-22 17:54 ` [U-Boot] " Jagan Teki
2019-10-29 9:43 ` [PATCH 0/9] rockchip: rk3399: Add fastboot support djw
2019-10-29 9:43 ` [U-Boot] " djw at t-chip.com.cn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f093a722-b297-3917-2826-3ddb243e57f4@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.