From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "Andrew Davis" <afd@ti.com>, "Frank Binns" <frank.binns@imgtec.com>, "Matt Coster" <matt.coster@imgtec.com>, "H . Nikolaus Schaller" <hns@goldelico.com>, "Adam Ford" <aford173@gmail.com>, "Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Maxime Ripard" <mripard@kernel.org>, "Thomas Zimmermann" <tzimmermann@suse.de>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, "Chen-Yu Tsai" <wens@csie.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, "Samuel Holland" <samuel@sholland.org>, "Benoît Cousson" <bcousson@baylibre.com>, "Tony Lindgren" <tony@atomide.com>, "Nishanth Menon" <nm@ti.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Tero Kristo" <kristo@kernel.org>, "Paul Cercueil" <paul@crapouillou.net> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-omap@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Date: Tue, 9 Jan 2024 20:52:28 +0100 [thread overview] Message-ID: <f1710a31-6729-4a97-afcb-518cb99b9346@linaro.org> (raw) In-Reply-To: <61b0c6c7-e5ad-4cbf-a020-230d96d43d3e@ti.com> On 09/01/2024 20:33, Andrew Davis wrote: > On 1/9/24 1:17 PM, Krzysztof Kozlowski wrote: >> On 09/01/2024 20:04, Andrew Davis wrote: >>> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote: >>>> On 09/01/2024 18:19, Andrew Davis wrote: >>>>> This binding will be used for GPUs starting from Series6 (Rogue) >>>>> and later. A different binding document will describe Series5. >>>>> With that the name "img,powervr" is too generic, rename to >>>>> "img,powervr-rogue" to avoid confusion. >>>>> >>>>> Suggested-by: Maxime Ripard <mripard@kernel.org> >>>>> Signed-off-by: Andrew Davis <afd@ti.com> >>>>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >>>>> Reviewed-by: Frank Binns <frank.binns@imgtec.com> >>>>> --- >>>> >>>> Why do you send new version while we still talk about previous? >>>> >>>> Please implement feedback from v1 (and this is v2, so next is v3) or >>>> keep discussing. >>>> >>> >>> I agreed with everything you said in the last round (RFC v2) and >>> made all requested changes. Did I miss something in this version? >> >> The recommendation is that naming of the file matches generic compatible >> and your file has only one generic compatible. Therefore I don't >> understand why you claimed there are multiple compatibles. >> > > I said "There are (or will be) multiple compatible strings", the rest OK. > are on the way. So I didn't want to make this file less generic when > other bindings are almost ready. > > Frank, can you help here, I'm assuming you have "img,img-bxs" and > "img,img-8xe" bindings staged for upstreaming somewhere; you'll be > putting those in this same file, right? > That's fine then. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "Andrew Davis" <afd@ti.com>, "Frank Binns" <frank.binns@imgtec.com>, "Matt Coster" <matt.coster@imgtec.com>, "H . Nikolaus Schaller" <hns@goldelico.com>, "Adam Ford" <aford173@gmail.com>, "Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Maxime Ripard" <mripard@kernel.org>, "Thomas Zimmermann" <tzimmermann@suse.de>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, "Chen-Yu Tsai" <wens@csie.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, "Samuel Holland" <samuel@sholland.org>, "Benoît Cousson" <bcousson@baylibre.com>, "Tony Lindgren" <tony@atomide.com>, "Nishanth Menon" <nm@ti.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Tero Kristo" <kristo@kernel.org>, "Paul Cercueil" <paul@crapouillou.net> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-omap@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Date: Tue, 9 Jan 2024 20:52:28 +0100 [thread overview] Message-ID: <f1710a31-6729-4a97-afcb-518cb99b9346@linaro.org> (raw) In-Reply-To: <61b0c6c7-e5ad-4cbf-a020-230d96d43d3e@ti.com> On 09/01/2024 20:33, Andrew Davis wrote: > On 1/9/24 1:17 PM, Krzysztof Kozlowski wrote: >> On 09/01/2024 20:04, Andrew Davis wrote: >>> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote: >>>> On 09/01/2024 18:19, Andrew Davis wrote: >>>>> This binding will be used for GPUs starting from Series6 (Rogue) >>>>> and later. A different binding document will describe Series5. >>>>> With that the name "img,powervr" is too generic, rename to >>>>> "img,powervr-rogue" to avoid confusion. >>>>> >>>>> Suggested-by: Maxime Ripard <mripard@kernel.org> >>>>> Signed-off-by: Andrew Davis <afd@ti.com> >>>>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >>>>> Reviewed-by: Frank Binns <frank.binns@imgtec.com> >>>>> --- >>>> >>>> Why do you send new version while we still talk about previous? >>>> >>>> Please implement feedback from v1 (and this is v2, so next is v3) or >>>> keep discussing. >>>> >>> >>> I agreed with everything you said in the last round (RFC v2) and >>> made all requested changes. Did I miss something in this version? >> >> The recommendation is that naming of the file matches generic compatible >> and your file has only one generic compatible. Therefore I don't >> understand why you claimed there are multiple compatibles. >> > > I said "There are (or will be) multiple compatible strings", the rest OK. > are on the way. So I didn't want to make this file less generic when > other bindings are almost ready. > > Frank, can you help here, I'm assuming you have "img,img-bxs" and > "img,img-8xe" bindings staged for upstreaming somewhere; you'll be > putting those in this same file, right? > That's fine then. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-09 19:52 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-09 17:19 [PATCH 00/11] Device tree support for Imagination Series5 GPU Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue Andrew Davis 2024-01-09 17:19 ` [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 18:59 ` Krzysztof Kozlowski 2024-01-09 18:59 ` Krzysztof Kozlowski 2024-01-09 18:59 ` Krzysztof Kozlowski 2024-01-09 19:04 ` Andrew Davis 2024-01-09 19:04 ` Andrew Davis 2024-01-09 19:04 ` Andrew Davis 2024-01-09 19:17 ` Krzysztof Kozlowski 2024-01-09 19:17 ` Krzysztof Kozlowski 2024-01-09 19:17 ` Krzysztof Kozlowski 2024-01-09 19:33 ` Andrew Davis 2024-01-09 19:33 ` Andrew Davis 2024-01-09 19:33 ` Andrew Davis 2024-01-09 19:52 ` Krzysztof Kozlowski [this message] 2024-01-09 19:52 ` Krzysztof Kozlowski 2024-01-09 19:52 ` Krzysztof Kozlowski 2024-01-09 19:52 ` Krzysztof Kozlowski 2024-01-09 19:52 ` Krzysztof Kozlowski 2024-01-09 17:19 ` [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 19:53 ` Krzysztof Kozlowski 2024-01-09 19:53 ` Krzysztof Kozlowski 2024-01-09 19:53 ` Krzysztof Kozlowski 2024-01-10 8:38 ` Tony Lindgren 2024-01-10 8:38 ` Tony Lindgren 2024-01-10 8:38 ` Tony Lindgren 2024-01-19 17:48 ` Rob Herring 2024-01-19 17:48 ` Rob Herring 2024-01-19 17:48 ` Rob Herring 2024-01-26 8:31 ` Tony Lindgren 2024-01-26 8:31 ` Tony Lindgren 2024-01-26 8:31 ` Tony Lindgren 2024-01-09 17:19 ` [PATCH 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 04/11] ARM: dts: omap4: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 05/11] ARM: dts: omap5: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 06/11] ARM: dts: AM33xx: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 07/11] ARM: dts: AM437x: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 08/11] ARM: dts: DRA7xx: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-10 8:29 ` Tony Lindgren 2024-01-10 8:29 ` Tony Lindgren 2024-01-10 8:29 ` Tony Lindgren 2024-01-17 15:52 ` Andrew Davis 2024-01-17 15:52 ` Andrew Davis 2024-01-17 15:52 ` Andrew Davis 2024-01-18 8:55 ` Tony Lindgren 2024-01-18 8:55 ` Tony Lindgren 2024-01-18 8:55 ` Tony Lindgren 2024-01-26 7:45 ` Tony Lindgren 2024-01-26 7:45 ` Tony Lindgren 2024-01-26 7:45 ` Tony Lindgren 2024-01-09 17:19 ` [PATCH 09/11] arm64: dts: ti: k3-am654-main: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 10/11] ARM: dts: sun6i: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` [PATCH 11/11] MIPS: DTS: jz4780: " Andrew Davis 2024-01-09 17:19 ` Andrew Davis 2024-01-09 17:19 ` Andrew Davis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f1710a31-6729-4a97-afcb-518cb99b9346@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=afd@ti.com \ --cc=aford173@gmail.com \ --cc=bcousson@baylibre.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=frank.binns@imgtec.com \ --cc=hns@goldelico.com \ --cc=ivo.g.dimitrov.75@gmail.com \ --cc=jernej.skrabec@gmail.com \ --cc=kristo@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=maarten.lankhorst@linux.intel.com \ --cc=matt.coster@imgtec.com \ --cc=mripard@kernel.org \ --cc=nm@ti.com \ --cc=paul@crapouillou.net \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=tony@atomide.com \ --cc=tzimmermann@suse.de \ --cc=vigneshr@ti.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.