Re: [PATCH v6 1/2] dt-bindings: serial: Add rx-tx-swap to stm32-usart

From: Martin DEVERA <devik@eaxlabs.cz>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Le Ray <erwan.leray@st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	fabrice.gasnier@foss.st.com,
	linux-arm-kernel@lists.infradead.org,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: serial: Add rx-tx-swap to stm32-usart
Date: Fri, 12 Mar 2021 16:03:27 +0100	[thread overview]
Message-ID: <f1762dc1-d359-e499-ace7-f957bca519b8@eaxlabs.cz> (raw)
In-Reply-To: <e1cee5c4-8802-bf6b-be06-e453af559e62@eaxlabs.cz>

On 3/12/21 3:56 PM, Martin DEVERA wrote:
> On 3/12/21 3:23 PM, Rob Herring wrote:
>> On Fri, 12 Mar 2021 11:27:12 +0100, Martin Devera wrote:
>>> Add new rx-tx-swap property to allow for RX & TX pin swapping.
>>>
>>> Signed-off-by: Martin Devera <devik@eaxlabs.cz>
>>> Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>>> ---
>>> v6:
>>>    - add version changelog
>>> v5:
>>>    - yaml fixes based on Rob Herring comments
>>>      - add serial.yaml reference
>>>      - move compatible from 'then' to 'if'
>>> v3:
>>>    - don't allow rx-tx-swap for st,stm32-uart (suggested
>>>      by Fabrice Gasnier)
>>> v2:
>>>    - change st,swap to rx-tx-swap (suggested by Rob Herring)
>>> ---
>>>   .../devicetree/bindings/serial/st,stm32-uart.yaml  | 29 
>>> ++++++++++++++--------
>>>   1 file changed, 19 insertions(+), 10 deletions(-)
>>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>> ./Documentation/devicetree/bindings/serial/st,stm32-uart.yaml:81:12: 
>> [warning] wrong indentation: expected 10 but found 11 (indentation)
>>
>> dtschema/dtc warnings/errors:
>>
>> See https://patchwork.ozlabs.org/patch/1451861
>>
>> This check can fail if there are any dependencies. The base for a patch
>> series is generally the most recent rc1.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
> Yoy are right, there is one extra space. But for some reason the check 
> doesn't
> find it: 
Argh... sorry, ignore it please. It seems I removed yamllint.
I see the error now.