All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Miao <eric.y.miao@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
	kernel list <linux-kernel@vger.kernel.org>,
	Dirk@opfer-online.de, arminlitzel@web.de,
	Cyril Hrubis <metan@ucw.cz>,
	thommycheck@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz,
	zaurus-devel@www.linuxtogo.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1
Date: Wed, 6 Jan 2010 15:17:39 +0800	[thread overview]
Message-ID: <f17812d71001052317h2bf25fady6bd729b35ef6db63@mail.gmail.com> (raw)
In-Reply-To: <20100106071026.GD1382@ucw.cz>

On Wed, Jan 6, 2010 at 3:10 PM, Pavel Machek <pavel@ucw.cz> wrote:
>
> Sharp-SL code uses strange, complex grouping of gpios for wakeups
> toggling. Fortunately, it is unneeded in recent kernels (and actually
> provokes WARN_ONs during resume). Remove it.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Pavel,

The code to be removed below is used to support pxa27x_keypad
to be able to resume from sleep. What's the exact reason to remove
this on spitz?

WARNING: multiple messages have this Message-ID (diff)
From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1
Date: Wed, 6 Jan 2010 15:17:39 +0800	[thread overview]
Message-ID: <f17812d71001052317h2bf25fady6bd729b35ef6db63@mail.gmail.com> (raw)
In-Reply-To: <20100106071026.GD1382@ucw.cz>

On Wed, Jan 6, 2010 at 3:10 PM, Pavel Machek <pavel@ucw.cz> wrote:
>
> Sharp-SL code uses strange, complex grouping of gpios for wakeups
> toggling. Fortunately, it is unneeded in recent kernels (and actually
> provokes WARN_ONs during resume). Remove it.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Pavel,

The code to be removed below is used to support pxa27x_keypad
to be able to resume from sleep. What's the exact reason to remove
this on spitz?

  reply	other threads:[~2010-01-06  7:18 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  7:10 sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1 Pavel Machek
2010-01-06  7:10 ` Pavel Machek
2010-01-06  7:17 ` Eric Miao [this message]
2010-01-06  7:17   ` Eric Miao
2010-01-07  6:52   ` Pavel Machek
2010-01-07  6:52     ` Pavel Machek
2010-01-07  6:52     ` Pavel Machek
2010-01-07  7:33     ` Eric Miao
2010-01-07  7:33       ` Eric Miao
2010-01-07  7:33       ` Eric Miao
2010-01-23 19:41       ` Stanislav Brabec
2010-01-23 19:41         ` Stanislav Brabec
2010-01-23 19:41         ` Stanislav Brabec
2010-01-23 22:43         ` gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1) Stanislav Brabec
2010-01-23 22:43           ` Stanislav Brabec
2010-01-23 22:43           ` Stanislav Brabec
2010-01-26  3:58           ` Eric Miao
2010-01-26  3:58             ` Eric Miao
2010-01-26  3:58             ` Eric Miao
2010-01-26 10:13             ` Stanislav Brabec
2010-01-26 10:13               ` Stanislav Brabec
2010-01-26 10:13               ` Stanislav Brabec
2010-01-26 10:20               ` Eric Miao
2010-01-26 10:20                 ` Eric Miao
2010-01-26 10:20                 ` Eric Miao
2010-01-26 10:44                 ` Stanislav Brabec
2010-01-26 10:44                   ` Stanislav Brabec
2010-01-26 10:44                   ` Stanislav Brabec
2010-01-26 11:23                   ` Dmitry Eremin-Solenikov
2010-01-26 11:23                     ` Dmitry Eremin-Solenikov
2010-01-26 11:23                     ` Dmitry Eremin-Solenikov
2010-01-26 11:39                   ` Eric Miao
2010-01-26 11:39                     ` Eric Miao
2010-01-26 11:39                     ` Eric Miao
2010-01-26 12:50                     ` Stanislav Brabec
2010-01-26 12:50                       ` Stanislav Brabec
2010-01-26 12:50                       ` Stanislav Brabec
2010-03-05  9:23       ` sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1 Pavel Machek
2010-03-05  9:23         ` Pavel Machek
2010-03-05  9:23         ` Pavel Machek
2010-03-08  5:35         ` Eric Miao
2010-03-08  5:35           ` Eric Miao
2010-03-08  5:35           ` Eric Miao
2010-04-29 13:08           ` Pavel Machek
2010-04-29 13:08             ` Pavel Machek
2010-04-29 13:08             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d71001052317h2bf25fady6bd729b35ef6db63@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=Dirk@opfer-online.de \
    --cc=akpm@osdl.org \
    --cc=arminlitzel@web.de \
    --cc=dbaryshkov@gmail.com \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metan@ucw.cz \
    --cc=omegamoon@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=rpurdie@rpsys.net \
    --cc=thommycheck@gmail.com \
    --cc=utx@penguin.cz \
    --cc=zaurus-devel@www.linuxtogo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.