From: Chao Yu <chao@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: move release of block devices to after kill_block_super()
Date: Thu, 28 Dec 2023 09:09:29 +0800 [thread overview]
Message-ID: <f1def3f6-e93d-46f0-b074-b459b6255b84@kernel.org> (raw)
In-Reply-To: <20231227171429.9223-2-ebiggers@kernel.org>
On 2023/12/28 1:14, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Call destroy_device_list() and free the f2fs_sb_info from
> kill_f2fs_super(), after the call to kill_block_super(). This is
> necessary to order it after the call to fscrypt_destroy_keyring() once
> generic_shutdown_super() starts calling fscrypt_destroy_keyring() just
> after calling ->put_super. This is because fscrypt_destroy_keyring()
> may call into f2fs_get_devices() via the fscrypt_operations.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: move release of block devices to after kill_block_super()
Date: Thu, 28 Dec 2023 09:09:29 +0800 [thread overview]
Message-ID: <f1def3f6-e93d-46f0-b074-b459b6255b84@kernel.org> (raw)
In-Reply-To: <20231227171429.9223-2-ebiggers@kernel.org>
On 2023/12/28 1:14, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Call destroy_device_list() and free the f2fs_sb_info from
> kill_f2fs_super(), after the call to kill_block_super(). This is
> necessary to order it after the call to fscrypt_destroy_keyring() once
> generic_shutdown_super() starts calling fscrypt_destroy_keyring() just
> after calling ->put_super. This is because fscrypt_destroy_keyring()
> may call into f2fs_get_devices() via the fscrypt_operations.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2023-12-28 1:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 17:14 [f2fs-dev] [PATCH v2 0/2] Move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-27 17:14 ` Eric Biggers
2023-12-27 17:14 ` [f2fs-dev] [PATCH v2 1/2] f2fs: move release of block devices to after kill_block_super() Eric Biggers
2023-12-27 17:14 ` Eric Biggers
2023-12-28 1:09 ` Chao Yu [this message]
2023-12-28 1:09 ` [f2fs-dev] " Chao Yu
2023-12-27 17:14 ` [f2fs-dev] [PATCH v2 2/2] fs: move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-27 17:14 ` Eric Biggers
2024-01-16 19:02 ` [f2fs-dev] [PATCH v2 0/2] Move " patchwork-bot+f2fs
2024-01-16 19:02 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1def3f6-e93d-46f0-b074-b459b6255b84@kernel.org \
--to=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.