From: Scott Branden <scott.branden@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Sheetal Tigadoli" <sheetal.tigadoli@broadcom.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Praveen Kumar B <praveen.b@broadcom.com>
Subject: Re: [PATCH 1/3] dt-bindings: pwm: kona: Add new compatible for new version pwm-kona
Date: Fri, 11 Jan 2019 13:28:45 -0800 [thread overview]
Message-ID: <f1ec3121-a8e7-a1c0-008a-ea4ae6028157@broadcom.com> (raw)
In-Reply-To: <20190111204801.2ytdeblcai7lg3on@pengutronix.de>
Hi Uwe
On 2019-01-11 12:48 p.m., Uwe Kleine-König wrote:
> On Fri, Jan 11, 2019 at 10:51:14AM +0530, Sheetal Tigadoli wrote:
>> From: Praveen Kumar B <praveen.b@broadcom.com>
>>
>> Add new compatible string for new version of pwm-kona
>>
>> Signed-off-by: Praveen Kumar B <praveen.b@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com>
>> ---
>> Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt b/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt
>> index 8eae9fe..d37f697 100644
>> --- a/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt
>> +++ b/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt
>> @@ -3,7 +3,7 @@ Broadcom Kona PWM controller device tree bindings
>> This controller has 6 channels.
>>
>> Required Properties :
>> -- compatible: should contain "brcm,kona-pwm"
>> +- compatible: should contain "brcm,kona-pwm" or "brcm,kona-pwm-v2"
> Is v2 used on a newer generation of kona SoCs? On i.MX these variants
> are usually named after the first SoC that came with the new variant. Is
> this sensible here, too?
It doesn't make as much sense here as different revs of the IP block are
picked up based on various decisions.
A new SoC could decide to use an old version.
>
> Best regards
> Uwe
>
WARNING: multiple messages have this Message-ID (diff)
From: Scott Branden <scott.branden@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Sheetal Tigadoli" <sheetal.tigadoli@broadcom.com>
Cc: linux-pwm@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
devicetree@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Praveen Kumar B <praveen.b@broadcom.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: pwm: kona: Add new compatible for new version pwm-kona
Date: Fri, 11 Jan 2019 13:28:45 -0800 [thread overview]
Message-ID: <f1ec3121-a8e7-a1c0-008a-ea4ae6028157@broadcom.com> (raw)
In-Reply-To: <20190111204801.2ytdeblcai7lg3on@pengutronix.de>
Hi Uwe
On 2019-01-11 12:48 p.m., Uwe Kleine-König wrote:
> On Fri, Jan 11, 2019 at 10:51:14AM +0530, Sheetal Tigadoli wrote:
>> From: Praveen Kumar B <praveen.b@broadcom.com>
>>
>> Add new compatible string for new version of pwm-kona
>>
>> Signed-off-by: Praveen Kumar B <praveen.b@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com>
>> ---
>> Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt b/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt
>> index 8eae9fe..d37f697 100644
>> --- a/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt
>> +++ b/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt
>> @@ -3,7 +3,7 @@ Broadcom Kona PWM controller device tree bindings
>> This controller has 6 channels.
>>
>> Required Properties :
>> -- compatible: should contain "brcm,kona-pwm"
>> +- compatible: should contain "brcm,kona-pwm" or "brcm,kona-pwm-v2"
> Is v2 used on a newer generation of kona SoCs? On i.MX these variants
> are usually named after the first SoC that came with the new variant. Is
> this sensible here, too?
It doesn't make as much sense here as different revs of the IP block are
picked up based on various decisions.
A new SoC could decide to use an old version.
>
> Best regards
> Uwe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 21:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 5:21 [PATCH 0/3] Add support for PWM Configure and stablize for PWM kona Sheetal Tigadoli
2019-01-11 5:21 ` Sheetal Tigadoli
2019-01-11 5:21 ` Sheetal Tigadoli
2019-01-11 5:21 ` [PATCH 1/3] dt-bindings: pwm: kona: Add new compatible for new version pwm-kona Sheetal Tigadoli
2019-01-11 5:21 ` Sheetal Tigadoli
2019-01-11 20:48 ` Uwe Kleine-König
2019-01-11 20:48 ` Uwe Kleine-König
2019-01-11 21:28 ` Scott Branden [this message]
2019-01-11 21:28 ` Scott Branden
2019-01-12 15:05 ` Uwe Kleine-König
2019-01-12 15:05 ` Uwe Kleine-König
2019-01-16 0:14 ` Scott Branden
2019-01-16 0:14 ` Scott Branden
2019-01-21 23:11 ` Rob Herring
2019-01-21 23:11 ` Rob Herring
2019-01-21 23:11 ` Rob Herring
2019-01-22 20:12 ` Scott Branden
2019-01-22 20:12 ` Scott Branden
2019-01-11 5:21 ` [PATCH 2/3] drivers: pwm: pwm-bcm-kona: Add pwm-kona-v2 support Sheetal Tigadoli
2019-01-11 5:21 ` Sheetal Tigadoli
2019-01-11 13:51 ` Andrew Lunn
2019-01-11 13:51 ` Andrew Lunn
2019-01-11 20:54 ` Uwe Kleine-König
2019-01-11 20:54 ` Uwe Kleine-König
2019-01-11 5:21 ` [PATCH 3/3] ARM: dts: cygnus: Change pwm compatible to new version Sheetal Tigadoli
2019-01-11 5:21 ` Sheetal Tigadoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ec3121-a8e7-a1c0-008a-ea4ae6028157@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=praveen.b@broadcom.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=sheetal.tigadoli@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.