From: Michal Simek <michal.simek@xilinx.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Michal Simek" <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver
Date: Mon, 31 Jul 2017 09:37:17 +0200 [thread overview]
Message-ID: <f239a211-2a9d-f0ab-5295-a87355036877@xilinx.com> (raw)
In-Reply-To: <20170721154720.ifjsn3og6apqi7mv@xsjsorenbubuntu.xilinx.com>
On 21.7.2017 17:47, Sören Brinkmann wrote:
> On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote:
>> register_console() is called from
>> uart_add_one_port()->uart_configure_port()
>> that's why register_console() is called twice.
>>
>> This patch remove console_initcall to call register_console() only from
>> one location.
>>
>> Also based on my tests cdns_uart_console_setup() is not called
>> from the first register_console() call.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> I am not quite sure about this because console_initcall is called
>> early but I can see any difference in usage.
>> pl011 is not calling this but others are doing it.
>
> Doesn't this break early console/printk? I would expect that the UART
> initialization may happen later than console init.
as I said. I can't see any issue with it. Definitely please try.
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Michal Simek" <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver
Date: Mon, 31 Jul 2017 09:37:17 +0200 [thread overview]
Message-ID: <f239a211-2a9d-f0ab-5295-a87355036877@xilinx.com> (raw)
In-Reply-To: <20170721154720.ifjsn3og6apqi7mv@xsjsorenbubuntu.xilinx.com>
On 21.7.2017 17:47, Sören Brinkmann wrote:
> On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote:
>> register_console() is called from
>> uart_add_one_port()->uart_configure_port()
>> that's why register_console() is called twice.
>>
>> This patch remove console_initcall to call register_console() only from
>> one location.
>>
>> Also based on my tests cdns_uart_console_setup() is not called
>> from the first register_console() call.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> I am not quite sure about this because console_initcall is called
>> early but I can see any difference in usage.
>> pl011 is not calling this but others are doing it.
>
> Doesn't this break early console/printk? I would expect that the UART
> initialization may happen later than console init.
as I said. I can't see any issue with it. Definitely please try.
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver
Date: Mon, 31 Jul 2017 09:37:17 +0200 [thread overview]
Message-ID: <f239a211-2a9d-f0ab-5295-a87355036877@xilinx.com> (raw)
In-Reply-To: <20170721154720.ifjsn3og6apqi7mv@xsjsorenbubuntu.xilinx.com>
On 21.7.2017 17:47, S?ren Brinkmann wrote:
> On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote:
>> register_console() is called from
>> uart_add_one_port()->uart_configure_port()
>> that's why register_console() is called twice.
>>
>> This patch remove console_initcall to call register_console() only from
>> one location.
>>
>> Also based on my tests cdns_uart_console_setup() is not called
>> from the first register_console() call.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> I am not quite sure about this because console_initcall is called
>> early but I can see any difference in usage.
>> pl011 is not calling this but others are doing it.
>
> Doesn't this break early console/printk? I would expect that the UART
> initialization may happen later than console init.
as I said. I can't see any issue with it. Definitely please try.
Thanks,
Michal
next prev parent reply other threads:[~2017-07-31 7:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 9:32 [RFC PATCH 0/4] serial: uartps: Dynamic allocation Michal Simek
2017-07-21 9:32 ` Michal Simek
2017-07-21 9:32 ` [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver Michal Simek
2017-07-21 9:32 ` Michal Simek
2017-07-21 15:47 ` Sören Brinkmann
2017-07-21 15:47 ` Sören Brinkmann
2017-07-21 15:47 ` Sören Brinkmann
2017-07-31 7:37 ` Michal Simek [this message]
2017-07-31 7:37 ` Michal Simek
2017-07-31 7:37 ` Michal Simek
2017-07-21 9:32 ` [RFC PATCH 2/4] serial: uartps: Use dynamic array for console port Michal Simek
2017-07-21 9:32 ` Michal Simek
2017-07-21 9:32 ` [RFC PATCH 3/4] serial: uartps: Move cnds_uart_get_port to probe Michal Simek
2017-07-21 9:32 ` Michal Simek
2017-07-21 9:32 ` [RFC PATCH 4/4] serial: uartps: Remove static port array Michal Simek
2017-07-21 9:32 ` Michal Simek
2017-07-28 18:39 ` [RFC PATCH 0/4] serial: uartps: Dynamic allocation Alan Cox
2017-07-28 18:39 ` Alan Cox
2017-07-28 18:39 ` Alan Cox
2017-07-31 7:42 ` Michal Simek
2017-07-31 7:42 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f239a211-2a9d-f0ab-5295-a87355036877@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.