From: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
To: Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding
Date: Tue, 27 Oct 2020 09:09:57 -0500 [thread overview]
Message-ID: <f35152af-34ad-178b-61db-0e57c8d19f3f@amd.com> (raw)
In-Reply-To: <20201027123722.2935-1-aladyshev22@gmail.com>
These changes are already merged in https://github.com/openbmc/linux/blob/dev-5.8/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts by Joel.
Please abandon these changes.
Thanks,
Supreeth
On 10/27/20 7:37 AM, Konstantin Aladyshev wrote:
> [CAUTION: External Email]
>
> KCS nodes compatible property in the 'aspeed-g5.dtsi' file was
> changed to use v2 binding in the commit fa4c8ec6feaa
> ("ARM: dts: aspeed: Change KCS nodes to v2 binding").
> For the proper initialization of /dev/ipmi-kcs* devices
> KCS node variables also need to be changed to use v2 binding.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> index 60ba86f3e5bc..89ddc3847222 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> @@ -139,17 +139,17 @@
>
> &kcs1 {
> status = "okay";
> - kcs_addr = <0x60>;
> + aspeed,lpc-io-reg = <0x60>;
> };
>
> &kcs2 {
> status = "okay";
> - kcs_addr = <0x62>;
> + aspeed,lpc-io-reg = <0x62>;
> };
>
> &kcs4 {
> status = "okay";
> - kcs_addr = <0x97DE>;
> + aspeed,lpc-io-reg = <0x97DE>;
> };
>
> &lpc_snoop {
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
To: Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding
Date: Tue, 27 Oct 2020 09:09:57 -0500 [thread overview]
Message-ID: <f35152af-34ad-178b-61db-0e57c8d19f3f@amd.com> (raw)
In-Reply-To: <20201027123722.2935-1-aladyshev22@gmail.com>
These changes are already merged in https://github.com/openbmc/linux/blob/dev-5.8/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts by Joel.
Please abandon these changes.
Thanks,
Supreeth
On 10/27/20 7:37 AM, Konstantin Aladyshev wrote:
> [CAUTION: External Email]
>
> KCS nodes compatible property in the 'aspeed-g5.dtsi' file was
> changed to use v2 binding in the commit fa4c8ec6feaa
> ("ARM: dts: aspeed: Change KCS nodes to v2 binding").
> For the proper initialization of /dev/ipmi-kcs* devices
> KCS node variables also need to be changed to use v2 binding.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> index 60ba86f3e5bc..89ddc3847222 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> @@ -139,17 +139,17 @@
>
> &kcs1 {
> status = "okay";
> - kcs_addr = <0x60>;
> + aspeed,lpc-io-reg = <0x60>;
> };
>
> &kcs2 {
> status = "okay";
> - kcs_addr = <0x62>;
> + aspeed,lpc-io-reg = <0x62>;
> };
>
> &kcs4 {
> status = "okay";
> - kcs_addr = <0x97DE>;
> + aspeed,lpc-io-reg = <0x97DE>;
> };
>
> &lpc_snoop {
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 18:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 12:37 [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding Konstantin Aladyshev
2020-10-27 12:37 ` Konstantin Aladyshev
2020-10-27 12:37 ` [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3 Konstantin Aladyshev
2020-10-27 12:37 ` Konstantin Aladyshev
2020-10-28 5:28 ` Joel Stanley
2020-10-28 5:28 ` Joel Stanley
2020-10-28 15:59 ` Supreeth Venkatesh
2020-10-28 15:59 ` Supreeth Venkatesh
2020-10-27 12:37 ` [PATCH 3/3] ARM: dts: aspeed: amd-ethanolx: Enable devices for the iKVM functionality Konstantin Aladyshev
2020-10-27 12:37 ` Konstantin Aladyshev
2020-10-27 14:02 ` Supreeth Venkatesh
2020-10-27 14:02 ` Supreeth Venkatesh
2020-10-28 5:28 ` Joel Stanley
2020-10-28 5:28 ` Joel Stanley
2020-10-27 14:09 ` Supreeth Venkatesh [this message]
2020-10-27 14:09 ` [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding Supreeth Venkatesh
2020-10-27 21:00 ` Konstantin Aladyshev
2020-10-27 21:00 ` Konstantin Aladyshev
2020-10-28 9:50 ` Joel Stanley
2020-10-28 9:50 ` Joel Stanley
2020-10-28 5:25 ` Joel Stanley
2020-10-28 5:25 ` Joel Stanley
2020-10-28 5:32 ` Joel Stanley
2020-10-28 5:32 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f35152af-34ad-178b-61db-0e57c8d19f3f@amd.com \
--to=supreeth.venkatesh@amd.com \
--cc=aladyshev22@gmail.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.