From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Cc: "Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
"Jens Axboe" <axboe@kernel.dk>, "Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Haren Myneni" <haren@us.ibm.com>,
"Breno Leitão" <leitao@debian.org>,
"Nayna Jain" <nayna@linux.ibm.com>,
"Paulo Flabiano Smorigo" <pfsmorigo@gmail.com>,
"Steven Royer" <seroyer@linux.ibm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Cristobal Forno" <cforno12@linux.ibm.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Dany Madden" <drt@linux.ibm.com>,
"Lijun Pan" <ljp@linux.ibm.com>,
"Tyrel Datwyler" <tyreld@linux.ibm.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Michael Cyr" <mikecyr@linux.ibm.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, linux-block@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH] vio: make remove callback return void
Date: Thu, 28 Jan 2021 21:08:36 +0100 [thread overview]
Message-ID: <f3655d10-26ba-5f9f-761e-2f48d13d0b11@kleine-koenig.org> (raw)
In-Reply-To: <20210128190750.GA490196@us.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]
Hello Sukadev,
On 1/28/21 8:07 PM, Sukadev Bhattiprolu wrote:
> Slightly off-topic, should ndo_stop() also return a void? Its return value
> seems to be mostly ignored and [...]
I don't know enough about the network stack to tell. Probably it's a
good idea to start a separate thread for this and address this to the
netdev list only.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Cc: "Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
"Jens Axboe" <axboe@kernel.dk>, "Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Haren Myneni" <haren@us.ibm.com>,
"Breno Leitão" <leitao@debian.org>,
"Nayna Jain" <nayna@linux.ibm.com>,
"Paulo Flabiano Smorigo" <pfsmorigo@gmail.com>,
"Steven Royer" <seroyer@linux.ibm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Cristobal Forno" <cforno12@linux.ibm.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Dany Madden" <drt@linux.ibm.com>,
"Lijun Pan" <ljp@linux.ibm.com>,
"Tyrel Datwyler" <tyreld@linux.ibm.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Michael Cyr" <mikecyr@linux.ibm.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, linux-block@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH] vio: make remove callback return void
Date: Thu, 28 Jan 2021 20:08:36 +0000 [thread overview]
Message-ID: <f3655d10-26ba-5f9f-761e-2f48d13d0b11@kleine-koenig.org> (raw)
In-Reply-To: <20210128190750.GA490196@us.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]
Hello Sukadev,
On 1/28/21 8:07 PM, Sukadev Bhattiprolu wrote:
> Slightly off-topic, should ndo_stop() also return a void? Its return value
> seems to be mostly ignored and [...]
I don't know enough about the network stack to tell. Probably it's a
good idea to start a separate thread for this and address this to the
netdev list only.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Cc: "Tyrel Datwyler" <tyreld@linux.ibm.com>,
"Cristobal Forno" <cforno12@linux.ibm.com>,
sparclinux@vger.kernel.org, target-devel@vger.kernel.org,
"Paul Mackerras" <paulus@samba.org>,
"Breno Leitão" <leitao@debian.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
linux-scsi@vger.kernel.org, "Nayna Jain" <nayna@linux.ibm.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Michael Cyr" <mikecyr@linux.ibm.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-block@vger.kernel.org, "Lijun Pan" <ljp@linux.ibm.com>,
"Matt Mackall" <mpm@selenic.com>, "Jens Axboe" <axboe@kernel.dk>,
"Steven Royer" <seroyer@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Jarkko Sakkinen" <jarkko@kernel.org>,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
"Dany Madden" <drt@linux.ibm.com>,
"Paulo Flabiano Smorigo" <pfsmorigo@gmail.com>,
linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] vio: make remove callback return void
Date: Thu, 28 Jan 2021 21:08:36 +0100 [thread overview]
Message-ID: <f3655d10-26ba-5f9f-761e-2f48d13d0b11@kleine-koenig.org> (raw)
In-Reply-To: <20210128190750.GA490196@us.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]
Hello Sukadev,
On 1/28/21 8:07 PM, Sukadev Bhattiprolu wrote:
> Slightly off-topic, should ndo_stop() also return a void? Its return value
> seems to be mostly ignored and [...]
I don't know enough about the network stack to tell. Probably it's a
good idea to start a separate thread for this and address this to the
netdev list only.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-28 20:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 21:50 [PATCH] vio: make remove callback return void Uwe Kleine-König
2021-01-27 21:50 ` Uwe Kleine-König
2021-01-27 21:50 ` Uwe Kleine-König
2021-01-28 19:07 ` Sukadev Bhattiprolu
2021-01-28 20:08 ` Uwe Kleine-König [this message]
2021-01-28 20:08 ` Uwe Kleine-König
2021-01-28 20:08 ` Uwe Kleine-König
2021-01-29 18:58 ` Tyrel Datwyler
2021-01-29 18:58 ` Tyrel Datwyler
2021-01-29 18:58 ` Tyrel Datwyler
2021-01-29 19:08 ` Lijun Pan
2021-01-29 19:08 ` Lijun Pan
2021-01-29 19:08 ` Lijun Pan
2021-02-04 16:08 ` Greg Kroah-Hartman
2021-02-04 16:08 ` Greg Kroah-Hartman
2021-02-04 16:08 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3655d10-26ba-5f9f-761e-2f48d13d0b11@kleine-koenig.org \
--to=uwe@kleine-koenig.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=cforno12@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=drt@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haren@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ljp@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mikecyr@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=mpm@selenic.com \
--cc=nayna@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterhuewe@gmx.de \
--cc=pfsmorigo@gmail.com \
--cc=seroyer@linux.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=sukadev@linux.ibm.com \
--cc=target-devel@vger.kernel.org \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.