From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jocelyn Falempe <jfalempe@redhat.com>, dri-devel@lists.freedesktop.org
Cc: michel@daenzer.net, lyude@redhat.com, javierm@redhat.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mgag200 fix memmapsl configuration in GCTL6 register
Date: Wed, 19 Jan 2022 15:55:13 +0100 [thread overview]
Message-ID: <f368442d-fedc-2fdf-5618-ed323060df9c@suse.de> (raw)
In-Reply-To: <967fd413-1b55-7b94-a164-70f2942772f6@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --]
Hi
Am 19.01.22 um 13:21 schrieb Thomas Zimmermann:
>
> Appears to be working on my test machine.
>
> But please rune scripts/checkpatch.pl on the patch before sending it. I
> get several errors
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75
> chars per line)
>
> #98:
>
> 0: Enables alpha mode, and the character generator addressing
> system is
>
>
>
> ERROR: trailing whitespace
>
> #149: FILE: drivers/gpu/drm/mgag200/mgag200_mode.c:532:
>
> +^I/* GCTL6 should be 0x05, but we configure memmapsl to 0xb8000 (text
> mode),^M$
>
>
>
> ERROR: trailing whitespace
>
> #150: FILE: drivers/gpu/drm/mgag200/mgag200_mode.c:533:
>
> +^I * so that it doesn't hang when running kexec/kdump on G200_SE rev42.^M$
>
Thanks a lot, the patch has been merge now. These problems might have
been caused by my email client.
Best regards
Thomas
>
>
>
> Best regards
> Thomas
>
>
>> WREG_GFX(7, 0x0f);
>> WREG_GFX(8, 0x0f);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jocelyn Falempe <jfalempe@redhat.com>, dri-devel@lists.freedesktop.org
Cc: michel@daenzer.net, javierm@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] mgag200 fix memmapsl configuration in GCTL6 register
Date: Wed, 19 Jan 2022 15:55:13 +0100 [thread overview]
Message-ID: <f368442d-fedc-2fdf-5618-ed323060df9c@suse.de> (raw)
In-Reply-To: <967fd413-1b55-7b94-a164-70f2942772f6@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --]
Hi
Am 19.01.22 um 13:21 schrieb Thomas Zimmermann:
>
> Appears to be working on my test machine.
>
> But please rune scripts/checkpatch.pl on the patch before sending it. I
> get several errors
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75
> chars per line)
>
> #98:
>
> 0: Enables alpha mode, and the character generator addressing
> system is
>
>
>
> ERROR: trailing whitespace
>
> #149: FILE: drivers/gpu/drm/mgag200/mgag200_mode.c:532:
>
> +^I/* GCTL6 should be 0x05, but we configure memmapsl to 0xb8000 (text
> mode),^M$
>
>
>
> ERROR: trailing whitespace
>
> #150: FILE: drivers/gpu/drm/mgag200/mgag200_mode.c:533:
>
> +^I * so that it doesn't hang when running kexec/kdump on G200_SE rev42.^M$
>
Thanks a lot, the patch has been merge now. These problems might have
been caused by my email client.
Best regards
Thomas
>
>
>
> Best regards
> Thomas
>
>
>> WREG_GFX(7, 0x0f);
>> WREG_GFX(8, 0x0f);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-01-19 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 9:47 mgag200 fix memmapsl configuration in GCTL6 register Jocelyn Falempe
2022-01-14 9:47 ` [PATCH] " Jocelyn Falempe
2022-01-18 16:38 ` Javier Martinez Canillas
2022-01-18 16:52 ` Jocelyn Falempe
2022-01-18 17:17 ` Javier Martinez Canillas
2022-01-18 17:25 ` Jocelyn Falempe
2022-01-18 19:06 ` Lyude Paul
2022-01-19 8:16 ` Thomas Zimmermann
2022-01-19 10:29 ` [PATCH v2] " Jocelyn Falempe
2022-01-19 10:29 ` Jocelyn Falempe
2022-01-19 12:21 ` Thomas Zimmermann
2022-01-19 12:21 ` Thomas Zimmermann
2022-01-19 14:55 ` Thomas Zimmermann [this message]
2022-01-19 14:55 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f368442d-fedc-2fdf-5618-ed323060df9c@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=lyude@redhat.com \
--cc=michel@daenzer.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.