From: Samuel Holland <samuel@sholland.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Jerome Brunet <jbrunet@baylibre.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/4] ALSA: pcm: Make snd_pcm_limit_hw_rates take hw directly
Date: Fri, 14 Feb 2020 21:19:50 -0600 [thread overview]
Message-ID: <f443a53e-e214-481f-fe9c-6fe480d91292@sholland.org> (raw)
In-Reply-To: <s5ha75nyp6v.wl-tiwai@suse.de>
On 2/13/20 12:30 AM, Takashi Iwai wrote:
> On Thu, 13 Feb 2020 07:11:45 +0100,
> Samuel Holland wrote:
>>
>> It can be useful to derive min/max rates of a snd_pcm_hardware without
>> having a snd_pcm_runtime, such as before constructing an ASoC DAI link.
>>
>> Since snd_pcm_limit_hw_rates only uses runtime->hw, it does not actually
>> need the snd_pcm_runtime. Modify it to take a pointer to hw directly.
>
> I prefer adding a new function and change snd_pcm_limit_hw_rates() to
> static inline just calling the new one with &runtime->hw, instead of
> touching so many callers site.
I agree. I will definitely do that for v2.
Thanks,
Samuel
> thanks,
>
> Takashi
>
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [alsa-devel] [PATCH 2/4] ALSA: pcm: Make snd_pcm_limit_hw_rates take hw directly
Date: Fri, 14 Feb 2020 21:19:50 -0600 [thread overview]
Message-ID: <f443a53e-e214-481f-fe9c-6fe480d91292@sholland.org> (raw)
In-Reply-To: <s5ha75nyp6v.wl-tiwai@suse.de>
On 2/13/20 12:30 AM, Takashi Iwai wrote:
> On Thu, 13 Feb 2020 07:11:45 +0100,
> Samuel Holland wrote:
>>
>> It can be useful to derive min/max rates of a snd_pcm_hardware without
>> having a snd_pcm_runtime, such as before constructing an ASoC DAI link.
>>
>> Since snd_pcm_limit_hw_rates only uses runtime->hw, it does not actually
>> need the snd_pcm_runtime. Modify it to take a pointer to hw directly.
>
> I prefer adding a new function and change snd_pcm_limit_hw_rates() to
> static inline just calling the new one with &runtime->hw, instead of
> touching so many callers site.
I agree. I will definitely do that for v2.
Thanks,
Samuel
> thanks,
>
> Takashi
>
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-15 3:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 6:11 [PATCH 0/4] simple-audio-card codec2codec support Samuel Holland
2020-02-13 6:11 ` [alsa-devel] " Samuel Holland
2020-02-13 6:11 ` [PATCH 1/4] ASoC: codec2codec: avoid invalid/double-free of pcm runtime Samuel Holland
2020-02-13 6:11 ` [alsa-devel] " Samuel Holland
2020-02-13 8:37 ` Jerome Brunet
2020-02-13 8:37 ` [alsa-devel] " Jerome Brunet
2020-02-13 11:37 ` Mark Brown
2020-02-13 11:37 ` [alsa-devel] " Mark Brown
2020-02-13 13:37 ` Jerome Brunet
2020-02-13 13:37 ` [alsa-devel] " Jerome Brunet
2020-02-13 13:31 ` Applied "ASoC: codec2codec: avoid invalid/double-free of pcm runtime" to the asoc tree Mark Brown
2020-02-13 13:31 ` [alsa-devel] " Mark Brown
2020-02-13 6:11 ` [PATCH 2/4] ALSA: pcm: Make snd_pcm_limit_hw_rates take hw directly Samuel Holland
2020-02-13 6:11 ` [alsa-devel] " Samuel Holland
2020-02-13 6:30 ` Takashi Iwai
2020-02-13 6:30 ` [alsa-devel] " Takashi Iwai
2020-02-15 3:19 ` Samuel Holland [this message]
2020-02-15 3:19 ` Samuel Holland
2020-02-13 6:11 ` [PATCH 3/4] ASoC: pcm: Export parameter intersection logic Samuel Holland
2020-02-13 6:11 ` [alsa-devel] " Samuel Holland
2020-02-13 6:11 ` [PATCH 4/4] ASoC: simple-card: Add support for codec-to-codec dai_links Samuel Holland
2020-02-13 6:11 ` [alsa-devel] " Samuel Holland
2020-02-13 9:18 ` Jerome Brunet
2020-02-13 9:18 ` [alsa-devel] " Jerome Brunet
2020-02-13 11:38 ` Mark Brown
2020-02-13 11:38 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f443a53e-e214-481f-fe9c-6fe480d91292@sholland.org \
--to=samuel@sholland.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.