All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Matthias Gerstner <matthias.gerstner@suse.de>, kvm@vger.kernel.org
Subject: Re: [PATCH] tools/kvm_stat: fix attack vector with user controlled FUSE mounts
Date: Thu, 3 Nov 2022 15:21:12 +0100	[thread overview]
Message-ID: <f5315936-fbdf-c7b1-e7a9-f494001eebfd@redhat.com> (raw)
In-Reply-To: <20221103135927.13656-1-matthias.gerstner@suse.de>

On 11/3/22 14:59, Matthias Gerstner wrote:
> The fix is simply to use the file system type field instead. Whitespace
> in the mount path is escaped in /proc/mounts thus no further safety
> measures in the parsing should be necessary to make this correct.

Can you please send a patch to replace seq_printf with seq_escape in 
afs_show_devname though?  I couldn't find anything that prevents 
cell->name and volume->name from containing a space, so better safe than 
sorry.

Paolo


  parent reply	other threads:[~2022-11-03 14:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 13:59 [PATCH] tools/kvm_stat: fix attack vector with user controlled FUSE mounts Matthias Gerstner
2022-11-03 14:08 ` Paolo Bonzini
2022-11-03 14:21 ` Paolo Bonzini [this message]
2022-11-04 11:16   ` Matthias Gerstner
2022-11-04 11:17     ` Paolo Bonzini
2022-11-06  8:43 ` Paolo Bonzini
2022-11-07 14:12   ` Matthias Gerstner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5315936-fbdf-c7b1-e7a9-f494001eebfd@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=matthias.gerstner@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.