From: Neil Armstrong <neil.armstrong@linaro.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: italonicola@collabora.com, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Amlogic Meson SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] arm64: dts: Add DT node for the VIPNano-QI on the A311D
Date: Tue, 29 Nov 2022 09:35:24 +0100 [thread overview]
Message-ID: <f69c9db1-6274-6caa-e3bd-92ae4a7bff19@linaro.org> (raw)
In-Reply-To: <20221128111740.39003-5-tomeu.vizoso@collabora.com>
On 28/11/2022 12:17, Tomeu Vizoso wrote:
> This "NPU" is very similar to the Vivante GPUs and Etnaviv works well
> with it with just a few small changes.
>
> v2: Add reference to RESET_NNA (Neil)
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 11 +++++++++++
> .../boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts | 4 ++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..aaa629816e41 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -11,6 +11,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/amlogic,meson-g12a-reset.h>
> #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/power/meson-g12a-power.h>
>
> / {
> interrupt-parent = <&gic>;
> @@ -2484,4 +2485,14 @@ xtal: xtal-clk {
> #clock-cells = <0>;
> };
>
> + npu: npu@ff100000 {
> + compatible = "vivante,gc";
> + reg = <0x0 0xff100000 0x0 0x20000>;
> + interrupts = <0 147 4>;
> + clocks = <&clkc CLKID_NNA_CORE_CLK>,
> + <&clkc CLKID_NNA_AXI_CLK>;
Nit pick, but this should be aligned.
> + clock-names = "core", "bus";
> + resets = <&reset RESET_NNA>;
> + power-domains = <&pwrc PWRC_G12A_NNA_ID>;
> + };
> };
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> index 124a80901084..73f3d87dcefd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> @@ -15,6 +15,10 @@ / {
> compatible = "khadas,vim3", "amlogic,a311d", "amlogic,g12b";
> };
>
> +&npu {
> + status = "okay";
> +};
> +
> /*
> * The VIM3 on-board MCU can mux the PCIe/USB3.0 shared differential
> * lines using a FUSB340TMX USB 3.1 SuperSpeed Data Switch between
With that fixed:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: italonicola@collabora.com, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Amlogic Meson SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] arm64: dts: Add DT node for the VIPNano-QI on the A311D
Date: Tue, 29 Nov 2022 09:35:24 +0100 [thread overview]
Message-ID: <f69c9db1-6274-6caa-e3bd-92ae4a7bff19@linaro.org> (raw)
In-Reply-To: <20221128111740.39003-5-tomeu.vizoso@collabora.com>
On 28/11/2022 12:17, Tomeu Vizoso wrote:
> This "NPU" is very similar to the Vivante GPUs and Etnaviv works well
> with it with just a few small changes.
>
> v2: Add reference to RESET_NNA (Neil)
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 11 +++++++++++
> .../boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts | 4 ++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..aaa629816e41 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -11,6 +11,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/amlogic,meson-g12a-reset.h>
> #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/power/meson-g12a-power.h>
>
> / {
> interrupt-parent = <&gic>;
> @@ -2484,4 +2485,14 @@ xtal: xtal-clk {
> #clock-cells = <0>;
> };
>
> + npu: npu@ff100000 {
> + compatible = "vivante,gc";
> + reg = <0x0 0xff100000 0x0 0x20000>;
> + interrupts = <0 147 4>;
> + clocks = <&clkc CLKID_NNA_CORE_CLK>,
> + <&clkc CLKID_NNA_AXI_CLK>;
Nit pick, but this should be aligned.
> + clock-names = "core", "bus";
> + resets = <&reset RESET_NNA>;
> + power-domains = <&pwrc PWRC_G12A_NNA_ID>;
> + };
> };
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> index 124a80901084..73f3d87dcefd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> @@ -15,6 +15,10 @@ / {
> compatible = "khadas,vim3", "amlogic,a311d", "amlogic,g12b";
> };
>
> +&npu {
> + status = "okay";
> +};
> +
> /*
> * The VIM3 on-board MCU can mux the PCIe/USB3.0 shared differential
> * lines using a FUSB340TMX USB 3.1 SuperSpeed Data Switch between
With that fixed:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: italonicola@collabora.com, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Amlogic Meson SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] arm64: dts: Add DT node for the VIPNano-QI on the A311D
Date: Tue, 29 Nov 2022 09:35:24 +0100 [thread overview]
Message-ID: <f69c9db1-6274-6caa-e3bd-92ae4a7bff19@linaro.org> (raw)
In-Reply-To: <20221128111740.39003-5-tomeu.vizoso@collabora.com>
On 28/11/2022 12:17, Tomeu Vizoso wrote:
> This "NPU" is very similar to the Vivante GPUs and Etnaviv works well
> with it with just a few small changes.
>
> v2: Add reference to RESET_NNA (Neil)
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 11 +++++++++++
> .../boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts | 4 ++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..aaa629816e41 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -11,6 +11,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/amlogic,meson-g12a-reset.h>
> #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/power/meson-g12a-power.h>
>
> / {
> interrupt-parent = <&gic>;
> @@ -2484,4 +2485,14 @@ xtal: xtal-clk {
> #clock-cells = <0>;
> };
>
> + npu: npu@ff100000 {
> + compatible = "vivante,gc";
> + reg = <0x0 0xff100000 0x0 0x20000>;
> + interrupts = <0 147 4>;
> + clocks = <&clkc CLKID_NNA_CORE_CLK>,
> + <&clkc CLKID_NNA_AXI_CLK>;
Nit pick, but this should be aligned.
> + clock-names = "core", "bus";
> + resets = <&reset RESET_NNA>;
> + power-domains = <&pwrc PWRC_G12A_NNA_ID>;
> + };
> };
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> index 124a80901084..73f3d87dcefd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dts
> @@ -15,6 +15,10 @@ / {
> compatible = "khadas,vim3", "amlogic,a311d", "amlogic,g12b";
> };
>
> +&npu {
> + status = "okay";
> +};
> +
> /*
> * The VIM3 on-board MCU can mux the PCIe/USB3.0 shared differential
> * lines using a FUSB340TMX USB 3.1 SuperSpeed Data Switch between
With that fixed:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2022-11-29 8:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:17 [PATCH v2 0/5] Support for the NPU in Vim3 Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` [PATCH v2 1/5] dt-bindings: reset: meson-g12a: Add missing NNA reset Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:42 ` Krzysztof Kozlowski
2022-11-28 11:42 ` Krzysztof Kozlowski
2022-11-28 11:42 ` Krzysztof Kozlowski
2022-11-28 11:17 ` [PATCH v2 2/5] dt-bindings: power: Add NNA power domain Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:43 ` Krzysztof Kozlowski
2022-11-28 11:43 ` Krzysztof Kozlowski
2022-11-28 11:43 ` Krzysztof Kozlowski
2022-11-28 11:17 ` [PATCH v2 3/5] soc: amlogic: meson-pwrc: Add NNA power domain for A311D Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` [PATCH v2 4/5] arm64: dts: Add DT node for the VIPNano-QI on the A311D Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
2022-11-29 8:35 ` Neil Armstrong [this message]
2022-11-29 8:35 ` Neil Armstrong
2022-11-29 8:35 ` Neil Armstrong
2022-11-28 11:17 ` [PATCH v2 5/5] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055 Tomeu Vizoso
2022-11-28 11:17 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69c9db1-6274-6caa-e3bd-92ae4a7bff19@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=italonicola@collabora.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.