From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410
Date: Wed, 1 Jun 2016 11:16:58 -0400 [thread overview]
Message-ID: <f7e99aad-f773-27c6-d554-ba30bc54b5f7@osg.samsung.com> (raw)
In-Reply-To: <1464774351-23604-3-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote:
> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file
> shared with Exynos5410 and configure the clocks on the latter.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
[snip]
>
> +&sss {
> + clocks = <&clock CLK_SSS>;
> + clock-names = "secss";
> +};
> +
[snip]
>
> +&watchdog {
> + clocks = <&clock CLK_WDT>;
> + clock-names = "watchdog";
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +};
> +
Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
I wonder if the clock and clock-names shouldn't be just defined in the
shared exynos54xx.dtsi as is the case for the interrupts that are also
the same?
The patch looks good to me though, so whatever you decide:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410
Date: Wed, 1 Jun 2016 11:16:58 -0400 [thread overview]
Message-ID: <f7e99aad-f773-27c6-d554-ba30bc54b5f7@osg.samsung.com> (raw)
In-Reply-To: <1464774351-23604-3-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote:
> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file
> shared with Exynos5410 and configure the clocks on the latter.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
[snip]
>
> +&sss {
> + clocks = <&clock CLK_SSS>;
> + clock-names = "secss";
> +};
> +
[snip]
>
> +&watchdog {
> + clocks = <&clock CLK_WDT>;
> + clock-names = "watchdog";
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +};
> +
Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
I wonder if the clock and clock-names shouldn't be just defined in the
shared exynos54xx.dtsi as is the case for the interrupts that are also
the same?
The patch looks good to me though, so whatever you decide:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-06-01 15:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:45 [PATCH 1/3] dt-bindings: clock: Add watchdog and SSS clock IDs to Exynos5410 Krzysztof Kozlowski
2016-06-01 9:45 ` Krzysztof Kozlowski
2016-06-01 9:45 ` [PATCH 2/3] clk: samsung: exynos5410: Add WDT, ACLK266 and SSS clocks Krzysztof Kozlowski
2016-06-01 9:45 ` Krzysztof Kozlowski
2016-06-01 14:55 ` Javier Martinez Canillas
2016-06-01 14:55 ` Javier Martinez Canillas
2016-06-02 9:20 ` Sylwester Nawrocki
2016-06-02 9:20 ` Sylwester Nawrocki
2016-06-06 11:02 ` Sylwester Nawrocki
2016-06-06 11:02 ` Sylwester Nawrocki
2016-06-06 11:02 ` Sylwester Nawrocki
2016-06-06 11:13 ` Krzysztof Kozlowski
2016-06-06 11:13 ` Krzysztof Kozlowski
2016-06-01 9:45 ` [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410 Krzysztof Kozlowski
2016-06-01 9:45 ` Krzysztof Kozlowski
2016-06-01 15:16 ` Javier Martinez Canillas [this message]
2016-06-01 15:16 ` Javier Martinez Canillas
2016-06-02 6:18 ` Krzysztof Kozlowski
2016-06-02 6:18 ` Krzysztof Kozlowski
2016-06-02 13:27 ` Javier Martinez Canillas
2016-06-02 13:27 ` Javier Martinez Canillas
2016-06-01 14:53 ` [PATCH 1/3] dt-bindings: clock: Add watchdog and SSS clock IDs " Javier Martinez Canillas
2016-06-01 14:53 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7e99aad-f773-27c6-d554-ba30bc54b5f7@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.