From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Brad Larson <blarson@amd.com>, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, brad@pensando.io, brendan.higgins@linux.dev, briannorris@chromium.org, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, skhan@linuxfoundation.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, tonyhuang.sunplus@gmail.com, ulf.hansson@linaro.org, vaishnav.a@ti.com, will@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v9 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Date: Thu, 19 Jan 2023 08:47:02 +0100 [thread overview] Message-ID: <f85cdf27-7ea0-14a8-10b0-7a9ac137a040@linaro.org> (raw) In-Reply-To: <20230119035136.21603-3-blarson@amd.com> On 19/01/2023 04:51, Brad Larson wrote: > AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and > explicitly controls byte-lane enables. > > Signed-off-by: Brad Larson <blarson@amd.com> > > --- > > Changes since v6: > - Add reset-names and resets properties > - Add if/then on property amd,pensando-elba-sd4hc to set reg property > values for minItems and maxItems > > --- > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 28 ++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > index 8b1a0fdcb5e3..f7dd6f990f96 100644 > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > @@ -16,12 +16,14 @@ properties: > compatible: > items: > - enum: > + - amd,pensando-elba-sd4hc > - microchip,mpfs-sd4hc > - socionext,uniphier-sd4hc > - const: cdns,sd4hc > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > > interrupts: > maxItems: 1 > @@ -111,12 +113,36 @@ properties: > minimum: 0 > maximum: 0x7f > > + reset-names: > + items: > + - const: hw > + > + resets: > + description: > + optional. phandle to the system reset controller with line index Drop "optional" Drop "phandle to the" and rephrase it to describe physical reset line. Don't describe here DT syntax (phandle) but the hardware. What is expected to be here? > + for mmc hw reset line if exists. > + maxItems: 1 > + > required: > - compatible > - reg > - interrupts > - clocks > > +if: Move the allO from the top here and put it under it. Saves indentation soon. > + properties: > + compatible: > + const: amd,pensando-elba-sd4hc > +then: > + properties: > + reg: > + minItems: 2 > +else: > + properties: > + reg: > + minItems: 1 > + maxItems: 2 No, why do you suddenly allow two items on all variants? This was not described in your commit msg at all, so I expect here maxItems: 1. Also, unless your reset is applicable to all variants, resets: false and reset-names: false. > + > unevaluatedProperties: false > > examples: Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Brad Larson <blarson@amd.com>, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, brad@pensando.io, brendan.higgins@linux.dev, briannorris@chromium.org, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, skhan@linuxfoundation.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, tonyhuang.sunplus@gmail.com, ulf.hansson@linaro.org, vaishnav.a@ti.com, will@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v9 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Date: Thu, 19 Jan 2023 08:47:02 +0100 [thread overview] Message-ID: <f85cdf27-7ea0-14a8-10b0-7a9ac137a040@linaro.org> (raw) In-Reply-To: <20230119035136.21603-3-blarson@amd.com> On 19/01/2023 04:51, Brad Larson wrote: > AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and > explicitly controls byte-lane enables. > > Signed-off-by: Brad Larson <blarson@amd.com> > > --- > > Changes since v6: > - Add reset-names and resets properties > - Add if/then on property amd,pensando-elba-sd4hc to set reg property > values for minItems and maxItems > > --- > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 28 ++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > index 8b1a0fdcb5e3..f7dd6f990f96 100644 > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > @@ -16,12 +16,14 @@ properties: > compatible: > items: > - enum: > + - amd,pensando-elba-sd4hc > - microchip,mpfs-sd4hc > - socionext,uniphier-sd4hc > - const: cdns,sd4hc > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > > interrupts: > maxItems: 1 > @@ -111,12 +113,36 @@ properties: > minimum: 0 > maximum: 0x7f > > + reset-names: > + items: > + - const: hw > + > + resets: > + description: > + optional. phandle to the system reset controller with line index Drop "optional" Drop "phandle to the" and rephrase it to describe physical reset line. Don't describe here DT syntax (phandle) but the hardware. What is expected to be here? > + for mmc hw reset line if exists. > + maxItems: 1 > + > required: > - compatible > - reg > - interrupts > - clocks > > +if: Move the allO from the top here and put it under it. Saves indentation soon. > + properties: > + compatible: > + const: amd,pensando-elba-sd4hc > +then: > + properties: > + reg: > + minItems: 2 > +else: > + properties: > + reg: > + minItems: 1 > + maxItems: 2 No, why do you suddenly allow two items on all variants? This was not described in your commit msg at all, so I expect here maxItems: 1. Also, unless your reset is applicable to all variants, resets: false and reset-names: false. > + > unevaluatedProperties: false > > examples: Best regards, Krzysztof
next prev parent reply other threads:[~2023-01-19 7:48 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-19 3:51 [PATCH v9 00/15] Support AMD Pensando Elba SoC Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 01/15] dt-bindings: arm: add AMD Pensando boards Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 7:47 ` Krzysztof Kozlowski [this message] 2023-01-19 7:47 ` Krzysztof Kozlowski 2023-01-21 1:10 ` Brad Larson 2023-01-21 1:10 ` Brad Larson 2023-01-21 18:57 ` Krzysztof Kozlowski 2023-01-21 18:57 ` Krzysztof Kozlowski 2023-01-19 7:48 ` Krzysztof Kozlowski 2023-01-19 7:48 ` Krzysztof Kozlowski 2023-01-19 3:51 ` [PATCH v9 03/15] dt-bindings: spi: cdns: Add compatible for " Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 7:53 ` Krzysztof Kozlowski 2023-01-19 7:53 ` Krzysztof Kozlowski 2023-01-24 1:16 ` Brad Larson 2023-01-24 1:16 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 04/15] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 7:55 ` Krzysztof Kozlowski 2023-01-19 7:55 ` Krzysztof Kozlowski 2023-01-24 1:57 ` Brad Larson 2023-01-24 1:57 ` Brad Larson 2023-01-24 7:22 ` Krzysztof Kozlowski 2023-01-24 7:22 ` Krzysztof Kozlowski 2023-01-24 21:26 ` Brad Larson 2023-01-24 21:26 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 05/15] dt-bindings: mfd: syscon: Add amd,pensando-elba-syscon compatible Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 14:19 ` Lee Jones 2023-01-19 14:19 ` Lee Jones 2023-01-19 3:51 ` [PATCH v9 06/15] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando System Resource chip Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 7:58 ` Krzysztof Kozlowski 2023-01-19 7:58 ` Krzysztof Kozlowski 2023-01-26 2:59 ` Brad Larson 2023-01-26 2:59 ` Brad Larson 2023-01-19 14:17 ` Lee Jones 2023-01-19 14:17 ` Lee Jones 2023-01-19 3:51 ` [PATCH v9 07/15] MAINTAINERS: Add entry for AMD PENSANDO Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 08/15] arm64: Add config for AMD Pensando SoC platforms Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 09/15] arm64: dts: Add AMD Pensando Elba SoC support Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 10/15] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 11/15] spi: dw: Add support " Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 9:58 ` Andy Shevchenko 2023-01-19 9:58 ` Andy Shevchenko 2023-01-24 2:59 ` Brad Larson 2023-01-24 2:59 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 12/15] mmc: sdhci-cadence: Enable device specific override of writel() Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 13/15] mmc: sdhci-cadence: Add AMD Pensando Elba SoC support Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-02-02 9:43 ` Adrian Hunter 2023-02-02 9:43 ` Adrian Hunter 2023-01-19 3:51 ` [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 9:34 ` Philipp Zabel 2023-01-19 9:34 ` Philipp Zabel 2023-02-07 20:53 ` Brad Larson 2023-02-07 20:53 ` Brad Larson 2023-01-19 3:51 ` [PATCH v9 15/15] spi: pensando-sr: Add AMD Pensando SoC System Resource Brad Larson 2023-01-19 3:51 ` Brad Larson 2023-01-19 13:57 ` Mark Brown 2023-01-19 13:57 ` Mark Brown 2023-02-07 2:12 ` Brad Larson 2023-02-07 2:12 ` Brad Larson 2023-01-19 12:57 ` [PATCH v9 00/15] Support AMD Pensando Elba SoC Mark Brown 2023-01-19 12:57 ` Mark Brown 2023-01-24 3:21 ` Brad Larson 2023-01-24 3:21 ` Brad Larson -- strict thread matches above, loose matches on Subject: below -- 2023-01-19 3:39 Brad Larson 2023-01-19 3:39 ` [PATCH v9 02/15] dt-bindings: mmc: cdns: Add " Brad Larson 2023-01-19 3:39 ` Brad Larson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f85cdf27-7ea0-14a8-10b0-7a9ac137a040@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=adrian.hunter@intel.com \ --cc=alcooperx@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=blarson@amd.com \ --cc=brad@pensando.io \ --cc=brendan.higgins@linux.dev \ --cc=briannorris@chromium.org \ --cc=brijeshkumar.singh@amd.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=davidgow@google.com \ --cc=devicetree@vger.kernel.org \ --cc=fancer.lancer@gmail.com \ --cc=gerg@linux-m68k.org \ --cc=gsomlo@gmail.com \ --cc=krzk@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=p.yadav@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=piotrs@cadence.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=skhan@linuxfoundation.org \ --cc=suravee.suthikulpanit@amd.com \ --cc=thomas.lendacky@amd.com \ --cc=tonyhuang.sunplus@gmail.com \ --cc=ulf.hansson@linaro.org \ --cc=vaishnav.a@ti.com \ --cc=will@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.