From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Fabio Estevam <festevam@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Takashi Iwai <tiwai@suse.com>, YueHaibing <yuehaibing@huawei.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Daniel Baluta <daniel.baluta@nxp.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH] ASoC: SOF: sort out Kconfig, again
Date: Tue, 28 Apr 2020 17:15:40 -0500 [thread overview]
Message-ID: <f91c9a68-7641-beb8-a23e-bd1b9b8d0acb@linux.intel.com> (raw)
In-Reply-To: <CAK8P3a24whg2RhJE3Vf5u3EWy+wvFqhXdp7EQZuQx0shPsMARw@mail.gmail.com>
>> Thanks Arnd, do you mind sharing your config?
>
> https://pastebin.com/HRX5xi3R
will give it a try, thanks!
>> We noticed last week that
>> there's a depend/select confusion might be simpler to fix, see
>> https://github.com/thesofproject/linux/pull/2047/commits
>>
>> If I look at the first line I see a IMX_DSP=n which looks exactly like
>> what we wanted to fix.
>
> Yes, I think that fix addresses the build warning as well, but looking
> more closely I don't think it's what you want: If you do this on
> a config that has the IMX_DSP disabled, it would appear to the
> user that you have enabled the drivers, but the actual code is still
> disabled.
Are you sure? we added a select IMX_DSP, so not sure how it can be disabled?
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
YueHaibing <yuehaibing@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
sound-open-firmware@alsa-project.org,
Shawn Guo <shawnguo@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] ASoC: SOF: sort out Kconfig, again
Date: Tue, 28 Apr 2020 17:15:40 -0500 [thread overview]
Message-ID: <f91c9a68-7641-beb8-a23e-bd1b9b8d0acb@linux.intel.com> (raw)
In-Reply-To: <CAK8P3a24whg2RhJE3Vf5u3EWy+wvFqhXdp7EQZuQx0shPsMARw@mail.gmail.com>
>> Thanks Arnd, do you mind sharing your config?
>
> https://pastebin.com/HRX5xi3R
will give it a try, thanks!
>> We noticed last week that
>> there's a depend/select confusion might be simpler to fix, see
>> https://github.com/thesofproject/linux/pull/2047/commits
>>
>> If I look at the first line I see a IMX_DSP=n which looks exactly like
>> what we wanted to fix.
>
> Yes, I think that fix addresses the build warning as well, but looking
> more closely I don't think it's what you want: If you do this on
> a config that has the IMX_DSP disabled, it would appear to the
> user that you have enabled the drivers, but the actual code is still
> disabled.
Are you sure? we added a select IMX_DSP, so not sure how it can be disabled?
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
YueHaibing <yuehaibing@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
sound-open-firmware@alsa-project.org,
Shawn Guo <shawnguo@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] ASoC: SOF: sort out Kconfig, again
Date: Tue, 28 Apr 2020 17:15:40 -0500 [thread overview]
Message-ID: <f91c9a68-7641-beb8-a23e-bd1b9b8d0acb@linux.intel.com> (raw)
In-Reply-To: <CAK8P3a24whg2RhJE3Vf5u3EWy+wvFqhXdp7EQZuQx0shPsMARw@mail.gmail.com>
>> Thanks Arnd, do you mind sharing your config?
>
> https://pastebin.com/HRX5xi3R
will give it a try, thanks!
>> We noticed last week that
>> there's a depend/select confusion might be simpler to fix, see
>> https://github.com/thesofproject/linux/pull/2047/commits
>>
>> If I look at the first line I see a IMX_DSP=n which looks exactly like
>> what we wanted to fix.
>
> Yes, I think that fix addresses the build warning as well, but looking
> more closely I don't think it's what you want: If you do this on
> a config that has the IMX_DSP disabled, it would appear to the
> user that you have enabled the drivers, but the actual code is still
> disabled.
Are you sure? we added a select IMX_DSP, so not sure how it can be disabled?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 22:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:27 [PATCH] ASoC: SOF: sort out Kconfig, again Arnd Bergmann
2020-04-28 21:27 ` Arnd Bergmann
2020-04-28 21:27 ` Arnd Bergmann
2020-04-28 21:43 ` Pierre-Louis Bossart
2020-04-28 21:43 ` Pierre-Louis Bossart
2020-04-28 21:43 ` Pierre-Louis Bossart
2020-04-28 22:01 ` Arnd Bergmann
2020-04-28 22:01 ` Arnd Bergmann
2020-04-28 22:01 ` Arnd Bergmann
2020-04-28 22:15 ` Pierre-Louis Bossart [this message]
2020-04-28 22:15 ` Pierre-Louis Bossart
2020-04-28 22:15 ` Pierre-Louis Bossart
2020-04-28 23:00 ` Pierre-Louis Bossart
2020-04-28 23:00 ` Pierre-Louis Bossart
2020-04-28 23:00 ` Pierre-Louis Bossart
2020-04-29 8:21 ` Daniel Baluta
2020-04-29 8:21 ` Daniel Baluta
2020-04-29 8:21 ` Daniel Baluta
2020-04-29 8:24 ` Arnd Bergmann
2020-04-29 8:24 ` Arnd Bergmann
2020-04-29 8:24 ` Arnd Bergmann
2020-04-29 12:58 ` Mark Brown
2020-04-29 12:58 ` Mark Brown
2020-04-29 12:58 ` Mark Brown
2020-04-30 13:40 ` Mark Brown
2020-04-30 13:40 ` Mark Brown
2020-04-30 13:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f91c9a68-7641-beb8-a23e-bd1b9b8d0acb@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.