All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Jon Mason <jonmason@broadcom.com>, Oza Oza <oza.oza@broadcom.com>,
	JD Zheng <jiandong.zheng@broadcom.com>,
	Andy Gospodarek <gospo@broadcom.com>
Cc: linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: pcie-iproc: broken 2nd (& 3rd?) controller support by c3245a566400 ("PCI: iproc: Request host bridge window resources")
Date: Wed, 8 Mar 2017 13:56:35 +0100	[thread overview]
Message-ID: <faab6b85-58e8-3e62-8763-56a94b13fba1@gmail.com> (raw)

SGksCgpJIGp1c3QgdHJpZWQgdXBncmFkaW5nIEJDTTUzMDFYIGZyb20gNC40IHRvIDQuOSBhbmQg
bm90aWNlZCBJIGRvbid0IHNlZSBjYXJkCmNvbm5lY3RlZCB0byB0aGUgMm5kIGNvbnRyb2xsZXIu
CgpbICAgIDIuNTkzNTM0XSBwY2llX2lwcm9jX2JjbWEgYmNtYTA6NzogUENJIGhvc3QgYnJpZGdl
IHRvIGJ1cyAwMDAwOjAwClsgICAgMi41OTk3ODZdIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMg
cmVzb3VyY2UgW21lbSAweDA4MDAwMDAwLTB4MGZmZmZmZmZdClsgICAgMi42MDY2NjNdIHBjaWVf
aXByb2NfYmNtYSBiY21hMDo3OiBsaW5rOiBVUApbICAgIDIuNjExMzE2XSBQQ0k6IGJ1czA6IEZh
c3QgYmFjayB0byBiYWNrIHRyYW5zZmVycyBkaXNhYmxlZApbICAgIDIuNjE2ODk5XSBwY2kgMDAw
MDowMDowMC4wOiBicmlkZ2UgY29uZmlndXJhdGlvbiBpbnZhbGlkIChbYnVzIDAwLTAwXSksIHJl
Y29uZmlndXJpbmcKWyAgICAyLjYyNTM5NV0gUENJOiBidXMxOiBGYXN0IGJhY2sgdG8gYmFjayB0
cmFuc2ZlcnMgZGlzYWJsZWQKWyAgICAyLjYzMTAxMV0gcGNpIDAwMDA6MDA6MDAuMDogQkFSIDg6
IGFzc2lnbmVkIFttZW0gMHgwODAwMDAwMC0weDA4MGZmZmZmXQpbICAgIDIuNjM3Nzk1XSBwY2kg
MDAwMDowMTowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDA4MDAwMDAwLTB4MDgwMDdmZmYg
NjRiaXRdClsgICAgMi42NDUwOTFdIHBjaSAwMDAwOjAwOjAwLjA6IFBDSSBicmlkZ2UgdG8gW2J1
cyAwMV0KWyAgICAyLjY1MDA0Ml0gcGNpIDAwMDA6MDA6MDAuMDogICBicmlkZ2Ugd2luZG93IFtt
ZW0gMHgwODAwMDAwMC0weDA4MGZmZmZmXQoKWyAgICAyLjY1NzE5OV0gcGNpZV9pcHJvY19iY21h
IGJjbWEwOjg6IHJlc291cmNlIGNvbGxpc2lvbjogW21lbSAweDQwMDAwMDAwLTB4NDdmZmZmZmZd
IGNvbmZsaWN0cyB3aXRoIFBDSWUgTUVNIHNwYWNlIFttZW0gMHg0MDAwMDAwMC0weDQ3ZmZmZmZm
XQpbICAgIDIuNjY5OTQ2XSBwY2llX2lwcm9jX2JjbWEgYmNtYTA6ODogUENJZSBjb250cm9sbGVy
IHNldHVwIGZhaWxlZApbICAgIDIuNjc2MDMyXSBwY2llX2lwcm9jX2JjbWE6IHByb2JlIG9mIGJj
bWEwOjggZmFpbGVkIHdpdGggZXJyb3IgLTE2CgoKVGhpcyB1c2VkIHRvIHdvcmsgd2l0aCBvbGRl
ciBrZXJuZWxzIGJlY2F1c2UgdGhlcmUgd2Fzbid0IGFueSBjb2xsaXNpb24gY2hlY2s6CgpbICAg
IDIuNTg3MTE3XSBwY2llX2lwcm9jX2JjbWEgYmNtYTA6NzogUENJIGhvc3QgYnJpZGdlIHRvIGJ1
cyAwMDAwOjAwClsgICAgMi41OTMzNzhdIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3Vy
Y2UgW21lbSAweDA4MDAwMDAwLTB4MGZmZmZmZmZdClsgICAgMi42MDAyNTZdIHBjaWVfaXByb2Nf
YmNtYSBiY21hMDo3OiBsaW5rOiBVUApbICAgIDIuNjA0ODg4XSBQQ0k6IGJ1czA6IEZhc3QgYmFj
ayB0byBiYWNrIHRyYW5zZmVycyBkaXNhYmxlZApbICAgIDIuNjEwNDc0XSBwY2kgMDAwMDowMDow
MC4wOiBicmlkZ2UgY29uZmlndXJhdGlvbiBpbnZhbGlkIChbYnVzIDAwLTAwXSksIHJlY29uZmln
dXJpbmcKWyAgICAyLjYxODk3M10gUENJOiBidXMxOiBGYXN0IGJhY2sgdG8gYmFjayB0cmFuc2Zl
cnMgZGlzYWJsZWQKWyAgICAyLjYyNDU5MV0gcGNpIDAwMDA6MDA6MDAuMDogQkFSIDg6IGFzc2ln
bmVkIFttZW0gMHgwODAwMDAwMC0weDA4MGZmZmZmXQpbICAgIDIuNjMxMzgyXSBwY2kgMDAwMDow
MTowMC4wOiBCQVIgMDogYXNzaWduZWQgW21lbSAweDA4MDAwMDAwLTB4MDgwMDdmZmYgNjRiaXRd
ClsgICAgMi42Mzg2ODZdIHBjaSAwMDAwOjAwOjAwLjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0K
WyAgICAyLjY0MzYzM10gcGNpIDAwMDA6MDA6MDAuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHgw
ODAwMDAwMC0weDA4MGZmZmZmXQoKWyAgICAyLjc3NzExOF0gcGNpZV9pcHJvY19iY21hIGJjbWEw
Ojg6IFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwMTowMApbICAgIDIuNzgzMzY3XSBwY2lfYnVz
IDAwMDE6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHg0MDAwMDAwMC0weDQ3ZmZmZmZmXQpb
ICAgIDIuNzkwMjQ1XSBwY2llX2lwcm9jX2JjbWEgYmNtYTA6ODogbGluazogVVAKWyAgICAyLjc5
NDg2Ml0gUENJOiBidXMwOiBGYXN0IGJhY2sgdG8gYmFjayB0cmFuc2ZlcnMgZGlzYWJsZWQKWyAg
ICAyLjgwMDQ1Ml0gcGNpIDAwMDE6MDA6MDAuMDogYnJpZGdlIGNvbmZpZ3VyYXRpb24gaW52YWxp
ZCAoW2J1cyAwMC0wMF0pLCByZWNvbmZpZ3VyaW5nClsgICAgMi44MDg5NDZdIFBDSTogYnVzMTog
RmFzdCBiYWNrIHRvIGJhY2sgdHJhbnNmZXJzIGRpc2FibGVkClsgICAgMi44MTQ1NThdIHBjaSAw
MDAxOjAwOjAwLjA6IEJBUiA4OiBhc3NpZ25lZCBbbWVtIDB4NDAwMDAwMDAtMHg0MDBmZmZmZl0K
WyAgICAyLjgyMTM1Ml0gcGNpIDAwMDE6MDE6MDAuMDogQkFSIDA6IGFzc2lnbmVkIFttZW0gMHg0
MDAwMDAwMC0weDQwMDA3ZmZmIDY0Yml0XQpbICAgIDIuODI4NjUwXSBwY2kgMDAwMTowMDowMC4w
OiBQQ0kgYnJpZGdlIHRvIFtidXMgMDFdClsgICAgMi44MzM2MDBdIHBjaSAwMDAxOjAwOjAwLjA6
ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4NDAwMDAwMDAtMHg0MDBmZmZmZl0KCgpJIGd1ZXNzIHRo
ZSBjaGVjayBpcyBPSyBhZnRlciBhbGwgYW5kIHRoZSByZWFsIHByb2JsZW0gaXMgaXByb2MgZHJp
dmVyIGFzc2lnbmluZwp0aGUgc2FtZSByZXNvdXJjZS4KCkJyb2FkY29tIHRlYW06IGNvdWxkIHlv
dSB0YWtlIGEgbG9vayBhdCB0aGlzLCBwbGVhc2U/CgotLSAKUmFmYcWCCgpfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp
bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz
LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==

WARNING: multiple messages have this Message-ID (diff)
From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: pcie-iproc: broken 2nd (& 3rd?) controller support by c3245a566400 ("PCI: iproc: Request host bridge window resources")
Date: Wed, 8 Mar 2017 13:56:35 +0100	[thread overview]
Message-ID: <faab6b85-58e8-3e62-8763-56a94b13fba1@gmail.com> (raw)

Hi,

I just tried upgrading BCM5301X from 4.4 to 4.9 and noticed I don't see card
connected to the 2nd controller.

[    2.593534] pcie_iproc_bcma bcma0:7: PCI host bridge to bus 0000:00
[    2.599786] pci_bus 0000:00: root bus resource [mem 0x08000000-0x0fffffff]
[    2.606663] pcie_iproc_bcma bcma0:7: link: UP
[    2.611316] PCI: bus0: Fast back to back transfers disabled
[    2.616899] pci 0000:00:00.0: bridge configuration invalid ([bus 00-00]), reconfiguring
[    2.625395] PCI: bus1: Fast back to back transfers disabled
[    2.631011] pci 0000:00:00.0: BAR 8: assigned [mem 0x08000000-0x080fffff]
[    2.637795] pci 0000:01:00.0: BAR 0: assigned [mem 0x08000000-0x08007fff 64bit]
[    2.645091] pci 0000:00:00.0: PCI bridge to [bus 01]
[    2.650042] pci 0000:00:00.0:   bridge window [mem 0x08000000-0x080fffff]

[    2.657199] pcie_iproc_bcma bcma0:8: resource collision: [mem 0x40000000-0x47ffffff] conflicts with PCIe MEM space [mem 0x40000000-0x47ffffff]
[    2.669946] pcie_iproc_bcma bcma0:8: PCIe controller setup failed
[    2.676032] pcie_iproc_bcma: probe of bcma0:8 failed with error -16


This used to work with older kernels because there wasn't any collision check:

[    2.587117] pcie_iproc_bcma bcma0:7: PCI host bridge to bus 0000:00
[    2.593378] pci_bus 0000:00: root bus resource [mem 0x08000000-0x0fffffff]
[    2.600256] pcie_iproc_bcma bcma0:7: link: UP
[    2.604888] PCI: bus0: Fast back to back transfers disabled
[    2.610474] pci 0000:00:00.0: bridge configuration invalid ([bus 00-00]), reconfiguring
[    2.618973] PCI: bus1: Fast back to back transfers disabled
[    2.624591] pci 0000:00:00.0: BAR 8: assigned [mem 0x08000000-0x080fffff]
[    2.631382] pci 0000:01:00.0: BAR 0: assigned [mem 0x08000000-0x08007fff 64bit]
[    2.638686] pci 0000:00:00.0: PCI bridge to [bus 01]
[    2.643633] pci 0000:00:00.0:   bridge window [mem 0x08000000-0x080fffff]

[    2.777118] pcie_iproc_bcma bcma0:8: PCI host bridge to bus 0001:00
[    2.783367] pci_bus 0001:00: root bus resource [mem 0x40000000-0x47ffffff]
[    2.790245] pcie_iproc_bcma bcma0:8: link: UP
[    2.794862] PCI: bus0: Fast back to back transfers disabled
[    2.800452] pci 0001:00:00.0: bridge configuration invalid ([bus 00-00]), reconfiguring
[    2.808946] PCI: bus1: Fast back to back transfers disabled
[    2.814558] pci 0001:00:00.0: BAR 8: assigned [mem 0x40000000-0x400fffff]
[    2.821352] pci 0001:01:00.0: BAR 0: assigned [mem 0x40000000-0x40007fff 64bit]
[    2.828650] pci 0001:00:00.0: PCI bridge to [bus 01]
[    2.833600] pci 0001:00:00.0:   bridge window [mem 0x40000000-0x400fffff]


I guess the check is OK after all and the real problem is iproc driver assigning
the same resource.

Broadcom team: could you take a look at this, please?

-- 
Rafa?

             reply	other threads:[~2017-03-08 12:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 12:56 Rafał Miłecki [this message]
2017-03-08 12:56 ` pcie-iproc: broken 2nd (& 3rd?) controller support by c3245a566400 ("PCI: iproc: Request host bridge window resources") Rafał Miłecki
2017-03-08 17:22 ` Ray Jui
2017-03-08 23:28   ` Rafał Miłecki
2017-03-08 23:28     ` Rafał Miłecki
2017-03-09  0:31     ` Ray Jui
2017-03-09  7:39 ` Rafał Miłecki
2017-03-09  7:39   ` Rafał Miłecki
2017-03-09 18:22   ` Bjorn Helgaas
2017-03-09 18:22     ` Bjorn Helgaas
2017-03-10 16:02     ` Rafał Miłecki
2017-03-10 16:02       ` Rafał Miłecki
2017-03-10 17:21       ` Ray Jui
2017-03-10 17:21         ` Ray Jui
2017-03-10 17:47       ` Bjorn Helgaas
2017-03-10 17:47         ` Bjorn Helgaas
2017-03-10 21:11         ` Rafał Miłecki
2017-03-10 21:11           ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=faab6b85-58e8-3e62-8763-56a94b13fba1@gmail.com \
    --to=zajec5@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=gospo@broadcom.com \
    --cc=jiandong.zheng@broadcom.com \
    --cc=jonmason@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=oza.oza@broadcom.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.