From: Hans Verkuil <hverkuil@xs4all.nl>
To: Helen Koike <helen.koike@collabora.com>,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, eddie.cai.linux@gmail.com,
mchehab@kernel.org, heiko@sntech.de, jeffy.chen@rock-chips.com,
zyc@rock-chips.com, linux-kernel@vger.kernel.org,
tfiga@chromium.org, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
kernel@collabora.com, ezequiel@collabora.com,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, zhengsq@rock-chips.com
Subject: Re: [PATCH v8 00/14] Rockchip ISP1 Driver
Date: Wed, 31 Jul 2019 06:33:10 +0200 [thread overview]
Message-ID: <fb1327fb-0903-ce62-4eea-94b81f599b62@xs4all.nl> (raw)
In-Reply-To: <74bb0ba1-2859-39ff-d946-129a440ba150@xs4all.nl>
On 7/31/19 6:29 AM, Hans Verkuil wrote:
> On 7/31/19 2:08 AM, Helen Koike wrote:
>>
>>
>> On 7/30/19 5:50 PM, Helen Koike wrote:
>>>
>>>
>>> On 7/30/19 5:15 PM, Hans Verkuil wrote:
>>>> On 7/30/19 8:42 PM, Helen Koike wrote:
>>>>> Hello,
>>>>>
>>>>> I'm re-sending a new version of ISP(Camera) v4l2 driver for rockchip
>>>>> rk3399 SoC.
>>>>>
>>>>> I didn't change much from the last version, just applying the
>>>>> suggestions made in the previous one.
>>>>>
>>>>> This patchset is also available at:
>>>>> https://gitlab.collabora.com/koike/linux/tree/rockchip/isp/v8
>>>>>
>>>>> Libcamera patched to work with this version:
>>>>> https://gitlab.collabora.com/koike/libcamera
>>>>> (also sent to the mailing list)
>>>>>
>>>>> I tested on the rockpi 4 with a rpi v1.3 sensor and also with the
>>>>> Scarlet Chromebook.
>>>>>
>>>>> Known issues (same as in v7):
>>>>> -------------
>>>>> - Reloading the module doesn't work (there is some missing cleanup when
>>>>> unloading)
>>>>> - When capturing in bayer format, changing the size doesn't seem to
>>>>> affect the image.
>>>>> - crop needs more tests
>>>>> - v4l2-compliance error:
>>>>> fail: v4l2-test-controls.cpp(824): subscribe event for control 'Image Processing Controls' failed
>>>>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
>>>>
>>>> Can you mail me the full v4l2-compliance output?
>>>
>>> Sure, please check here: http://ix.io/1Q5u
>>> I updated v4l-utils with the latest version and I re-ran bootstrap/configure/make,
>>> but for some reason the hash from the link above is not the latest commit, probably some
>>> old configuration somewhere. I'll resend this log as soon as I get v4l2-compliance
>>> properly updated.
>>
>> Please see the output of v4l2-compliance here with an updated v4l-utils: http://ix.io/1Q6A
>
> So this FAIL is for /dev/v4l-subdev0 (rkisp1-isp-subdev).
>
> What is weird that this subdev does not appear to have controls at all.
>
> What is the output of 'v4l2-ctl -d /dev/v4l-subdev0 -l'? And if it lists
> controls, then why?
>
> If you run 'v4l2-compliance -u /dev/v4l-subdev0', do you get a fail as
> well?
I see the same issue with v4l-subdev1, but I see no "Media Driver Info"
in the v4l2-compliance output for that subdev. That's strange. It would
be good to know why that's happening.
Regards,
Hans
>
> BTW, note that struct rkisp1_isp_subdev has a ctrl_handler field that
> isn't used at all.
>
> Regards,
>
> Hans
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Helen Koike <helen.koike@collabora.com>,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, eddie.cai.linux@gmail.com,
kernel@collabora.com, heiko@sntech.de, zhengsq@rock-chips.com,
jeffy.chen@rock-chips.com, zyc@rock-chips.com,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, mchehab@kernel.org,
ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v8 00/14] Rockchip ISP1 Driver
Date: Wed, 31 Jul 2019 06:33:10 +0200 [thread overview]
Message-ID: <fb1327fb-0903-ce62-4eea-94b81f599b62@xs4all.nl> (raw)
In-Reply-To: <74bb0ba1-2859-39ff-d946-129a440ba150@xs4all.nl>
On 7/31/19 6:29 AM, Hans Verkuil wrote:
> On 7/31/19 2:08 AM, Helen Koike wrote:
>>
>>
>> On 7/30/19 5:50 PM, Helen Koike wrote:
>>>
>>>
>>> On 7/30/19 5:15 PM, Hans Verkuil wrote:
>>>> On 7/30/19 8:42 PM, Helen Koike wrote:
>>>>> Hello,
>>>>>
>>>>> I'm re-sending a new version of ISP(Camera) v4l2 driver for rockchip
>>>>> rk3399 SoC.
>>>>>
>>>>> I didn't change much from the last version, just applying the
>>>>> suggestions made in the previous one.
>>>>>
>>>>> This patchset is also available at:
>>>>> https://gitlab.collabora.com/koike/linux/tree/rockchip/isp/v8
>>>>>
>>>>> Libcamera patched to work with this version:
>>>>> https://gitlab.collabora.com/koike/libcamera
>>>>> (also sent to the mailing list)
>>>>>
>>>>> I tested on the rockpi 4 with a rpi v1.3 sensor and also with the
>>>>> Scarlet Chromebook.
>>>>>
>>>>> Known issues (same as in v7):
>>>>> -------------
>>>>> - Reloading the module doesn't work (there is some missing cleanup when
>>>>> unloading)
>>>>> - When capturing in bayer format, changing the size doesn't seem to
>>>>> affect the image.
>>>>> - crop needs more tests
>>>>> - v4l2-compliance error:
>>>>> fail: v4l2-test-controls.cpp(824): subscribe event for control 'Image Processing Controls' failed
>>>>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
>>>>
>>>> Can you mail me the full v4l2-compliance output?
>>>
>>> Sure, please check here: http://ix.io/1Q5u
>>> I updated v4l-utils with the latest version and I re-ran bootstrap/configure/make,
>>> but for some reason the hash from the link above is not the latest commit, probably some
>>> old configuration somewhere. I'll resend this log as soon as I get v4l2-compliance
>>> properly updated.
>>
>> Please see the output of v4l2-compliance here with an updated v4l-utils: http://ix.io/1Q6A
>
> So this FAIL is for /dev/v4l-subdev0 (rkisp1-isp-subdev).
>
> What is weird that this subdev does not appear to have controls at all.
>
> What is the output of 'v4l2-ctl -d /dev/v4l-subdev0 -l'? And if it lists
> controls, then why?
>
> If you run 'v4l2-compliance -u /dev/v4l-subdev0', do you get a fail as
> well?
I see the same issue with v4l-subdev1, but I see no "Media Driver Info"
in the v4l2-compliance output for that subdev. That's strange. It would
be good to know why that's happening.
Regards,
Hans
>
> BTW, note that struct rkisp1_isp_subdev has a ctrl_handler field that
> isn't used at all.
>
> Regards,
>
> Hans
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-31 4:33 UTC|newest]
Thread overview: 173+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 18:42 [PATCH v8 00/14] Rockchip ISP1 Driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-07-30 18:42 ` [PATCH v8 01/14] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-15 13:30 ` Laurent Pinchart
2019-08-15 13:30 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 02/14] media: doc: add document for " Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-07 13:09 ` Sakari Ailus
2019-08-07 13:09 ` Sakari Ailus
2019-08-15 13:51 ` Laurent Pinchart
2019-08-15 13:51 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 03/14] media: rkisp1: Add user space ABI definitions Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-15 18:46 ` Laurent Pinchart
2019-08-15 18:46 ` Laurent Pinchart
2020-07-10 12:59 ` Dafna Hirschfeld
2020-07-10 12:59 ` Dafna Hirschfeld
2020-07-10 12:59 ` Dafna Hirschfeld
2020-07-10 13:36 ` Laurent Pinchart
2020-07-10 13:36 ` Laurent Pinchart
2020-07-10 13:36 ` Laurent Pinchart
2020-07-10 14:30 ` Dafna Hirschfeld
2020-07-10 14:30 ` Dafna Hirschfeld
2019-07-30 18:42 ` [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-07 13:05 ` Sakari Ailus
2019-08-07 13:05 ` Sakari Ailus
2019-08-07 13:37 ` Helen Koike
2019-08-07 13:37 ` Helen Koike
2019-08-15 17:54 ` Laurent Pinchart
2019-08-15 17:54 ` Laurent Pinchart
2019-08-15 18:26 ` Heiko Stübner
2019-08-15 18:26 ` Heiko Stübner
2019-08-21 21:46 ` Helen Koike
2019-08-21 21:46 ` Helen Koike
2019-08-22 2:32 ` Laurent Pinchart
2019-08-22 2:32 ` Laurent Pinchart
2019-08-22 2:32 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-06 18:51 ` Helen Koike
2019-08-06 18:51 ` Helen Koike
2019-08-07 10:39 ` Hans Verkuil
2019-08-07 10:39 ` Hans Verkuil
2019-08-15 19:35 ` Laurent Pinchart
2019-08-15 19:35 ` Laurent Pinchart
2020-03-25 6:34 ` Dafna Hirschfeld
2020-03-25 6:34 ` Dafna Hirschfeld
2020-03-25 7:11 ` Laurent Pinchart
2020-03-25 7:11 ` Laurent Pinchart
2020-03-25 8:51 ` Dafna Hirschfeld
2020-03-25 8:51 ` Dafna Hirschfeld
2020-03-25 9:11 ` Laurent Pinchart
2020-03-25 9:11 ` Laurent Pinchart
2019-08-08 9:14 ` Sakari Ailus
2019-08-08 9:14 ` Sakari Ailus
2019-08-15 0:58 ` Helen Koike
2019-08-15 0:58 ` Helen Koike
2019-08-15 0:58 ` Helen Koike
2019-08-15 8:24 ` Sakari Ailus
2019-08-15 8:24 ` Sakari Ailus
2019-08-15 10:29 ` Tomasz Figa
2019-08-15 10:29 ` Tomasz Figa
2019-08-15 10:29 ` Tomasz Figa
2019-08-15 10:45 ` Sakari Ailus
2019-08-15 10:45 ` Sakari Ailus
2019-08-15 10:45 ` Sakari Ailus
2019-08-15 13:17 ` Sakari Ailus
2019-08-15 13:17 ` Sakari Ailus
2020-01-31 19:38 ` Dafna Hirschfeld
2020-01-31 19:38 ` Dafna Hirschfeld
2020-02-12 21:13 ` Sakari Ailus
2020-02-12 21:13 ` Sakari Ailus
2020-02-13 12:50 ` Dafna Hirschfeld
2020-02-13 12:50 ` Dafna Hirschfeld
2019-08-16 0:13 ` Laurent Pinchart
2019-08-16 0:13 ` Laurent Pinchart
2020-07-11 11:04 ` Dafna Hirschfeld
2020-07-11 11:04 ` Dafna Hirschfeld
2020-07-17 7:46 ` Dafna Hirschfeld
2020-07-17 7:46 ` Dafna Hirschfeld
2020-07-22 16:01 ` Tomasz Figa
2020-07-22 16:01 ` Tomasz Figa
2020-07-22 15:24 ` Tomasz Figa
2020-07-22 15:24 ` Tomasz Figa
2020-07-22 15:24 ` Tomasz Figa
2020-07-22 16:30 ` Laurent Pinchart
2020-07-22 16:30 ` Laurent Pinchart
2020-07-22 16:30 ` Laurent Pinchart
2020-07-22 17:12 ` Tomasz Figa
2020-07-22 17:12 ` Tomasz Figa
2020-07-22 17:12 ` Tomasz Figa
2020-07-22 17:50 ` Laurent Pinchart
2020-07-22 17:50 ` Laurent Pinchart
2020-07-22 17:50 ` Laurent Pinchart
2020-08-05 21:10 ` Dafna Hirschfeld
2020-08-05 21:10 ` Dafna Hirschfeld
2020-08-06 9:21 ` Dafna Hirschfeld
2020-08-06 9:21 ` Dafna Hirschfeld
2020-08-06 12:22 ` Tomasz Figa
2020-08-06 12:22 ` Tomasz Figa
2020-08-06 12:22 ` Tomasz Figa
2020-08-07 16:08 ` Dafna Hirschfeld
2020-08-07 16:08 ` Dafna Hirschfeld
2020-08-07 16:08 ` Dafna Hirschfeld
2020-08-07 16:08 ` Dafna Hirschfeld
2020-08-13 6:17 ` Dafna Hirschfeld
2020-08-13 6:17 ` Dafna Hirschfeld
2020-08-13 6:17 ` Dafna Hirschfeld
2020-08-13 6:17 ` Dafna Hirschfeld
2020-08-06 12:08 ` Tomasz Figa
2020-08-06 12:08 ` Tomasz Figa
2020-08-06 12:08 ` Tomasz Figa
2020-08-07 16:02 ` Dafna Hirschfeld
2020-08-07 16:02 ` Dafna Hirschfeld
2020-08-07 16:02 ` Dafna Hirschfeld
2020-08-07 16:02 ` Dafna Hirschfeld
2019-07-30 18:42 ` [PATCH v8 06/14] media: rkisp1: add ISP1 statistics driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-08 9:37 ` Sakari Ailus
2019-08-08 9:37 ` Sakari Ailus
2019-07-30 18:42 ` [PATCH v8 07/14] media: rkisp1: add ISP1 params driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-07-30 18:42 ` [PATCH v8 08/14] media: rkisp1: add capture device driver Helen Koike
2019-07-30 18:42 ` [PATCH v8 09/14] media: rkisp1: add rockchip isp1 core driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-07 15:27 ` Sakari Ailus
2019-08-07 15:27 ` Sakari Ailus
2019-08-08 21:59 ` Helen Koike
2019-08-08 21:59 ` Helen Koike
2019-08-09 12:05 ` Sakari Ailus
2019-08-09 12:05 ` Sakari Ailus
2019-08-07 15:36 ` Sakari Ailus
2019-08-07 15:36 ` Sakari Ailus
2019-07-30 18:42 ` [PATCH v8 10/14] dt-bindings: Document the Rockchip ISP1 bindings Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-16 0:21 ` Laurent Pinchart
2019-08-16 0:21 ` Laurent Pinchart
2019-08-16 0:21 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 11/14] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-15 18:14 ` Laurent Pinchart
2019-08-15 18:14 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 12/14] arm64: dts: rockchip: add isp0 node for rk3399 Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-07-30 18:42 ` [PATCH v8 13/14] arm64: dts: rockchip: add rx0 mipi-phy " Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-07-30 18:42 ` [PATCH v8 14/14] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike
2019-07-30 18:42 ` Helen Koike
2019-08-15 13:56 ` Laurent Pinchart
2019-08-15 13:56 ` Laurent Pinchart
2019-07-30 20:15 ` [PATCH v8 00/14] Rockchip ISP1 Driver Hans Verkuil
2019-07-30 20:15 ` Hans Verkuil
2019-07-30 20:50 ` Helen Koike
2019-07-30 20:50 ` Helen Koike
2019-07-31 0:08 ` Helen Koike
2019-07-31 0:08 ` Helen Koike
2019-07-31 4:29 ` Hans Verkuil
2019-07-31 4:29 ` Hans Verkuil
2019-07-31 4:33 ` Hans Verkuil [this message]
2019-07-31 4:33 ` Hans Verkuil
2019-07-31 4:55 ` Hans Verkuil
2019-07-31 4:55 ` Hans Verkuil
2019-07-31 4:55 ` Hans Verkuil
2019-07-31 14:42 ` Helen Koike
2019-07-31 14:42 ` Helen Koike
2019-08-07 15:37 ` Sakari Ailus
2019-08-07 15:37 ` Sakari Ailus
2019-08-07 17:57 ` Helen Koike
2019-08-07 17:57 ` Helen Koike
2019-08-09 18:45 ` Manivannan Sadhasivam
2019-08-09 18:45 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1327fb-0903-ce62-4eea-94b81f599b62@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.