From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Rob Clark <robdclark@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: "Intel Graphics Development" <Intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Christian König" <christian.koenig@amd.com>, "Chris Healy" <cphealy@gmail.com>, "David M Nieto" <David.Nieto@amd.com> Subject: Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification Date: Tue, 25 Jan 2022 10:24:35 +0000 [thread overview] Message-ID: <fb6f1a2c-6e23-cfdf-2ce5-80209a005227@linux.intel.com> (raw) In-Reply-To: <423c8ff1-3a4b-3e69-8561-3056c7d2d20f@linux.intel.com> On 21/01/2022 11:50, Tvrtko Ursulin wrote: > On 20/01/2022 16:44, Rob Clark wrote: [snip] >> If there is a tool somewhere that displays this info, that would be >> useful for testing my implementation. > > I have a patch to Intel specific intel_gpu_top (see > https://patchwork.freedesktop.org/patch/468491/?series=98555&rev=1). > I'll have a look to see how much work would it be to extract common bits > into a library and write a quick agnostic tool using it. I factored out some code from intel_gpu_top in a quick and dirty attempt to make it generic and made a very rudimentary tools/gputop: https://cgit.freedesktop.org/~tursulin/intel-gpu-tools/log/?h=gputop If you manage to export the right fdinfo tags (basically https://patchwork.freedesktop.org/patch/468502/?series=92574&rev=6)*, with the only local addition I have being the optional "drm-engine-capacity-<str>: <uint>" tag, we may get lucky and tool might even work. Let me know when you try. If it will work you should see something like this: DRM minor 0 PID NAME render copy video 3838 kwin_x11 |█ || || || | 327056 mpv | || ||▌ || | 327056 mpv |▌ || || || | 1 systemd |▍ || || || | 3884 plasmashell | || || || | 4794 krunner | || || || | 4836 thunderbird | || || || | 296733 GeckoMain | || || || | Regards, Tvrtko *) Or for more reference this is how the i915 output looks like: $ sudo cat /proc/7296/fdinfo/10 pos: 0 flags: 02100002 mnt_id: 26 ino: 501 drm-driver: i915 drm-pdev: 0000:00:02.0 drm-client-id: 22 drm-engine-render: 196329331 ns drm-engine-copy: 0 ns drm-engine-video: 0 ns drm-engine-capacity-video: 2 drm-engine-video-enhance: 0 ns P.S. There is no AMD support in the current code, or nothing for memory either. Both can be added later.
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Rob Clark <robdclark@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: "Intel Graphics Development" <Intel-gfx@lists.freedesktop.org>, "Daniel Stone" <daniel@fooishbar.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Christian König" <christian.koenig@amd.com>, "Chris Healy" <cphealy@gmail.com>, "David M Nieto" <David.Nieto@amd.com> Subject: Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification Date: Tue, 25 Jan 2022 10:24:35 +0000 [thread overview] Message-ID: <fb6f1a2c-6e23-cfdf-2ce5-80209a005227@linux.intel.com> (raw) In-Reply-To: <423c8ff1-3a4b-3e69-8561-3056c7d2d20f@linux.intel.com> On 21/01/2022 11:50, Tvrtko Ursulin wrote: > On 20/01/2022 16:44, Rob Clark wrote: [snip] >> If there is a tool somewhere that displays this info, that would be >> useful for testing my implementation. > > I have a patch to Intel specific intel_gpu_top (see > https://patchwork.freedesktop.org/patch/468491/?series=98555&rev=1). > I'll have a look to see how much work would it be to extract common bits > into a library and write a quick agnostic tool using it. I factored out some code from intel_gpu_top in a quick and dirty attempt to make it generic and made a very rudimentary tools/gputop: https://cgit.freedesktop.org/~tursulin/intel-gpu-tools/log/?h=gputop If you manage to export the right fdinfo tags (basically https://patchwork.freedesktop.org/patch/468502/?series=92574&rev=6)*, with the only local addition I have being the optional "drm-engine-capacity-<str>: <uint>" tag, we may get lucky and tool might even work. Let me know when you try. If it will work you should see something like this: DRM minor 0 PID NAME render copy video 3838 kwin_x11 |█ || || || | 327056 mpv | || ||▌ || | 327056 mpv |▌ || || || | 1 systemd |▍ || || || | 3884 plasmashell | || || || | 4794 krunner | || || || | 4836 thunderbird | || || || | 296733 GeckoMain | || || || | Regards, Tvrtko *) Or for more reference this is how the i915 output looks like: $ sudo cat /proc/7296/fdinfo/10 pos: 0 flags: 02100002 mnt_id: 26 ino: 501 drm-driver: i915 drm-pdev: 0000:00:02.0 drm-client-id: 22 drm-engine-render: 196329331 ns drm-engine-copy: 0 ns drm-engine-video: 0 ns drm-engine-capacity-video: 2 drm-engine-video-enhance: 0 ns P.S. There is no AMD support in the current code, or nothing for memory either. Both can be added later.
next prev parent reply other threads:[~2022-01-25 10:24 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-06 16:55 [PATCH 0/7] Per client GPU stats Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 1/7] drm/i915: Explicitly track DRM clients Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 2/7] drm/i915: Make GEM contexts " Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 3/7] drm/i915: Track runtime spent in closed and unreachable GEM contexts Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 4/7] drm/i915: Track all user contexts per client Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 5/7] drm/i915: Track context current active time Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 6/7] drm: Document fdinfo format specification Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-19 15:08 ` Daniel Vetter 2022-01-19 15:08 ` [Intel-gfx] " Daniel Vetter 2022-01-20 10:30 ` Tvrtko Ursulin 2022-01-20 10:30 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-20 16:44 ` Rob Clark 2022-01-20 16:44 ` Rob Clark 2022-01-21 11:50 ` Tvrtko Ursulin 2022-01-21 11:50 ` Tvrtko Ursulin 2022-01-25 10:24 ` Tvrtko Ursulin [this message] 2022-01-25 10:24 ` Tvrtko Ursulin 2022-01-25 10:36 ` Christian König 2022-01-25 10:36 ` Christian König 2022-02-21 11:14 ` Tvrtko Ursulin 2022-02-21 11:14 ` Tvrtko Ursulin 2022-01-06 16:55 ` [PATCH 7/7] drm/i915: Expose client engine utilisation via fdinfo Tvrtko Ursulin 2022-01-06 16:55 ` [Intel-gfx] " Tvrtko Ursulin 2022-02-19 0:51 ` Umesh Nerlige Ramappa 2022-02-19 0:51 ` [Intel-gfx] " Umesh Nerlige Ramappa 2022-02-22 12:31 ` Tvrtko Ursulin 2022-02-22 12:31 ` [Intel-gfx] " Tvrtko Ursulin 2022-01-06 18:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client GPU stats (rev6) Patchwork 2022-01-06 18:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-01-06 18:20 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2022-01-06 18:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-01-07 14:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-12-03 15:49 [PATCH 0/7] Per client GPU stats Tvrtko Ursulin 2021-12-03 15:49 ` [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification Tvrtko Ursulin 2021-09-22 15:51 [PATCH 0/7] Per client GPU stats Tvrtko Ursulin 2021-09-22 15:51 ` [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification Tvrtko Ursulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fb6f1a2c-6e23-cfdf-2ce5-80209a005227@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=David.Nieto@amd.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=cphealy@gmail.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=robdclark@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.