From: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>
To: "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH v2 4/9] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC
Date: Wed, 7 Dec 2022 02:01:15 +0000 [thread overview]
Message-ID: <fb7a26a5c3456796e6388dd2b6e952303a984cf5.camel@mediatek.com> (raw)
In-Reply-To: <b55ee8fa-7ad6-3bf9-4983-41a90bd75ce4@collabora.com>
On Tue, 2022-12-06 at 13:22 +0100, AngeloGioacchino Del Regno wrote:
> Il 06/12/22 10:04, Xiangsheng Hou (侯祥胜) ha scritto:
> > Hi Angelo,
> >
> > On Mon, 2022-12-05 at 15:21 +0100, AngeloGioacchino Del Regno
> > wrote:
> > > Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
> > > > Add ECC support fot MT7986 IC.
> > > >
> > > > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> > > > ---
> > > > drivers/mtd/nand/ecc-mtk.c | 18 ++++++++++++++++++
> > > > 1 file changed, 18 insertions(+)
> > > >
> > > > diff --git a/drivers/mtd/nand/ecc-mtk.c b/drivers/mtd/nand/ecc-
> > > > mtk.c
> > > > index 9f9b201fe706..c2f6cfa76a04 100644
> > > > --- a/drivers/mtd/nand/ecc-mtk.c
> > > > +++ b/drivers/mtd/nand/ecc-mtk.c
> > > > @@ -79,6 +79,10 @@ static const u8 ecc_strength_mt7622[] = {
> > > > 4, 6, 8, 10, 12
> > > > };
> > > >
> > > > +static const u8 ecc_strength_mt7986[] = {
> > > > + 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24
> > > > +};
> > > > +
> > > > enum mtk_ecc_regs {
> > > > ECC_ENCPAR00,
> > > > ECC_ENCIRQ_EN,
> > > > @@ -483,6 +487,17 @@ static const struct mtk_ecc_caps
> > > > mtk_ecc_caps_mt7622 = {
> > > > .pg_irq_sel = 0,
> > > > };
> > > >
> > > > +static const struct mtk_ecc_caps mtk_ecc_caps_mt7986 = {
> > > > + .err_mask = 0x1f,
> > >
> > > Can't we use GENMASK() to define err_mask instead?
> > >
> > > #define MT7986_ERRNUM GENMASK(4, 0)
> > >
> > > P.S.: Did I get that right? Is that referred to the ERRNUM(x)
> > > bits
> >
> > Yes, you are right.
> > I will change like
> > #define ECC_ERRMASK(x) GENMASK(x, 0),
> > since other IC driver data will use 0x3f and 0x7f err_mask.
> >
>
> I would prefer, instead, something like
>
> #define MT7986_ERRNUM GENMASK(....)
> #define MT7622_ERRNUM GENMASK(....)
> #define MT.... (etc)
>
> instead of a macro calling another macro.
Will do.
Thanks
Xiangsheng Hou
WARNING: multiple messages have this Message-ID (diff)
From: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>
To: "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH v2 4/9] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC
Date: Wed, 7 Dec 2022 02:01:15 +0000 [thread overview]
Message-ID: <fb7a26a5c3456796e6388dd2b6e952303a984cf5.camel@mediatek.com> (raw)
In-Reply-To: <b55ee8fa-7ad6-3bf9-4983-41a90bd75ce4@collabora.com>
On Tue, 2022-12-06 at 13:22 +0100, AngeloGioacchino Del Regno wrote:
> Il 06/12/22 10:04, Xiangsheng Hou (侯祥胜) ha scritto:
> > Hi Angelo,
> >
> > On Mon, 2022-12-05 at 15:21 +0100, AngeloGioacchino Del Regno
> > wrote:
> > > Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
> > > > Add ECC support fot MT7986 IC.
> > > >
> > > > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> > > > ---
> > > > drivers/mtd/nand/ecc-mtk.c | 18 ++++++++++++++++++
> > > > 1 file changed, 18 insertions(+)
> > > >
> > > > diff --git a/drivers/mtd/nand/ecc-mtk.c b/drivers/mtd/nand/ecc-
> > > > mtk.c
> > > > index 9f9b201fe706..c2f6cfa76a04 100644
> > > > --- a/drivers/mtd/nand/ecc-mtk.c
> > > > +++ b/drivers/mtd/nand/ecc-mtk.c
> > > > @@ -79,6 +79,10 @@ static const u8 ecc_strength_mt7622[] = {
> > > > 4, 6, 8, 10, 12
> > > > };
> > > >
> > > > +static const u8 ecc_strength_mt7986[] = {
> > > > + 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24
> > > > +};
> > > > +
> > > > enum mtk_ecc_regs {
> > > > ECC_ENCPAR00,
> > > > ECC_ENCIRQ_EN,
> > > > @@ -483,6 +487,17 @@ static const struct mtk_ecc_caps
> > > > mtk_ecc_caps_mt7622 = {
> > > > .pg_irq_sel = 0,
> > > > };
> > > >
> > > > +static const struct mtk_ecc_caps mtk_ecc_caps_mt7986 = {
> > > > + .err_mask = 0x1f,
> > >
> > > Can't we use GENMASK() to define err_mask instead?
> > >
> > > #define MT7986_ERRNUM GENMASK(4, 0)
> > >
> > > P.S.: Did I get that right? Is that referred to the ERRNUM(x)
> > > bits
> >
> > Yes, you are right.
> > I will change like
> > #define ECC_ERRMASK(x) GENMASK(x, 0),
> > since other IC driver data will use 0x3f and 0x7f err_mask.
> >
>
> I would prefer, instead, something like
>
> #define MT7986_ERRNUM GENMASK(....)
> #define MT7622_ERRNUM GENMASK(....)
> #define MT.... (etc)
>
> instead of a macro calling another macro.
Will do.
Thanks
Xiangsheng Hou
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>
To: "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH v2 4/9] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC
Date: Wed, 7 Dec 2022 02:01:15 +0000 [thread overview]
Message-ID: <fb7a26a5c3456796e6388dd2b6e952303a984cf5.camel@mediatek.com> (raw)
In-Reply-To: <b55ee8fa-7ad6-3bf9-4983-41a90bd75ce4@collabora.com>
On Tue, 2022-12-06 at 13:22 +0100, AngeloGioacchino Del Regno wrote:
> Il 06/12/22 10:04, Xiangsheng Hou (侯祥胜) ha scritto:
> > Hi Angelo,
> >
> > On Mon, 2022-12-05 at 15:21 +0100, AngeloGioacchino Del Regno
> > wrote:
> > > Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
> > > > Add ECC support fot MT7986 IC.
> > > >
> > > > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> > > > ---
> > > > drivers/mtd/nand/ecc-mtk.c | 18 ++++++++++++++++++
> > > > 1 file changed, 18 insertions(+)
> > > >
> > > > diff --git a/drivers/mtd/nand/ecc-mtk.c b/drivers/mtd/nand/ecc-
> > > > mtk.c
> > > > index 9f9b201fe706..c2f6cfa76a04 100644
> > > > --- a/drivers/mtd/nand/ecc-mtk.c
> > > > +++ b/drivers/mtd/nand/ecc-mtk.c
> > > > @@ -79,6 +79,10 @@ static const u8 ecc_strength_mt7622[] = {
> > > > 4, 6, 8, 10, 12
> > > > };
> > > >
> > > > +static const u8 ecc_strength_mt7986[] = {
> > > > + 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24
> > > > +};
> > > > +
> > > > enum mtk_ecc_regs {
> > > > ECC_ENCPAR00,
> > > > ECC_ENCIRQ_EN,
> > > > @@ -483,6 +487,17 @@ static const struct mtk_ecc_caps
> > > > mtk_ecc_caps_mt7622 = {
> > > > .pg_irq_sel = 0,
> > > > };
> > > >
> > > > +static const struct mtk_ecc_caps mtk_ecc_caps_mt7986 = {
> > > > + .err_mask = 0x1f,
> > >
> > > Can't we use GENMASK() to define err_mask instead?
> > >
> > > #define MT7986_ERRNUM GENMASK(4, 0)
> > >
> > > P.S.: Did I get that right? Is that referred to the ERRNUM(x)
> > > bits
> >
> > Yes, you are right.
> > I will change like
> > #define ECC_ERRMASK(x) GENMASK(x, 0),
> > since other IC driver data will use 0x3f and 0x7f err_mask.
> >
>
> I would prefer, instead, something like
>
> #define MT7986_ERRNUM GENMASK(....)
> #define MT7622_ERRNUM GENMASK(....)
> #define MT.... (etc)
>
> instead of a macro calling another macro.
Will do.
Thanks
Xiangsheng Hou
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-07 2:01 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 6:57 [PATCH v2 0/9] Add MediaTek MT7986 SPI NAND and ECC support Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` [PATCH v2 1/9] spi: mtk-snfi: Add snfi support for MT7986 IC Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 6:57 ` [PATCH v2 2/9] spi: mtk-snfi: Change default page format to setup default setting Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` [PATCH v2 3/9] spi: mtk-snfi: Add optional nfi_hclk which needed for MT7986 Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-07 1:42 ` Xiangsheng Hou (侯祥胜)
2022-12-07 1:42 ` Xiangsheng Hou (侯祥胜)
2022-12-07 1:42 ` Xiangsheng Hou (侯祥胜)
2022-12-07 10:08 ` AngeloGioacchino Del Regno
2022-12-07 10:08 ` AngeloGioacchino Del Regno
2022-12-07 10:08 ` AngeloGioacchino Del Regno
2022-12-05 6:57 ` [PATCH v2 4/9] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 12:22 ` AngeloGioacchino Del Regno
2022-12-06 12:22 ` AngeloGioacchino Del Regno
2022-12-06 12:22 ` AngeloGioacchino Del Regno
2022-12-07 2:01 ` Xiangsheng Hou (侯祥胜) [this message]
2022-12-07 2:01 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:01 ` Xiangsheng Hou (侯祥胜)
2022-12-05 6:57 ` [PATCH v2 5/9] dt-bindings: spi: mtk-snfi: Add compatible for MT7986 Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:05 ` Krzysztof Kozlowski
2022-12-05 9:05 ` Krzysztof Kozlowski
2022-12-05 9:05 ` Krzysztof Kozlowski
2022-12-05 6:57 ` [PATCH v2 6/9] spi: mtk-snfi: Add snfi sample delay and read latency adjustment Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 6:57 ` [PATCH v2 7/9] dt-bindings: spi: mtk-snfi: Add read latch latency property Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:06 ` Krzysztof Kozlowski
2022-12-05 9:06 ` Krzysztof Kozlowski
2022-12-05 9:06 ` Krzysztof Kozlowski
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 12:19 ` AngeloGioacchino Del Regno
2022-12-06 12:19 ` AngeloGioacchino Del Regno
2022-12-06 12:19 ` AngeloGioacchino Del Regno
2022-12-07 2:00 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:00 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:00 ` Xiangsheng Hou (侯祥胜)
2022-12-07 9:48 ` AngeloGioacchino Del Regno
2022-12-07 9:48 ` AngeloGioacchino Del Regno
2022-12-07 9:48 ` AngeloGioacchino Del Regno
2022-12-08 1:15 ` Xiangsheng Hou (侯祥胜)
2022-12-08 1:15 ` Xiangsheng Hou (侯祥胜)
2022-12-08 1:15 ` Xiangsheng Hou (侯祥胜)
2022-12-08 8:46 ` Krzysztof Kozlowski
2022-12-08 8:46 ` Krzysztof Kozlowski
2022-12-08 8:46 ` Krzysztof Kozlowski
2022-12-05 6:57 ` [PATCH v2 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:21 ` Krzysztof Kozlowski
2022-12-05 9:21 ` Krzysztof Kozlowski
2022-12-05 9:21 ` Krzysztof Kozlowski
2022-12-06 9:05 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:05 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:05 ` Xiangsheng Hou (侯祥胜)
2022-12-05 6:57 ` [PATCH v2 9/9] dt-bindings: mtd: ecc-mtk: Add compatible for MT7986 Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:22 ` Krzysztof Kozlowski
2022-12-05 9:22 ` Krzysztof Kozlowski
2022-12-05 9:22 ` Krzysztof Kozlowski
2022-12-06 16:04 ` (subset) [PATCH v2 0/9] Add MediaTek MT7986 SPI NAND and ECC support Mark Brown
2022-12-06 16:04 ` Mark Brown
2022-12-06 16:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7a26a5c3456796e6388dd2b6e952303a984cf5.camel@mediatek.com \
--to=xiangsheng.hou@mediatek.com \
--cc=Benliang.Zhao@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bin.zhang@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.