All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Zeno Davatz <zdavatz@gmail.com>
Subject: Re: [PATCH] Revert "fbdev: Remove conflicting devices on PCI bus"
Date: Sat, 4 Feb 2023 14:36:19 +0100	[thread overview]
Message-ID: <fc19ceb2-5d64-2e33-b79c-9273925776b7@gmx.de> (raw)
In-Reply-To: <20230204085018.GA31758@wunner.de>

On 2/4/23 09:50, Lukas Wunner wrote:
> On Fri, Feb 03, 2023 at 05:09:09PM -0600, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas <bhelgaas@google.com>
>>
>> This reverts commit 145eed48de278007f646b908fd70ac59d24ed81a.
>>
>> Zeno Davatz reported that 145eed48de27 ("fbdev: Remove conflicting devices
>> on PCI bus") caused a console hang.  The machine was actually still usable
>> via ssh, etc., but there was no activity on the console.
>>
>> Reverting 145eed48de27 for the nvidiafb on that system fixed the problem.
>>
>> Revert 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") since
>> we don't know what caused the problem.
>>
>> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=216859
>
> Shouldn't that rather be:
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216859
> Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus")
> Cc: stable@vger.kernel.org # v6.1+
>
> ?

The original patch is related to drm, and came in through the drm-misc
tree, so please drm folks, take such revert through the drm-misc
tree (if the patch is ok) as well.

Thanks,
Helge


>> Reported-by: Zeno Davatz <zdavatz@gmail.com>
>> Tested-by: Zeno Davatz <zdavatz@gmail.com>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Javier Martinez Canillas <javierm@redhat.com>
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-kernel@vger.kernel.org
>> ---


WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>,
	dri-devel@lists.freedesktop.org
Cc: Zeno Davatz <zdavatz@gmail.com>,
	linux-fbdev@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] Revert "fbdev: Remove conflicting devices on PCI bus"
Date: Sat, 4 Feb 2023 14:36:19 +0100	[thread overview]
Message-ID: <fc19ceb2-5d64-2e33-b79c-9273925776b7@gmx.de> (raw)
In-Reply-To: <20230204085018.GA31758@wunner.de>

On 2/4/23 09:50, Lukas Wunner wrote:
> On Fri, Feb 03, 2023 at 05:09:09PM -0600, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas <bhelgaas@google.com>
>>
>> This reverts commit 145eed48de278007f646b908fd70ac59d24ed81a.
>>
>> Zeno Davatz reported that 145eed48de27 ("fbdev: Remove conflicting devices
>> on PCI bus") caused a console hang.  The machine was actually still usable
>> via ssh, etc., but there was no activity on the console.
>>
>> Reverting 145eed48de27 for the nvidiafb on that system fixed the problem.
>>
>> Revert 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") since
>> we don't know what caused the problem.
>>
>> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=216859
>
> Shouldn't that rather be:
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216859
> Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus")
> Cc: stable@vger.kernel.org # v6.1+
>
> ?

The original patch is related to drm, and came in through the drm-misc
tree, so please drm folks, take such revert through the drm-misc
tree (if the patch is ok) as well.

Thanks,
Helge


>> Reported-by: Zeno Davatz <zdavatz@gmail.com>
>> Tested-by: Zeno Davatz <zdavatz@gmail.com>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Javier Martinez Canillas <javierm@redhat.com>
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-kernel@vger.kernel.org
>> ---


  reply	other threads:[~2023-02-04 13:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 23:09 [PATCH] Revert "fbdev: Remove conflicting devices on PCI bus" Bjorn Helgaas
2023-02-03 23:09 ` Bjorn Helgaas
2023-02-04  8:50 ` Lukas Wunner
2023-02-04  8:50   ` Lukas Wunner
2023-02-04 13:36   ` Helge Deller [this message]
2023-02-04 13:36     ` Helge Deller
2023-02-04 16:23   ` Bjorn Helgaas
2023-02-04 16:23     ` Bjorn Helgaas
2023-02-05 20:59 ` Dave Airlie
2023-02-05 20:59   ` Dave Airlie
2023-02-06 15:56   ` Bjorn Helgaas
2023-02-06 15:56     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc19ceb2-5d64-2e33-b79c-9273925776b7@gmx.de \
    --to=deller@gmx.de \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=zdavatz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.