From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Marek Behun <marek.behun@nic.cz>, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
u-boot@lists.denx.de
Subject: Re: [PATCH U-BOOT 00/26] fs: btrfs: Re-implement btrfs support using the more widely used extent buffer base code
Date: Wed, 22 Apr 2020 15:56:05 +0800 [thread overview]
Message-ID: <fc78b14b-ea71-80e0-f0cc-6f476860d6c6@gmx.com> (raw)
In-Reply-To: <fa3177ef-c264-2fc0-4793-d35209d05d2b@gmx.com>
[-- Attachment #1.1: Type: text/plain, Size: 1696 bytes --]
On 2020/4/22 下午3:52, Qu Wenruo wrote:
>
>
> On 2020/4/22 下午3:46, Marek Behun wrote:
>> On Wed, 22 Apr 2020 14:49:43 +0800
>> Qu Wenruo <wqu@suse.com> wrote:
>>
>> Hi Qu,
>>
>>> The current btrfs code in U-boot is using a creative way to read on-disk
>>> data.
>>> It's pretty simple, involving the least amount of code, but pretty
>>> different from btrfs-progs nor kernel, making it pretty hard to sync
>>> code between different projects.
>>
>> do you think maybe btrfs-progs / kernel would be interested if I
>> tried to convert their code to this "simpler to use" implementation of
>> conversion functions?
>
> I don't think so, the problem is kernel and btrfs-progs all need to
> modify extent buffer, which make the read time conversion become a
> burden in write path.
>
>>
>>> Thus only the following 5 patches need extra review attention:
>>> - Patch 0017
>>> - Patch 0018
>>> - Patch 0022
>>> - Patch 0023
>>> - Patch 0024
>>
>> Anyway, this patch series does not apply cleanly on u-boot/master. I
>> tried with the first 3 patches and then gave up :(
>> Sorry about this but I will review and test if you send a series that
>> applies cleanly.
>
> That's strange, the branch is originally based on an older master, as
> you can find in the github.
>
> I guess there are some more btrfs related code change since then, I'll
> rebase them to latest master, and update the github repo then.
Git repo updated.
You can fetch that branch.
Only two small conflicts during rebase, and since it compiles I haven't
re-done the full test, but it looks pretty OK.
Thanks,
Qu
>
> Thanks,
> Qu
>
>>
>> Marek
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: u-boot@lists.denx.de
Subject: [PATCH U-BOOT 00/26] fs: btrfs: Re-implement btrfs support using the more widely used extent buffer base code
Date: Wed, 22 Apr 2020 15:56:05 +0800 [thread overview]
Message-ID: <fc78b14b-ea71-80e0-f0cc-6f476860d6c6@gmx.com> (raw)
In-Reply-To: <fa3177ef-c264-2fc0-4793-d35209d05d2b@gmx.com>
On 2020/4/22 ??3:52, Qu Wenruo wrote:
>
>
> On 2020/4/22 ??3:46, Marek Behun wrote:
>> On Wed, 22 Apr 2020 14:49:43 +0800
>> Qu Wenruo <wqu@suse.com> wrote:
>>
>> Hi Qu,
>>
>>> The current btrfs code in U-boot is using a creative way to read on-disk
>>> data.
>>> It's pretty simple, involving the least amount of code, but pretty
>>> different from btrfs-progs nor kernel, making it pretty hard to sync
>>> code between different projects.
>>
>> do you think maybe btrfs-progs / kernel would be interested if I
>> tried to convert their code to this "simpler to use" implementation of
>> conversion functions?
>
> I don't think so, the problem is kernel and btrfs-progs all need to
> modify extent buffer, which make the read time conversion become a
> burden in write path.
>
>>
>>> Thus only the following 5 patches need extra review attention:
>>> - Patch 0017
>>> - Patch 0018
>>> - Patch 0022
>>> - Patch 0023
>>> - Patch 0024
>>
>> Anyway, this patch series does not apply cleanly on u-boot/master. I
>> tried with the first 3 patches and then gave up :(
>> Sorry about this but I will review and test if you send a series that
>> applies cleanly.
>
> That's strange, the branch is originally based on an older master, as
> you can find in the github.
>
> I guess there are some more btrfs related code change since then, I'll
> rebase them to latest master, and update the github repo then.
Git repo updated.
You can fetch that branch.
Only two small conflicts during rebase, and since it compiles I haven't
re-done the full test, but it looks pretty OK.
Thanks,
Qu
>
> Thanks,
> Qu
>
>>
>> Marek
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200422/382d0616/attachment.sig>
next prev parent reply other threads:[~2020-04-22 7:56 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 6:49 [PATCH U-BOOT 00/26] fs: btrfs: Re-implement btrfs support using the more widely used extent buffer base code Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 01/26] fs: btrfs: Sync btrfs_btree.h from kernel Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 02/26] fs: btrfs: Add More checksum algorithm support to btrfs Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 03/26] fs: btrfs: Cross-port btrfs_read_dev_super() from btrfs-progs Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 8:26 ` Marek Behun
2020-04-22 8:26 ` Marek Behun
2020-04-22 8:34 ` Qu Wenruo
2020-04-22 8:34 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 04/26] fs: btrfs: Cross-port rbtree-utils " Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 05/26] fs: btrfs: Cross-port extent-cache.[ch] " Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 06/26] fs: btrfs: Cross-port extent-io.[ch] " Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 07/26] fs: btrfs: Cross port structure accessor into ctree.h Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 08/26] fs: btrfs: Cross port volumes.[ch] from btrfs-progs Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 09/26] fs: btrfs: Crossport read_tree_block() " Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 10/26] fs: btrfs: Rename struct btrfs_path to struct __btrfs_path Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 11/26] fs: btrfs: Rename btrfs_root to __btrfs_root Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 12/26] fs: btrfs: Cross port struct btrfs_root to ctree.h Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 13/26] fs: btrfs: Crossport btrfs_search_slot() from btrfs-progs Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 14/26] fs: btrfs: Crossport btrfs_read_sys_array() and btrfs_read_chunk_tree() Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 15/26] fs: btrfs: Crossport open_ctree_fs_info() Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:49 ` [PATCH U-BOOT 16/26] fs: btrfs: Rename path resolve related functions to avoid name conflicts Qu Wenruo
2020-04-22 6:49 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 17/26] fs: btrfs: Use btrfs_readlink() to implement __btrfs_readlink() Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 18/26] fs: btrfs: Implement btrfs_lookup_path() Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 9:37 ` Su Yue
2020-04-22 9:46 ` Su Yue
2020-04-22 9:46 ` Su Yue
2020-04-22 10:04 ` Marek Behun
2020-04-22 10:04 ` Marek Behun
2020-04-22 14:17 ` Su Yue
2020-04-22 14:17 ` Su Yue
2020-04-22 14:44 ` Su Yue
2020-04-22 14:44 ` Su Yue
2020-04-22 14:49 ` Marek Behun
2020-04-22 14:49 ` Marek Behun
2020-04-22 6:50 ` [PATCH U-BOOT 19/26] fs: btrfs: Use btrfs_iter_dir() to replace btrfs_readdir() Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 20/26] fs: btrfs: Use btrfs_lookup_path() to implement btrfs_exists() and btrfs_size() Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 21/26] fs: btrfs: Rename btrfs_file_read() and its callees to avoid name conflicts Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 22/26] fs: btrfs: Introduce btrfs_read_extent_inline() and btrfs_read_extent_reg() Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 23/26] fs: btrfs: Introduce lookup_data_extent() for later use Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 24/26] fs: btrfs: Implement btrfs_file_read() Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 25/26] fs: btrfs: Cleanup the old implementation Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 6:50 ` [PATCH U-BOOT 26/26] MAINTAINERS: Add btrfs mail list Qu Wenruo
2020-04-22 6:50 ` Qu Wenruo
2020-04-22 7:46 ` [PATCH U-BOOT 00/26] fs: btrfs: Re-implement btrfs support using the more widely used extent buffer base code Marek Behun
2020-04-22 7:46 ` Marek Behun
2020-04-22 7:52 ` Qu Wenruo
2020-04-22 7:52 ` Qu Wenruo
2020-04-22 7:56 ` Qu Wenruo [this message]
2020-04-22 7:56 ` Qu Wenruo
2020-04-22 9:33 ` Marek Behun
2020-04-22 9:33 ` Marek Behun
2020-04-22 7:52 ` Marek Behun
2020-04-22 7:52 ` Marek Behun
2020-04-22 7:59 ` Marek Behun
2020-04-22 7:59 ` Marek Behun
2020-04-22 8:12 ` Qu Wenruo
2020-04-22 8:12 ` Qu Wenruo
2020-04-22 8:13 ` Marek Behun
2020-04-22 8:13 ` Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc78b14b-ea71-80e0-f0cc-6f476860d6c6@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.