All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
	linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] clk: meson: axg-audio: provide clk top signal name
Date: Fri, 27 Sep 2019 16:07:42 +0200	[thread overview]
Message-ID: <fcf94d1d-0fb4-3fb3-846a-57afcbac41a3@baylibre.com> (raw)
In-Reply-To: <1jh84x2642.fsf@starbuckisacylon.baylibre.com>

On 27/09/2019 15:58, Jerome Brunet wrote:
> 
> On Fri 27 Sep 2019 at 11:37, Neil Armstrong <narmstrong@baylibre.com> wrote:
> 
>> On 27/09/2019 11:14, Neil Armstrong wrote:
>>> On 24/09/2019 17:33, Jerome Brunet wrote:
>>>
> 
> [...]
> 
>>> AUD_CLKID_TOP seems to be missing here
>>
>> Oh, yes it was exposed, do you need to it to be exposed since it's
>> dummy for G12A ?
> 
> It is a bypass clock on g12a and axg yes, but on the sm1.
> It is the leaf of a block on sm1, for all I know it could be used
> outside the clock controller.
> 
> Of course, I could wait this until there is an actual need for it if that is
> what you mean ?

Yes, but it's a valid clock on sm1, so leave it as it is.

Neil

> 
>>
>> Neil
>>
>>>
>>>
>>>>  /* include the CLKIDs which are part of the DT bindings */
>>>>  #include <dt-bindings/clock/axg-audio-clkc.h>
>>>>  
>>>> -#define NR_CLKS	163
>>>> +#define NR_CLKS	164
>>>>  
>>>>  #endif /*__AXG_AUDIO_CLKC_H */
>>>>
>>>
> 


WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 6/7] clk: meson: axg-audio: provide clk top signal name
Date: Fri, 27 Sep 2019 16:07:42 +0200	[thread overview]
Message-ID: <fcf94d1d-0fb4-3fb3-846a-57afcbac41a3@baylibre.com> (raw)
In-Reply-To: <1jh84x2642.fsf@starbuckisacylon.baylibre.com>

On 27/09/2019 15:58, Jerome Brunet wrote:
> 
> On Fri 27 Sep 2019 at 11:37, Neil Armstrong <narmstrong@baylibre.com> wrote:
> 
>> On 27/09/2019 11:14, Neil Armstrong wrote:
>>> On 24/09/2019 17:33, Jerome Brunet wrote:
>>>
> 
> [...]
> 
>>> AUD_CLKID_TOP seems to be missing here
>>
>> Oh, yes it was exposed, do you need to it to be exposed since it's
>> dummy for G12A ?
> 
> It is a bypass clock on g12a and axg yes, but on the sm1.
> It is the leaf of a block on sm1, for all I know it could be used
> outside the clock controller.
> 
> Of course, I could wait this until there is an actual need for it if that is
> what you mean ?

Yes, but it's a valid clock on sm1, so leave it as it is.

Neil

> 
>>
>> Neil
>>
>>>
>>>
>>>>  /* include the CLKIDs which are part of the DT bindings */
>>>>  #include <dt-bindings/clock/axg-audio-clkc.h>
>>>>  
>>>> -#define NR_CLKS	163
>>>> +#define NR_CLKS	164
>>>>  
>>>>  #endif /*__AXG_AUDIO_CLKC_H */
>>>>
>>>
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2019-09-27 14:07 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 15:33 [PATCH 0/7] clk: meson: axg-audio: add sm1 support Jerome Brunet
2019-09-24 15:33 ` Jerome Brunet
2019-09-24 15:33 ` [PATCH 1/7] dt-bindings: clk: axg-audio: add sm1 bindings Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:10   ` Neil Armstrong
2019-09-27  9:10     ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 2/7] dt-bindings: clock: meson: add sm1 resets to the axg-audio controller Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:10   ` Neil Armstrong
2019-09-27  9:10     ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 3/7] clk: meson: axg-audio: remove useless defines Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:10   ` Neil Armstrong
2019-09-27  9:10     ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 4/7] clk: meson: axg-audio: fix regmap last register Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:11   ` Neil Armstrong
2019-09-27  9:11     ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 5/7] clk: meson: axg-audio: prepare sm1 addition Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:13   ` Neil Armstrong
2019-09-27  9:13     ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 6/7] clk: meson: axg-audio: provide clk top signal name Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:14   ` Neil Armstrong
2019-09-27  9:14     ` Neil Armstrong
2019-09-27  9:37     ` Neil Armstrong
2019-09-27  9:37       ` Neil Armstrong
2019-09-27 13:58       ` Jerome Brunet
2019-09-27 13:58         ` Jerome Brunet
2019-09-27 14:07         ` Neil Armstrong [this message]
2019-09-27 14:07           ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 7/7] clk: meson: axg_audio: add sm1 support Jerome Brunet
2019-09-24 15:33   ` Jerome Brunet
2019-09-27  9:36   ` Neil Armstrong
2019-09-27  9:36     ` Neil Armstrong
2019-09-27 14:01     ` Jerome Brunet
2019-09-27 14:01       ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcf94d1d-0fb4-3fb3-846a-57afcbac41a3@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.