From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, eric@anholt.net,
stefan.wahren@i2se.com, f.fainelli@gmail.com, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
andriy.shevchenko@linux.intel.com, vz@mleia.com,
matthias.bgg@gmail.com, yamada.masahiro@socionext.com,
tklauser@distanz.ch, richard.genoud@gmail.com,
macro@linux-mips.org, u.kleine-koenig@pengutronix.de,
kernel@pengutronix.de, slemieux.tyco@gmail.com,
andy.gross@linaro.org, david.brown@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
linux-imx@nxp.com, baohua@kernel.org, jacmet@sunsite.dk,
linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 10/45] drivers: tty: serial: zs: use devm_* functions
Date: Sat, 16 Mar 2019 10:17:11 +0100 [thread overview]
Message-ID: <fd8d6a9b-3e85-9904-2195-1f1bbc42bd2d@metux.net> (raw)
In-Reply-To: <20190316032630.GB2499@kroah.com>
On 16.03.19 04:26, Greg KH wrote:
> No, it's just that those systems do not allow those devices to be
> removed because they are probably not on a removable bus.
Ok, devices (hw) might not be removable - that also the case for uarts
builtin some SoCs, or the good old PC w/ 8250. But does that also mean
that the driver should not be removable ?
IMHO, even if that's the case, it's still inconsistent. The driver then
shouldn't support a remove at all (or even builtin only), not just
incomplete remove.
>> Okay, I was on a wrong track here - I had the silly idea that it would
>> make things easier if we'd do it the same way everywhere.
>
> "Consistent" is good, and valid, but touching old drivers that have few
> users is always risky, and you need a solid reason to do so.
Understood.
By the way: do we have some people who have those old hw and could test?
Should we (try to) create some ? Perhaps some "tester" entry in
MAINTAINERS file ? (I could ask around several people who might have
lots of old / rare hardware.)
>> Understood. Assuming I've found some of these cases, shall I use devm
>> oder just add the missing release ?
>
> If it actually makes the code "simpler" or "more obvious", sure, that's
> fine. But churn for churns sake is not ok.
Ok.
> I put the review of new patch submissions on hold, yes. Almost all
> maintainers do that as we can not add new patches to our trees at that
> point in time.
hmm, looks like a pipeline stall ;-)
why not collecting in a separate branch, which later gets rebased to
mainline when rc is out ?
> And I do have other things I do during that period so it's not like I'm
> just sitting around doing nothing :)
So it's also a fixed schedule for your other work. Understood.
It seems that this workflow can confuse people. Few days ago, somebody
became nervous about missing reactions on patches. Your autoresponder
worked for me, but maybe not for everybody.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
WARNING: multiple messages have this Message-ID (diff)
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org, yamada.masahiro@socionext.com,
macro@linux-mips.org, jacmet@sunsite.dk, festevam@gmail.com,
stefan.wahren@i2se.com, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, linux-imx@nxp.com,
linux-serial@vger.kernel.org, slemieux.tyco@gmail.com,
andy.gross@linaro.org, tklauser@distanz.ch,
david.brown@linaro.org, rjui@broadcom.com,
s.hauer@pengutronix.de, u.kleine-koenig@pengutronix.de,
linuxppc-dev@lists.ozlabs.org, vz@mleia.com,
matthias.bgg@gmail.com, andriy.shevchenko@linux.intel.com,
baohua@kernel.org, sbranden@broadcom.com, eric@anholt.net,
richard.genoud@gmail.com, "Enrico Weigelt,
metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
shawnguo@kernel.org
Subject: Re: [PATCH v2 10/45] drivers: tty: serial: zs: use devm_* functions
Date: Sat, 16 Mar 2019 10:17:11 +0100 [thread overview]
Message-ID: <fd8d6a9b-3e85-9904-2195-1f1bbc42bd2d@metux.net> (raw)
In-Reply-To: <20190316032630.GB2499@kroah.com>
On 16.03.19 04:26, Greg KH wrote:
> No, it's just that those systems do not allow those devices to be
> removed because they are probably not on a removable bus.
Ok, devices (hw) might not be removable - that also the case for uarts
builtin some SoCs, or the good old PC w/ 8250. But does that also mean
that the driver should not be removable ?
IMHO, even if that's the case, it's still inconsistent. The driver then
shouldn't support a remove at all (or even builtin only), not just
incomplete remove.
>> Okay, I was on a wrong track here - I had the silly idea that it would
>> make things easier if we'd do it the same way everywhere.
>
> "Consistent" is good, and valid, but touching old drivers that have few
> users is always risky, and you need a solid reason to do so.
Understood.
By the way: do we have some people who have those old hw and could test?
Should we (try to) create some ? Perhaps some "tester" entry in
MAINTAINERS file ? (I could ask around several people who might have
lots of old / rare hardware.)
>> Understood. Assuming I've found some of these cases, shall I use devm
>> oder just add the missing release ?
>
> If it actually makes the code "simpler" or "more obvious", sure, that's
> fine. But churn for churns sake is not ok.
Ok.
> I put the review of new patch submissions on hold, yes. Almost all
> maintainers do that as we can not add new patches to our trees at that
> point in time.
hmm, looks like a pipeline stall ;-)
why not collecting in a separate branch, which later gets rebased to
mainline when rc is out ?
> And I do have other things I do during that period so it's not like I'm
> just sitting around doing nothing :)
So it's also a fixed schedule for your other work. Understood.
It seems that this workflow can confuse people. Few days ago, somebody
became nervous about missing reactions on patches. Your autoresponder
worked for me, but maybe not for everybody.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-03-16 9:17 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 22:33 serial driver cleanups v2 Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 01/45] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 02/45] drivers: tty: serial: 8250_dw: use devm_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-15 9:04 ` Andy Shevchenko
2019-03-15 9:04 ` Andy Shevchenko
2019-03-15 9:04 ` Andy Shevchenko
2019-03-15 9:37 ` Enrico Weigelt, metux IT consult
2019-03-15 9:37 ` Enrico Weigelt, metux IT consult
2019-03-15 9:37 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 03/45] drivers: tty: serial: 8250_ingenic: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 04/45] drivers: tty: serial: amba-pl010: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 05/45] drivers: tty: serial: sirfsoc_uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 06/45] drivers: tty: serial: samsung: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 07/45] drivers: tty: serial: 8250_uniphier: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-18 7:44 ` Masahiro Yamada
2019-03-18 7:44 ` Masahiro Yamada
2019-03-18 7:44 ` Masahiro Yamada
2019-03-14 22:33 ` [PATCH v2 08/45] drivers: tty: serial: 8250_lpc18xx: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 09/45] drivers: tty: serial: 8250_mtk: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 10/45] drivers: tty: serial: zs: use devm_* functions Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:52 ` Greg KH
2019-03-14 22:52 ` Greg KH
2019-03-15 9:06 ` Enrico Weigelt, metux IT consult
2019-03-15 9:06 ` Enrico Weigelt, metux IT consult
2019-03-15 14:26 ` Greg KH
2019-03-15 14:26 ` Greg KH
2019-03-15 19:12 ` Enrico Weigelt, metux IT consult
2019-03-15 19:12 ` Enrico Weigelt, metux IT consult
2019-03-16 3:26 ` Greg KH
2019-03-16 3:26 ` Greg KH
2019-03-16 9:17 ` Enrico Weigelt, metux IT consult [this message]
2019-03-16 9:17 ` Enrico Weigelt, metux IT consult
2019-03-17 9:54 ` Greg KH
2019-03-17 9:54 ` Greg KH
2019-03-18 8:03 ` Maciej W. Rozycki
2019-03-18 8:03 ` Maciej W. Rozycki
2019-03-14 22:33 ` [PATCH v2 11/45] drivers: tty: serial: zs: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 12/45] drivers: tty: serial: xilinx_uartps: use devm_* functions Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 13/45] drivers: tty: serial: 21285: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 14/45] drivers: tty: serial: vr41xx_siu: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 15/45] drivers: tty: serial: uartlite: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 16/45] drivers: tty: serial: uartlite: use devm_* functions Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 17/45] drivers: tty: serial: timuart: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 18/45] drivers: tty: serial: sirfsoc_uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 19/45] drivers: tty: serial: sh-sci: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 20/45] drivers: tty: serial: msm_serial: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-05-27 5:57 ` Bjorn Andersson
2019-05-27 5:57 ` Bjorn Andersson
2019-03-14 22:33 ` [PATCH v2 21/45] drivers: tty: serial: altera_jtaguart: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 22/45] drivers: tty: serial: altera_uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 23/45] drivers: tty: serial: amba-pl010: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 24/45] drivers: tty: serial: mxs-auart: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 25/45] drivers: tty: serial: pxa: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 26/45] drivers: tty: serial: dz: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 27/45] drivers: tty: serial: dz: use devm_* functions Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 28/45] drivers: tty: serial: netx-serial: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` [PATCH v2 29/45] drivers: tty: serial: serial_txx9: " Enrico Weigelt, metux IT consult
2019-03-14 22:33 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 30/45] drivers: tty: serial: serial_ks8695: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 31/45] drivers: tty: serial: amba-pl011: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 32/45] drivers: tty: serial: atmel_serial: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 33/45] drivers: tty: serial: sb1250-duart: use dev_err() instead of printk() Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 34/45] drivers: tty: serial: sb1250-duart: use devm_* functions Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 35/45] drivers: tty: serial: lpc32xx_hs: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 36/45] drivers: tty: serial: pic32_uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 37/45] drivers: tty: serial: apbuart: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 38/45] drivers: tty: serial: samsung: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 39/45] drivers: tty: serial: efm32-uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-15 7:46 ` Uwe Kleine-König
2019-03-15 7:46 ` Uwe Kleine-König
2019-03-14 22:34 ` [PATCH v2 40/45] drivers: tty: serial: mpc52xx_uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 41/45] drivers: tty: serial: timuart: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 42/45] drivers: tty: serial: sa1100: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 43/45] drivers: tty: serial: pmac_zilog: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 44/45] drivers: tty: serial: pnx8xxx_uart: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` [PATCH v2 45/45] drivers: tty: serial: mux: " Enrico Weigelt, metux IT consult
2019-03-14 22:34 ` Enrico Weigelt, metux IT consult
2019-03-15 9:08 ` Andy Shevchenko
2019-03-15 9:08 ` Andy Shevchenko
2019-03-15 9:08 ` Andy Shevchenko
2019-03-15 9:12 ` serial driver cleanups v2 Andy Shevchenko
2019-03-15 9:12 ` Andy Shevchenko
2019-03-15 9:12 ` Andy Shevchenko
2019-03-15 9:20 ` Andy Shevchenko
2019-03-15 9:20 ` Andy Shevchenko
2019-03-15 9:20 ` Andy Shevchenko
2019-03-15 10:36 ` Enrico Weigelt, metux IT consult
2019-03-15 10:36 ` Enrico Weigelt, metux IT consult
2019-03-15 10:36 ` Enrico Weigelt, metux IT consult
2019-03-15 18:11 ` Andy Shevchenko
2019-03-15 18:11 ` Andy Shevchenko
2019-03-15 18:11 ` Andy Shevchenko
2019-03-15 18:41 ` Enrico Weigelt, metux IT consult
2019-03-15 18:41 ` Enrico Weigelt, metux IT consult
2019-03-15 18:41 ` Enrico Weigelt, metux IT consult
2019-03-15 18:45 ` Andy Shevchenko
2019-03-15 18:45 ` Andy Shevchenko
2019-03-15 18:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8d6a9b-3e85-9904-2195-1f1bbc42bd2d@metux.net \
--to=lkml@metux.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=baohua@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=david.brown@linaro.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=jacmet@sunsite.dk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@linux-mips.org \
--cc=matthias.bgg@gmail.com \
--cc=richard.genoud@gmail.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=stefan.wahren@i2se.com \
--cc=tklauser@distanz.ch \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.