From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Lee Jones <lee.jones@linaro.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused
Date: Wed, 8 Jul 2020 15:34:41 +0200 [thread overview]
Message-ID: <fdb3fb06-d710-5c4b-6b85-fc9bb90b891b@st.com> (raw)
In-Reply-To: <20200707143742.2959960-21-lee.jones@linaro.org>
On 7/7/20 4:37 PM, Lee Jones wrote:
> Only 2 of the 3 source files which include this headerfile actually
> reference 'uni_tdm_hw'. The other source file 'sti_uniperif.c' sees
> as it as being unused. Mark it as __maybe_unused to show that this
> behaviour is not only known, it's intentional.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=]
> 1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
> | ^~~~~~~~~~
>
> Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks
Arnaud
> ---
> sound/soc/sti/uniperif.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
> index 2dc2da5d458bd..e22d045d5cd99 100644
> --- a/sound/soc/sti/uniperif.h
> +++ b/sound/soc/sti/uniperif.h
> @@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
> struct sti_uniperiph_dai dai_data;
> };
>
> -static const struct snd_pcm_hardware uni_tdm_hw = {
> +static const struct snd_pcm_hardware __maybe_unused uni_tdm_hw = {
> .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
> SNDRV_PCM_INFO_MMAP_VALID,
>
WARNING: multiple messages have this Message-ID (diff)
From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Lee Jones <lee.jones@linaro.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused
Date: Wed, 8 Jul 2020 15:34:41 +0200 [thread overview]
Message-ID: <fdb3fb06-d710-5c4b-6b85-fc9bb90b891b@st.com> (raw)
In-Reply-To: <20200707143742.2959960-21-lee.jones@linaro.org>
On 7/7/20 4:37 PM, Lee Jones wrote:
> Only 2 of the 3 source files which include this headerfile actually
> reference 'uni_tdm_hw'. The other source file 'sti_uniperif.c' sees
> as it as being unused. Mark it as __maybe_unused to show that this
> behaviour is not only known, it's intentional.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=]
> 1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
> | ^~~~~~~~~~
>
> Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks
Arnaud
> ---
> sound/soc/sti/uniperif.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
> index 2dc2da5d458bd..e22d045d5cd99 100644
> --- a/sound/soc/sti/uniperif.h
> +++ b/sound/soc/sti/uniperif.h
> @@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
> struct sti_uniperiph_dai dai_data;
> };
>
> -static const struct snd_pcm_hardware uni_tdm_hw = {
> +static const struct snd_pcm_hardware __maybe_unused uni_tdm_hw = {
> .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
> SNDRV_PCM_INFO_MMAP_VALID,
>
WARNING: multiple messages have this Message-ID (diff)
From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Lee Jones <lee.jones@linaro.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused
Date: Wed, 8 Jul 2020 15:34:41 +0200 [thread overview]
Message-ID: <fdb3fb06-d710-5c4b-6b85-fc9bb90b891b@st.com> (raw)
In-Reply-To: <20200707143742.2959960-21-lee.jones@linaro.org>
On 7/7/20 4:37 PM, Lee Jones wrote:
> Only 2 of the 3 source files which include this headerfile actually
> reference 'uni_tdm_hw'. The other source file 'sti_uniperif.c' sees
> as it as being unused. Mark it as __maybe_unused to show that this
> behaviour is not only known, it's intentional.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=]
> 1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
> | ^~~~~~~~~~
>
> Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks
Arnaud
> ---
> sound/soc/sti/uniperif.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
> index 2dc2da5d458bd..e22d045d5cd99 100644
> --- a/sound/soc/sti/uniperif.h
> +++ b/sound/soc/sti/uniperif.h
> @@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
> struct sti_uniperiph_dai dai_data;
> };
>
> -static const struct snd_pcm_hardware uni_tdm_hw = {
> +static const struct snd_pcm_hardware __maybe_unused uni_tdm_hw = {
> .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
> SNDRV_PCM_INFO_MMAP_VALID,
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-08 13:35 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 14:37 [PATCH v2 00/28] Clean-up ASoC's W=1 build warnings Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 01/28] ASoC: atmel: atmel-pcm-dma: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 02/28] ASoC: atmel: atmel_ssc_dai: " Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 03/28] ASoC: fsl: fsl-asoc-card: Use correct format when providing struct documentation Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 04/28] ASoC: fsl: fsl_asrc: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 05/28] ASoC: fsl: fsl_ssi: " Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 06/28] ASoC: fsl: fsl_ssi_dbg: " Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 07/28] ASoC: fsl: fsl_spdif: Use correct formatting when denoting struct documentation Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 08/28] ASoC: fsl: fsl_spdif: Update 'struct fsl_spdif_priv's descriptions Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 09/28] ASoC: fsl: fsl_esai: Fix a bunch of kerneldoc issues Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 10/28] ASoC: fsl: fsl_esai: Add descriptions for 'tx_mask' and 'rx_mask' to 'fsl_esai' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 11/28] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 12/28] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 13/28] ASoC: qcom: qdsp6: q6asm: Provide documentation for WMA 'codec_profile' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 14/28] ASoC: samsung: pcm: Demote half-documented kerneldoc header Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-08 8:39 ` Sylwester Nawrocki
2020-07-08 8:39 ` Sylwester Nawrocki
2020-07-08 8:39 ` Sylwester Nawrocki
2020-07-07 14:37 ` [PATCH v2 15/28] ASoC: samsung: spdif: Fix 3 misspelled struct properties Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 16/28] ASoC: sunxi: sun4i-i2s: Demote half-documented kerneldoc header Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 17/28] ASoC: uniphier: aio-core: Fix incorrectly named struct property and remove another Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 18/28] ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-08 13:34 ` Arnaud POULIQUEN [this message]
2020-07-08 13:34 ` Arnaud POULIQUEN
2020-07-08 13:34 ` Arnaud POULIQUEN
2020-07-07 14:37 ` [PATCH v2 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 22/28] ASoC: codecs: da7210: Fix formatting issues in da7210_set_dai_pll() header Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 23/28] ASoC: soc-ac97: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 24/28] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv' Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 25/28] ASoC: codecs: rt5631: Demote misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 26/28] ASoC: codecs: rt5659: Remove many unused const variables Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 27/28] ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` [PATCH v2 28/28] ASoC: codecs: wm8400: Remove a bunch of unused variables Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:37 ` Lee Jones
2020-07-07 14:38 ` [PATCH v2 00/28] Clean-up ASoC's W=1 build warnings Mark Brown
2020-07-07 14:38 ` Mark Brown
2020-07-07 14:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb3fb06-d710-5c4b-6b85-fc9bb90b891b@st.com \
--to=arnaud.pouliquen@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.