Re: Fwd: [PATCH v2 2/3] drm/msm/dp: rename second dp_display_enable()'s argument

From: Kuogee Hsieh <quic_khsieh@quicinc.com>
To: <dmitry.baryshkov@linaro.org>, Rob Clark <robdclark@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	<linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>
Subject: Re: Fwd: [PATCH v2 2/3] drm/msm/dp: rename second dp_display_enable()'s argument
Date: Tue, 28 Jun 2022 08:39:39 -0700	[thread overview]
Message-ID: <fdba8976-1bae-9bb2-60a3-bd206bf03a52@quicinc.com> (raw)
In-Reply-To: <b88142b5-2614-23e6-75fd-46f864716fd7@quicinc.com>


On 6/24/2022 10:36 AM, Abhinav Kumar wrote:
>
>
>
> -------- Forwarded Message --------
> Subject: [PATCH v2 2/3] drm/msm/dp: rename second 
> dp_display_enable()'s argument
> Date: Sat, 18 Jun 2022 02:24:33 +0300
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, 
> Abhinav Kumar <quic_abhinavk@quicinc.com>
> CC: Stephen Boyd <swboyd@chromium.org>, David Airlie 
> <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Bjorn Andersson 
> <bjorn.andersson@linaro.org>, linux-arm-msm@vger.kernel.org, 
> dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
>
> To follow up recent changes, rename (and change type of) second
> dp_display_enable()'s argument from generic u32 data to bool
> force_link_train, which is later passed to dp_ctrl_on_stream().
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com>

> ---
> Changes since v1:
>  - Added patch
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c 
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index fea610793dc4..96defacc92dc 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -608,7 +608,7 @@ static int dp_hpd_plug_handle(struct 
> dp_display_private *dp, u32 data)
>      return 0;
>  };
>  -static int dp_display_enable(struct dp_display_private *dp, u32 data);
> +static int dp_display_enable(struct dp_display_private *dp, bool 
> force_link_train);
>  static int dp_display_disable(struct dp_display_private *dp, u32 data);
>   static void dp_display_handle_plugged_change(struct msm_dp *dp_display,
> @@ -857,7 +857,7 @@ static int dp_display_set_mode(struct msm_dp 
> *dp_display,
>      return 0;
>  }
>  -static int dp_display_enable(struct dp_display_private *dp, u32 data)
> +static int dp_display_enable(struct dp_display_private *dp, bool 
> force_link_train)
>  {
>      int rc = 0;
>      struct msm_dp *dp_display = &dp->dp_display;
> @@ -868,7 +868,7 @@ static int dp_display_enable(struct 
> dp_display_private *dp, u32 data)
>          return 0;
>      }
>  -    rc = dp_ctrl_on_stream(dp->ctrl, data);
> +    rc = dp_ctrl_on_stream(dp->ctrl, force_link_train);
>      if (!rc)
>          dp_display->power_on = true;
>  -- 2.35.1
>