From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Will Deacon <will@kernel.org>, Rob Clark <robdclark@chromium.org>,
stable@vger.kernel.org, Lepton Wu <lepton@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Elliot Berman <quic_eberman@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Melody Olvera <quic_molvera@quicinc.com>,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>,
"open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's
Date: Wed, 17 May 2023 02:22:31 +0300 [thread overview]
Message-ID: <fdd07b5b-a3f5-0cbf-0d71-602d0b3b9847@linaro.org> (raw)
In-Reply-To: <20230516222039.907690-1-robdclark@gmail.com>
On 17/05/2023 01:20, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> When the special handling of qcom,adreno-smmu was moved into
> qcom_smmu_create(), it was overlooked that we didn't have all the
> required entries in qcom_smmu_impl_of_match. So we stopped getting
> adreno_smmu_priv on sc7180, breaking per-process pgtables.
>
> Fixes: 30b912a03d91 ("iommu/arm-smmu-qcom: Move the qcom,adreno-smmu check into qcom_smmu_create")
> Cc: <stable@vger.kernel.org>
> Suggested-by: Lepton Wu <lepton@chromium.org>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Will Deacon <will@kernel.org>, Rob Clark <robdclark@chromium.org>,
stable@vger.kernel.org, Lepton Wu <lepton@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Elliot Berman <quic_eberman@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Melody Olvera <quic_molvera@quicinc.com>,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>,
"open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's
Date: Wed, 17 May 2023 02:22:31 +0300 [thread overview]
Message-ID: <fdd07b5b-a3f5-0cbf-0d71-602d0b3b9847@linaro.org> (raw)
In-Reply-To: <20230516222039.907690-1-robdclark@gmail.com>
On 17/05/2023 01:20, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> When the special handling of qcom,adreno-smmu was moved into
> qcom_smmu_create(), it was overlooked that we didn't have all the
> required entries in qcom_smmu_impl_of_match. So we stopped getting
> adreno_smmu_priv on sc7180, breaking per-process pgtables.
>
> Fixes: 30b912a03d91 ("iommu/arm-smmu-qcom: Move the qcom,adreno-smmu check into qcom_smmu_create")
> Cc: <stable@vger.kernel.org>
> Suggested-by: Lepton Wu <lepton@chromium.org>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org
Cc: Rob Clark <robdclark@chromium.org>,
Lepton Wu <lepton@chromium.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
stable@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
Marijn Suijten <marijn.suijten@somainline.org>,
Melody Olvera <quic_molvera@quicinc.com>,
Elliot Berman <quic_eberman@quicinc.com>,
freedreno@lists.freedesktop.org,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's
Date: Wed, 17 May 2023 02:22:31 +0300 [thread overview]
Message-ID: <fdd07b5b-a3f5-0cbf-0d71-602d0b3b9847@linaro.org> (raw)
In-Reply-To: <20230516222039.907690-1-robdclark@gmail.com>
On 17/05/2023 01:20, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> When the special handling of qcom,adreno-smmu was moved into
> qcom_smmu_create(), it was overlooked that we didn't have all the
> required entries in qcom_smmu_impl_of_match. So we stopped getting
> adreno_smmu_priv on sc7180, breaking per-process pgtables.
>
> Fixes: 30b912a03d91 ("iommu/arm-smmu-qcom: Move the qcom,adreno-smmu check into qcom_smmu_create")
> Cc: <stable@vger.kernel.org>
> Suggested-by: Lepton Wu <lepton@chromium.org>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-05-16 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 22:20 [PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's Rob Clark
2023-05-16 22:20 ` Rob Clark
2023-05-16 22:20 ` Rob Clark
2023-05-16 22:20 ` [PATCH v4 2/2] drm/msm: Be more shouty if per-process pgtables aren't working Rob Clark
2023-05-16 22:20 ` Rob Clark
2023-05-16 23:22 ` Dmitry Baryshkov
2023-05-16 23:22 ` Dmitry Baryshkov
2023-05-16 23:22 ` Dmitry Baryshkov [this message]
2023-05-16 23:22 ` [PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's Dmitry Baryshkov
2023-05-16 23:22 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdd07b5b-a3f5-0cbf-0d71-602d0b3b9847@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@linaro.org \
--cc=lepton@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.