From: David Laight <David.Laight@ACULAB.COM> To: 'Matteo Croce' <mcroce@linux.microsoft.com> Cc: Nick Kossifidis <mick@ics.forth.gr>, "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Atish Patra <atish.patra@wdc.com>, Emil Renner Berthing <kernel@esmil.dk>, Akira Tsukamoto <akira.tsukamoto@gmail.com>, Drew Fustini <drew@beagleboard.org>, Bin Meng <bmeng.cn@gmail.com>, Guo Ren <guoren@kernel.org> Subject: RE: [PATCH v3 3/3] riscv: optimized memset Date: Wed, 23 Jun 2021 09:05:48 +0000 [thread overview] Message-ID: <fe6c2f646cf1468c89622cc1d848ae0c@AcuMS.aculab.com> (raw) In-Reply-To: <CAFnufp1XeKM-N1MdWsNpU6NnF-dYUgGXL1W9r_DDWazTMyRHVA@mail.gmail.com> From: Matteo Croce > Sent: 23 June 2021 02:15 > > On Tue, Jun 22, 2021 at 10:38 AM David Laight <David.Laight@aculab.com> wrote: > > > > From: Nick Kossifidis ... > > You can just write: > > cu = (unsigned long)c * 0x0101010101010101ull; > > and let the compiler sort out the best way to generate the constant. > > > > Interesting. I see that most compilers do an integer multiplication, > is it faster than three shift and three or? > > clang on riscv generates even more instructions to create the immediate: > > unsigned long repeat_shift(int c) > { > unsigned long cu = (unsigned long)c; > cu |= cu << 8; > cu |= cu << 16; > cu |= cu << 32; > > return cu; > } > > unsigned long repeat_mul(int c) > { > return (unsigned long)c * 0x0101010101010101ull; > } > > repeat_shift: > slli a1, a0, 8 > or a0, a0, a1 > slli a1, a0, 16 > or a0, a0, a1 > slli a1, a0, 32 > or a0, a0, a1 > ret > > repeat_mul: > lui a1, 4112 > addiw a1, a1, 257 > slli a1, a1, 16 > addi a1, a1, 257 > slli a1, a1, 16 > addi a1, a1, 257 > mul a0, a0, a1 > ret Hmmm... I expected the compiler to convert it to the first form. It is also pretty crap at generating that constant. Stupid compilers. In any case, for the usual case of 'c' being a constant zero you really don't want the latency of those instructions at all. It is almost worth just pushing that expansion into the caller. eg by having: #define memset(p, v, l) memset_w(p, (v) * 0x0101010101010101, l) (or some other byte replicator). Really annoyingly you want to write the code that generates the 64bit constant, and then have the compiler optimise away the part that generates the high 32 bits on 32 bits systems. But one of the compilers is going to 'bleat' about truncating a constant value. Stupid compilers (again). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM> To: 'Matteo Croce' <mcroce@linux.microsoft.com> Cc: Nick Kossifidis <mick@ics.forth.gr>, "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Atish Patra <atish.patra@wdc.com>, Emil Renner Berthing <kernel@esmil.dk>, Akira Tsukamoto <akira.tsukamoto@gmail.com>, Drew Fustini <drew@beagleboard.org>, Bin Meng <bmeng.cn@gmail.com>, Guo Ren <guoren@kernel.org> Subject: RE: [PATCH v3 3/3] riscv: optimized memset Date: Wed, 23 Jun 2021 09:05:48 +0000 [thread overview] Message-ID: <fe6c2f646cf1468c89622cc1d848ae0c@AcuMS.aculab.com> (raw) In-Reply-To: <CAFnufp1XeKM-N1MdWsNpU6NnF-dYUgGXL1W9r_DDWazTMyRHVA@mail.gmail.com> From: Matteo Croce > Sent: 23 June 2021 02:15 > > On Tue, Jun 22, 2021 at 10:38 AM David Laight <David.Laight@aculab.com> wrote: > > > > From: Nick Kossifidis ... > > You can just write: > > cu = (unsigned long)c * 0x0101010101010101ull; > > and let the compiler sort out the best way to generate the constant. > > > > Interesting. I see that most compilers do an integer multiplication, > is it faster than three shift and three or? > > clang on riscv generates even more instructions to create the immediate: > > unsigned long repeat_shift(int c) > { > unsigned long cu = (unsigned long)c; > cu |= cu << 8; > cu |= cu << 16; > cu |= cu << 32; > > return cu; > } > > unsigned long repeat_mul(int c) > { > return (unsigned long)c * 0x0101010101010101ull; > } > > repeat_shift: > slli a1, a0, 8 > or a0, a0, a1 > slli a1, a0, 16 > or a0, a0, a1 > slli a1, a0, 32 > or a0, a0, a1 > ret > > repeat_mul: > lui a1, 4112 > addiw a1, a1, 257 > slli a1, a1, 16 > addi a1, a1, 257 > slli a1, a1, 16 > addi a1, a1, 257 > mul a0, a0, a1 > ret Hmmm... I expected the compiler to convert it to the first form. It is also pretty crap at generating that constant. Stupid compilers. In any case, for the usual case of 'c' being a constant zero you really don't want the latency of those instructions at all. It is almost worth just pushing that expansion into the caller. eg by having: #define memset(p, v, l) memset_w(p, (v) * 0x0101010101010101, l) (or some other byte replicator). Really annoyingly you want to write the code that generates the 64bit constant, and then have the compiler optimise away the part that generates the high 32 bits on 32 bits systems. But one of the compilers is going to 'bleat' about truncating a constant value. Stupid compilers (again). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-06-23 9:05 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-17 15:27 [PATCH v3 0/3] riscv: optimized mem* functions Matteo Croce 2021-06-17 15:27 ` Matteo Croce 2021-06-17 15:27 ` [PATCH v3 1/3] riscv: optimized memcpy Matteo Croce 2021-06-17 15:27 ` Matteo Croce 2021-06-18 14:06 ` kernel test robot 2021-06-18 14:06 ` kernel test robot 2021-06-18 14:06 ` kernel test robot 2021-06-21 14:26 ` Christoph Hellwig 2021-06-21 14:26 ` Christoph Hellwig 2021-06-22 8:19 ` David Laight 2021-06-22 8:19 ` David Laight 2021-06-22 22:53 ` Matteo Croce 2021-06-22 22:53 ` Matteo Croce 2021-06-22 22:00 ` Matteo Croce 2021-06-22 22:00 ` Matteo Croce 2021-06-22 0:14 ` Nick Kossifidis 2021-06-22 0:14 ` Nick Kossifidis 2021-06-22 23:35 ` Matteo Croce 2021-06-22 23:35 ` Matteo Croce 2021-06-23 9:48 ` Nick Kossifidis 2021-06-23 9:48 ` Nick Kossifidis 2021-06-17 15:27 ` [PATCH v3 2/3] riscv: optimized memmove Matteo Croce 2021-06-17 15:27 ` Matteo Croce 2021-06-21 14:28 ` Christoph Hellwig 2021-06-21 14:28 ` Christoph Hellwig 2021-06-22 0:46 ` Nick Kossifidis 2021-06-22 0:46 ` Nick Kossifidis 2021-06-30 4:40 ` kernel test robot 2021-06-30 4:40 ` kernel test robot 2021-06-30 4:40 ` kernel test robot 2021-06-17 15:27 ` [PATCH v3 3/3] riscv: optimized memset Matteo Croce 2021-06-17 15:27 ` Matteo Croce 2021-06-21 14:32 ` Christoph Hellwig 2021-06-21 14:32 ` Christoph Hellwig 2021-06-22 1:07 ` Nick Kossifidis 2021-06-22 1:07 ` Nick Kossifidis 2021-06-22 8:38 ` David Laight 2021-06-22 8:38 ` David Laight 2021-06-23 1:14 ` Matteo Croce 2021-06-23 1:14 ` Matteo Croce 2021-06-23 9:05 ` David Laight [this message] 2021-06-23 9:05 ` David Laight 2021-06-23 0:08 ` Matteo Croce 2021-06-23 0:08 ` Matteo Croce 2021-06-22 1:09 ` [PATCH v3 0/3] riscv: optimized mem* functions Nick Kossifidis 2021-06-22 1:09 ` Nick Kossifidis 2021-06-22 2:39 ` Guo Ren 2021-06-22 2:39 ` Guo Ren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fe6c2f646cf1468c89622cc1d848ae0c@AcuMS.aculab.com \ --to=david.laight@aculab.com \ --cc=akira.tsukamoto@gmail.com \ --cc=aou@eecs.berkeley.edu \ --cc=atish.patra@wdc.com \ --cc=bmeng.cn@gmail.com \ --cc=drew@beagleboard.org \ --cc=guoren@kernel.org \ --cc=kernel@esmil.dk \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mcroce@linux.microsoft.com \ --cc=mick@ics.forth.gr \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.