From: Daniel Mack <daniel@zonque.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
broonie@kernel.org, lars@metafoo.de, pascal.huerst@gmail.com
Subject: Re: [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers
Date: Tue, 17 Dec 2019 20:36:40 +0100 [thread overview]
Message-ID: <ff062a37-e07d-3d6c-7fa5-9e6dc74b1aa9@zonque.org> (raw)
In-Reply-To: <20191217134617.GK18955@dell>
Hi Lee,
On 12/17/19 2:46 PM, Lee Jones wrote:
> One thing I should mention upfront; there is too much code "doing
> things" in here for it to be an MFD. MFDs don't care about; syncs,
> slots, TDM, inverting lines, upstreams, downstreams, etc etc etc.
> Anything remotely technical or functional, the code that "does things"
> should be moved out to the relevant areas. In the case of this
> device, that's looking like one of the Audio related subsystems.
Okay, that's good to know.
I in fact considered that when I started working on it; after all, A2B
stands for "automotive audio bus". The reason why I didn't do it was the
fact that these devices certainly do have multiple functions, where
audio is just one of them, and there needs to be a 'top-level' layer
that enables all these functions and does the node discovery etc. Hence
I thought it's cleaner to separate things that way.
I can move things over to the ASoC layer for the next iteration, and
then maybe also merge the codec driver with the baseline drivers. Let's
see how this looks like then.
Thanks,
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Mack <daniel@zonque.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lars@metafoo.de, sboyd@kernel.org, mturquette@baylibre.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
robh+dt@kernel.org, broonie@kernel.org,
linux-i2c@vger.kernel.org, pascal.huerst@gmail.com,
linux-clk@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers
Date: Tue, 17 Dec 2019 20:36:40 +0100 [thread overview]
Message-ID: <ff062a37-e07d-3d6c-7fa5-9e6dc74b1aa9@zonque.org> (raw)
In-Reply-To: <20191217134617.GK18955@dell>
Hi Lee,
On 12/17/19 2:46 PM, Lee Jones wrote:
> One thing I should mention upfront; there is too much code "doing
> things" in here for it to be an MFD. MFDs don't care about; syncs,
> slots, TDM, inverting lines, upstreams, downstreams, etc etc etc.
> Anything remotely technical or functional, the code that "does things"
> should be moved out to the relevant areas. In the case of this
> device, that's looking like one of the Audio related subsystems.
Okay, that's good to know.
I in fact considered that when I started working on it; after all, A2B
stands for "automotive audio bus". The reason why I didn't do it was the
fact that these devices certainly do have multiple functions, where
audio is just one of them, and there needs to be a 'top-level' layer
that enables all these functions and does the node discovery etc. Hence
I thought it's cleaner to separate things that way.
I can move things over to the ASoC layer for the next iteration, and
then maybe also merge the codec driver with the baseline drivers. Let's
see how this looks like then.
Thanks,
Daniel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-17 19:36 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 18:35 [PATCH 00/10] mfd: Add support for Analog Devices A2B transceiver Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-09 18:35 ` [PATCH 01/10] dt-bindings: mfd: Add documentation for ad242x Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-19 19:29 ` Rob Herring
2019-12-19 19:29 ` [alsa-devel] " Rob Herring
2019-12-09 18:35 ` [PATCH 02/10] dt-bindings: i2c: Add documentation for ad242x i2c controllers Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2020-01-08 3:45 ` Rob Herring
2020-01-08 3:45 ` [alsa-devel] " Rob Herring
2019-12-09 18:35 ` [PATCH 03/10] dt-bindings: gpio: Add documentation for ad242x GPIO controllers Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-09 18:35 ` [PATCH 03/10] dt-bindings: gpio: Add documentation for AD242x " Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-09 18:35 ` [PATCH 04/10] dt-bindings: clock: Add documentation for AD242x clock providers Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-24 7:32 ` Stephen Boyd
2019-12-24 7:32 ` [alsa-devel] " Stephen Boyd
2019-12-24 7:32 ` Stephen Boyd
2019-12-09 18:35 ` [PATCH 05/10] dt-bindings: sound: Add documentation for AD242x codecs Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-09 18:35 ` [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-17 13:39 ` Lee Jones
2019-12-17 13:39 ` [alsa-devel] " Lee Jones
2019-12-17 13:46 ` Lee Jones
2019-12-17 13:46 ` [alsa-devel] " Lee Jones
2019-12-17 19:36 ` Daniel Mack [this message]
2019-12-17 19:36 ` Daniel Mack
2019-12-17 19:24 ` Daniel Mack
2019-12-17 19:24 ` [alsa-devel] " Daniel Mack
2019-12-18 11:20 ` Luca Ceresoli
2019-12-18 11:20 ` [alsa-devel] " Luca Ceresoli
2019-12-17 19:16 ` Pierre-Louis Bossart
2019-12-17 19:16 ` Pierre-Louis Bossart
2019-12-18 9:40 ` Daniel Mack
2019-12-18 9:40 ` Daniel Mack
2019-12-09 18:35 ` [PATCH 07/10] i2c: Add driver for AD242x bus controller Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-12 16:11 ` Luca Ceresoli
2019-12-12 16:11 ` [alsa-devel] " Luca Ceresoli
2019-12-12 16:33 ` Wolfram Sang
2019-12-12 16:33 ` [alsa-devel] " Wolfram Sang
2019-12-15 20:27 ` Daniel Mack
2019-12-15 20:27 ` [alsa-devel] " Daniel Mack
2019-12-17 8:35 ` Luca Ceresoli
2019-12-17 8:35 ` [alsa-devel] " Luca Ceresoli
2019-12-17 18:17 ` Daniel Mack
2019-12-17 18:17 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` [PATCH 08/10] gpio: Add driver for AD242x GPIO controllers Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-09 18:35 ` [PATCH 09/10] clk: Add support for AD242x clock output providers Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-24 7:46 ` Stephen Boyd
2019-12-24 7:46 ` [alsa-devel] " Stephen Boyd
2019-12-24 7:46 ` Stephen Boyd
2019-12-09 18:35 ` [PATCH 10/10] ASoC: Add codec component for AD242x nodes Daniel Mack
2019-12-09 18:35 ` [alsa-devel] " Daniel Mack
2019-12-09 18:35 ` Daniel Mack
2019-12-16 14:23 ` Mark Brown
2019-12-16 14:23 ` [alsa-devel] " Mark Brown
2019-12-17 19:28 ` Pierre-Louis Bossart
2019-12-17 19:28 ` Pierre-Louis Bossart
2019-12-18 9:49 ` Daniel Mack
2019-12-18 9:49 ` Daniel Mack
2019-12-18 15:32 ` Pierre-Louis Bossart
2019-12-18 15:32 ` Pierre-Louis Bossart
2019-12-20 8:24 ` Daniel Mack
2019-12-20 15:18 ` Pierre-Louis Bossart
2019-12-17 19:29 ` [alsa-devel] [PATCH 00/10] mfd: Add support for Analog Devices A2B transceiver Pierre-Louis Bossart
2019-12-17 19:29 ` Pierre-Louis Bossart
2019-12-18 9:53 ` Daniel Mack
2019-12-18 9:53 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff062a37-e07d-3d6c-7fa5-9e6dc74b1aa9@zonque.org \
--to=daniel@zonque.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pascal.huerst@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.