From: Oleksandr Andrushchenko <andr2000@gmail.com> To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, jgross@suse.com, konrad.wilk@oracle.com Cc: daniel.vetter@intel.com, dongwon.kim@intel.com, matthew.d.roper@intel.com, Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Subject: Re: [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA Date: Wed, 13 Jun 2018 10:07:58 +0300 [thread overview] Message-ID: <ffd6eb5a-b057-8cca-c8cb-75fd97b63a45@gmail.com> (raw) In-Reply-To: <4ab26c9a-155a-cd04-fbf6-c38c6429959b@oracle.com> On 06/13/2018 04:12 AM, Boris Ostrovsky wrote: > > > On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >> >> Extend grant table module API to allow allocating buffers that can >> be used for DMA operations and mapping foreign grant references >> on top of those. >> The resulting buffer is similar to the one allocated by the balloon >> driver in terms that proper memory reservation is made >> ({increase|decrease}_reservation and VA mappings updated if needed). >> This is useful for sharing foreign buffers with HW drivers which >> cannot work with scattered buffers provided by the balloon driver, >> but require DMAable memory instead. >> >> Signed-off-by: Oleksandr Andrushchenko >> <oleksandr_andrushchenko@epam.com> > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > with a small nit below > > >> --- >> drivers/xen/Kconfig | 13 ++++++ >> drivers/xen/grant-table.c | 97 +++++++++++++++++++++++++++++++++++++++ >> include/xen/grant_table.h | 18 ++++++++ >> 3 files changed, 128 insertions(+) >> >> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig >> index e5d0c28372ea..39536ddfbce4 100644 >> --- a/drivers/xen/Kconfig >> +++ b/drivers/xen/Kconfig >> @@ -161,6 +161,19 @@ config XEN_GRANT_DEV_ALLOC >> to other domains. This can be used to implement frontend drivers >> or as part of an inter-domain shared memory channel. >> +config XEN_GRANT_DMA_ALLOC >> + bool "Allow allocating DMA capable buffers with grant reference >> module" >> + depends on XEN && HAS_DMA >> + help >> + Extends grant table module API to allow allocating DMA capable >> + buffers and mapping foreign grant references on top of it. >> + The resulting buffer is similar to one allocated by the balloon >> + driver in terms that proper memory reservation is made >> + ({increase|decrease}_reservation and VA mappings updated if >> needed). > > I think you should drop the word "terms" and say "is made *by*" and > "VA mappings *are* updated" > > And similar change in the commit message. > Will, change, thank you > -boris >
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr Andrushchenko <andr2000@gmail.com> To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, jgross@suse.com, konrad.wilk@oracle.com Cc: daniel.vetter@intel.com, dongwon.kim@intel.com, Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Subject: Re: [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA Date: Wed, 13 Jun 2018 10:07:58 +0300 [thread overview] Message-ID: <ffd6eb5a-b057-8cca-c8cb-75fd97b63a45@gmail.com> (raw) In-Reply-To: <4ab26c9a-155a-cd04-fbf6-c38c6429959b@oracle.com> On 06/13/2018 04:12 AM, Boris Ostrovsky wrote: > > > On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >> >> Extend grant table module API to allow allocating buffers that can >> be used for DMA operations and mapping foreign grant references >> on top of those. >> The resulting buffer is similar to the one allocated by the balloon >> driver in terms that proper memory reservation is made >> ({increase|decrease}_reservation and VA mappings updated if needed). >> This is useful for sharing foreign buffers with HW drivers which >> cannot work with scattered buffers provided by the balloon driver, >> but require DMAable memory instead. >> >> Signed-off-by: Oleksandr Andrushchenko >> <oleksandr_andrushchenko@epam.com> > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > with a small nit below > > >> --- >> drivers/xen/Kconfig | 13 ++++++ >> drivers/xen/grant-table.c | 97 +++++++++++++++++++++++++++++++++++++++ >> include/xen/grant_table.h | 18 ++++++++ >> 3 files changed, 128 insertions(+) >> >> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig >> index e5d0c28372ea..39536ddfbce4 100644 >> --- a/drivers/xen/Kconfig >> +++ b/drivers/xen/Kconfig >> @@ -161,6 +161,19 @@ config XEN_GRANT_DEV_ALLOC >> to other domains. This can be used to implement frontend drivers >> or as part of an inter-domain shared memory channel. >> +config XEN_GRANT_DMA_ALLOC >> + bool "Allow allocating DMA capable buffers with grant reference >> module" >> + depends on XEN && HAS_DMA >> + help >> + Extends grant table module API to allow allocating DMA capable >> + buffers and mapping foreign grant references on top of it. >> + The resulting buffer is similar to one allocated by the balloon >> + driver in terms that proper memory reservation is made >> + ({increase|decrease}_reservation and VA mappings updated if >> needed). > > I think you should drop the word "terms" and say "is made *by*" and > "VA mappings *are* updated" > > And similar change in the commit message. > Will, change, thank you > -boris > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-13 7:08 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-12 13:41 [PATCH v3 0/9] xen: dma-buf support for grant device Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 1/9] xen/grant-table: Export gnttab_{alloc|free}_pages as GPL Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 2/9] xen/grant-table: Make set/clear page private code shared Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 3/9] xen/balloon: Share common memory reservation routines Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-13 0:47 ` Boris Ostrovsky 2018-06-13 6:26 ` Oleksandr Andrushchenko 2018-06-13 6:26 ` Oleksandr Andrushchenko 2018-06-13 12:02 ` Boris Ostrovsky 2018-06-13 12:02 ` Boris Ostrovsky 2018-06-13 12:03 ` Oleksandr Andrushchenko 2018-06-13 12:03 ` Oleksandr Andrushchenko 2018-06-13 12:27 ` Oleksandr Andrushchenko 2018-06-13 12:27 ` Oleksandr Andrushchenko 2018-06-13 0:47 ` Boris Ostrovsky 2018-06-13 1:07 ` Boris Ostrovsky 2018-06-13 6:50 ` Oleksandr Andrushchenko 2018-06-13 6:50 ` Oleksandr Andrushchenko 2018-06-13 1:07 ` Boris Ostrovsky 2018-06-12 13:41 ` [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-13 1:12 ` Boris Ostrovsky 2018-06-13 7:07 ` Oleksandr Andrushchenko 2018-06-13 7:07 ` Oleksandr Andrushchenko [this message] 2018-06-13 7:07 ` Oleksandr Andrushchenko 2018-06-13 1:12 ` Boris Ostrovsky 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 5/9] xen/gntdev: Allow mappings for DMA buffers Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-13 1:26 ` Boris Ostrovsky 2018-06-13 1:26 ` Boris Ostrovsky 2018-06-13 7:16 ` Oleksandr Andrushchenko 2018-06-13 7:16 ` Oleksandr Andrushchenko 2018-06-14 7:00 ` Oleksandr Andrushchenko 2018-06-14 7:00 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 6/9] xen/gntdev: Make private routines/structures accessible Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-13 1:38 ` Boris Ostrovsky 2018-06-13 1:38 ` Boris Ostrovsky 2018-06-13 7:23 ` Oleksandr Andrushchenko 2018-06-13 7:23 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 7/9] xen/gntdev: Add initial support for dma-buf UAPI Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-13 1:49 ` Boris Ostrovsky 2018-06-13 1:49 ` Boris Ostrovsky 2018-06-13 8:17 ` Oleksandr Andrushchenko 2018-06-13 8:17 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-12 13:41 ` Oleksandr Andrushchenko 2018-06-13 2:58 ` Boris Ostrovsky 2018-06-13 11:57 ` Oleksandr Andrushchenko 2018-06-13 11:57 ` Oleksandr Andrushchenko 2018-06-13 22:19 ` Boris Ostrovsky 2018-06-13 22:19 ` Boris Ostrovsky 2018-06-14 5:41 ` Oleksandr Andrushchenko 2018-06-14 5:41 ` Oleksandr Andrushchenko 2018-06-13 2:58 ` Boris Ostrovsky 2018-06-12 13:42 ` [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality Oleksandr Andrushchenko 2018-06-13 3:14 ` Boris Ostrovsky 2018-06-13 9:04 ` Oleksandr Andrushchenko 2018-06-13 9:04 ` Oleksandr Andrushchenko 2018-06-13 22:03 ` Boris Ostrovsky 2018-06-13 22:03 ` Boris Ostrovsky 2018-06-14 6:39 ` Oleksandr Andrushchenko 2018-06-14 6:39 ` Oleksandr Andrushchenko 2018-06-13 3:14 ` Boris Ostrovsky 2018-06-12 13:42 ` Oleksandr Andrushchenko 2018-06-14 6:47 ` [PATCH v3 0/9] xen: dma-buf support for grant device Oleksandr Andrushchenko 2018-06-14 6:47 ` Oleksandr Andrushchenko 2018-06-14 17:48 ` Boris Ostrovsky 2018-06-14 17:48 ` Boris Ostrovsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ffd6eb5a-b057-8cca-c8cb-75fd97b63a45@gmail.com \ --to=andr2000@gmail.com \ --cc=boris.ostrovsky@oracle.com \ --cc=daniel.vetter@intel.com \ --cc=dongwon.kim@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jgross@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=matthew.d.roper@intel.com \ --cc=oleksandr_andrushchenko@epam.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.