[PATCH 1/1] engines/http.c: add fallthrough annotation to _curl_trace

[PATCH 1/1] engines/http.c: add fallthrough annotation to _curl_trace

[Rebecca Cran]

To avoid the warning from clang "warning: unannotated fall-through
between switch labels [-Wimplicit-fallthrough]" swap the "fall through"
comment with the "fallthrough;" annotation from compiler.h.

Since the second "fall through" comment isn't really a new fall-through,
remove it.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 engines/http.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/engines/http.c b/engines/http.c
index 7a61b132b92b..35c44871da63 100644
--- a/engines/http.c
+++ b/engines/http.c
@@ -297,10 +297,9 @@ static int _curl_trace(CURL *handle, curl_infotype type,
 	switch (type) {
 	case CURLINFO_TEXT:
 		fprintf(stderr, "== Info: %s", data);
-		/* fall through */
+		fallthrough;
 	default:
 	case CURLINFO_SSL_DATA_OUT:
-		/* fall through */
 	case CURLINFO_SSL_DATA_IN:
 		return 0;
 
-- 
2.31.1

Re: [PATCH 1/1] engines/http.c: add fallthrough annotation to _curl_trace

[Jens Axboe]

On Sat, 16 Oct 2021 00:17:38 -0600, Rebecca Cran wrote:
> To avoid the warning from clang "warning: unannotated fall-through
> between switch labels [-Wimplicit-fallthrough]" swap the "fall through"
> comment with the "fallthrough;" annotation from compiler.h.
> 
> Since the second "fall through" comment isn't really a new fall-through,
> remove it.
> 
> [...]

Applied, thanks!

[1/1] engines/http.c: add fallthrough annotation to _curl_trace
      commit: d853907223ca610c85a81cfe238ffd93b97520e7

Best regards,
-- 
Jens Axboe